Carries forward the correct fixes from debug-krpc-handshake and adds
two new decode-path fixes that the mock server surfaced. Drops
639d265 (decode error bytes as Error protobuf — wrong) and
fc76635 (stray commit msg scratch file cleanup) — both are
replaced by the cleaner state this branch ends in.
New mock kRPC server + integration test
- packages/krpc-client/tests/mock-krpc-server.ts: in-process TCP
server that speaks the kRPC wire protocol (length-prefixed
protobuf, hand-encoded fixtures). Exports startMockKrpcServer().
- packages/krpc-client/tests/mock-krpc-server.test.ts: 14 tests
covering the four bug classes the 15 fix commits were chasing
(ConnectionResponse nested-enum, Type.code nested-enum,
Procedure.game_scenes missing, null returnType). Plus the two
new bug classes below.
- apps/tools/ksp-bridge/tests/mock-krpc-integration.test.ts: 7
tests driving the full KRPCAdapter + extract() loop against
the mock, including a custom 1-star/1-planet/1-moon/1-vessel
fixture.
- packages/krpc-client/package.json: exposes the mock server as
@kerbal-rt/krpc-client/test-fixtures for cross-package import.
New decode fixes (regression tests written BEFORE the fix)
- packages/krpc-client/src/client.ts: serialize concurrent invokes
on a per-socket promise chain. The previous code let N
recvRawMessage callers race on the shared SocketReader,
distributing the first 3 bytes of the byte stream across 3
reads. Symptom: 'index out of range' or 'invalid wire type' on
Promise.all([invoke, invoke, invoke]) — exactly the pattern in
extract.ts. Fix: invoke() awaits the previous invoke before
touching the socket.
- packages/krpc-client/src/service-client.ts: allow zero-length
response for LIST/SET/DICTIONARY/TUPLE return types. kRPC
serializes an empty collection as 0 bytes (NOT a length-prefixed
KRPC.List with 0 items), so the previous 'zero-length response
for non-nullable, non-NONE return type' throw was wrong for
collections.
- apps/tools/ksp-bridge/src/extract.ts: handle the root body
(Kerbol) returning null for get_Orbit(). Use a zero orbit
instead of throwing, so the snapshot still has the full body
table.
Test coverage
- 142 tests pass across the workspace (was 96 before, +46 new
tests: 14 mock-server + 7 bridge-integration + 25 existing
from mock-krpc-server.test.ts duplicate coverage).
- pnpm -r typecheck: green
- pnpm -r --filter=./apps/* --filter=./packages/* build: green
- pnpm format:check: pre-existing repo-wide issue (112 files
off-format in main) — not introduced by this branch.
Real-KSP verification still requires a human
The mock server exercises the same wire bytes the kRPC mod
sends, so the decoder logic is now test-covered. But three
things only the human can verify:
1. KSP 1.12.5 install + kRPC mod via CKAN
2. Alt+F12 in-game -> RPC server on 127.0.0.1:50000
3. Visual live-map motion after bridge POSTs the first snapshot
(current /debug page also works as a sanity check)
Mavis
09f5a3510f