Refactor Docker and Makefile configurations for improved build processes

- Updated docker-compose.tools.yml to mount source code at /src and set working directory for backend tools, ensuring proper Go module caching.
- Modified Dockerfile.tools to install the latest golangci-lint version compatible with Go 1.24 and adjusted working directory for build-time operations.
- Enhanced Makefile to build backend tools before running tests and linting, ensuring dependencies are up-to-date and improving overall workflow efficiency.
- Refactored test and handler files to include error handling for database operations, enhancing reliability and debugging capabilities.

internal/app/handlers/client.go

@@ -66,7 +66,7 @@ func (h *Handlers) clientLocate(rw http.ResponseWriter, req *http.Request) {
 	}
 	rw.Header().Set("Content-Type", "text/plain")
 	rw.WriteHeader(http.StatusOK)
-	rw.Write([]byte(result))
+	_, _ = rw.Write([]byte(result))
 }
 
 func (h *Handlers) clientGridUpdate(rw http.ResponseWriter, req *http.Request) {
@@ -85,7 +85,7 @@ func (h *Handlers) clientGridUpdate(rw http.ResponseWriter, req *http.Request) {
 	}
 	rw.Header().Set("Content-Type", "application/json")
 	rw.WriteHeader(http.StatusOK)
-	json.NewEncoder(rw).Encode(result.Response)
+	_ = json.NewEncoder(rw).Encode(result.Response)
 }
 
 func (h *Handlers) clientGridUpload(rw http.ResponseWriter, req *http.Request) {

internal/app/handlers/handlers_test.go

@@ -64,9 +64,11 @@ func (env *testEnv) createUser(t *testing.T, username, password string, auths ap
 	hash, _ := bcrypt.GenerateFromPassword([]byte(password), bcrypt.MinCost)
 	u := app.User{Pass: hash, Auths: auths}
 	raw, _ := json.Marshal(u)
-	env.st.Update(context.Background(), func(tx *bbolt.Tx) error {
+	if err := env.st.Update(context.Background(), func(tx *bbolt.Tx) error {
 		return env.st.PutUser(tx, username, raw)
-	})
+	}); err != nil {
+		t.Fatal(err)
+	}
 }
 
 func (env *testEnv) loginSession(t *testing.T, username string) string {
@@ -90,7 +92,7 @@ func TestAPISetup_NoUsers(t *testing.T) {
 	}
 
 	var resp struct{ SetupRequired bool }
-	json.NewDecoder(rr.Body).Decode(&resp)
+	_ = json.NewDecoder(rr.Body).Decode(&resp)
 	if !resp.SetupRequired {
 		t.Fatal("expected setupRequired=true")
 	}
@@ -105,7 +107,7 @@ func TestAPISetup_WithUsers(t *testing.T) {
 	env.h.APISetup(rr, req)
 
 	var resp struct{ SetupRequired bool }
-	json.NewDecoder(rr.Body).Decode(&resp)
+	_ = json.NewDecoder(rr.Body).Decode(&resp)
 	if resp.SetupRequired {
 		t.Fatal("expected setupRequired=false with users")
 	}
@@ -196,7 +198,7 @@ func TestAPIMe_Authenticated(t *testing.T) {
 		Username string   `json:"username"`
 		Auths    []string `json:"auths"`
 	}
-	json.NewDecoder(rr.Body).Decode(&resp)
+	_ = json.NewDecoder(rr.Body).Decode(&resp)
 	if resp.Username != "alice" {
 		t.Fatalf("expected alice, got %s", resp.Username)
 	}
@@ -245,7 +247,7 @@ func TestAPIMeTokens_Authenticated(t *testing.T) {
 		t.Fatalf("expected 200, got %d: %s", rr.Code, rr.Body.String())
 	}
 	var resp struct{ Tokens []string }
-	json.NewDecoder(rr.Body).Decode(&resp)
+	_ = json.NewDecoder(rr.Body).Decode(&resp)
 	if len(resp.Tokens) != 1 {
 		t.Fatalf("expected 1 token, got %d", len(resp.Tokens))
 	}
@@ -396,7 +398,7 @@ func TestAdminSettings(t *testing.T) {
 		DefaultHide bool   `json:"defaultHide"`
 		Title       string `json:"title"`
 	}
-	json.NewDecoder(rr3.Body).Decode(&resp)
+	_ = json.NewDecoder(rr3.Body).Decode(&resp)
 	if resp.Prefix != "pfx" || !resp.DefaultHide || resp.Title != "New Title" {
 		t.Fatalf("unexpected settings: %+v", resp)
 	}
@@ -493,7 +495,7 @@ func TestAPIGetChars_NoMarkersAuth(t *testing.T) {
 		t.Fatalf("expected 200, got %d", rr.Code)
 	}
 	var chars []interface{}
-	json.NewDecoder(rr.Body).Decode(&chars)
+	_ = json.NewDecoder(rr.Body).Decode(&chars)
 	if len(chars) != 0 {
 		t.Fatal("expected empty array without markers auth")
 	}
@@ -511,7 +513,7 @@ func TestAPIGetMarkers_NoMarkersAuth(t *testing.T) {
 		t.Fatalf("expected 200, got %d", rr.Code)
 	}
 	var markers []interface{}
-	json.NewDecoder(rr.Body).Decode(&markers)
+	_ = json.NewDecoder(rr.Body).Decode(&markers)
 	if len(markers) != 0 {
 		t.Fatal("expected empty array without markers auth")
 	}
@@ -583,7 +585,7 @@ func TestAdminUserByName(t *testing.T) {
 		Username string   `json:"username"`
 		Auths    []string `json:"auths"`
 	}
-	json.NewDecoder(rr.Body).Decode(&resp)
+	_ = json.NewDecoder(rr.Body).Decode(&resp)
 	if resp.Username != "bob" {
 		t.Fatalf("expected bob, got %s", resp.Username)
 	}
@@ -613,9 +615,11 @@ func TestClientRouter_Locate(t *testing.T) {
 	}
 	gd := app.GridData{ID: "g1", Map: 1, Coord: app.Coord{X: 2, Y: 3}}
 	raw, _ := json.Marshal(gd)
-	env.st.Update(ctx, func(tx *bbolt.Tx) error {
+	if err := env.st.Update(ctx, func(tx *bbolt.Tx) error {
 		return env.st.PutGrid(tx, "g1", raw)
-	})
+	}); err != nil {
+		t.Fatal(err)
+	}
 
 	req := httptest.NewRequest(http.MethodGet, "/client/"+tokens[0]+"/locate?gridID=g1", nil)
 	rr := httptest.NewRecorder()

internal/app/handlers/tile.go

@@ -55,7 +55,7 @@ func (h *Handlers) WatchGridUpdates(rw http.ResponseWriter, req *http.Request) {
 	tileCache := []services.TileCache{}
 	raw, _ := json.Marshal(tileCache)
 	fmt.Fprint(rw, "data: ")
-	rw.Write(raw)
+	_, _ = rw.Write(raw)
 	fmt.Fprint(rw, "\n\n")
 	flusher.Flush()
 
@@ -93,13 +93,13 @@ func (h *Handlers) WatchGridUpdates(rw http.ResponseWriter, req *http.Request) {
 			}
 			fmt.Fprint(rw, "event: merge\n")
 			fmt.Fprint(rw, "data: ")
-			rw.Write(raw)
+			_, _ = rw.Write(raw)
 			fmt.Fprint(rw, "\n\n")
 			flusher.Flush()
 		case <-ticker.C:
 			raw, _ := json.Marshal(tileCache)
 			fmt.Fprint(rw, "data: ")
-			rw.Write(raw)
+			_, _ = rw.Write(raw)
 			fmt.Fprint(rw, "\n\n")
 			tileCache = tileCache[:0]
 			flusher.Flush()
@@ -152,7 +152,7 @@ func (h *Handlers) GridTile(rw http.ResponseWriter, req *http.Request) {
 		rw.Header().Set("Content-Type", "image/png")
 		rw.Header().Set("Cache-Control", "private, max-age=3600")
 		rw.WriteHeader(http.StatusOK)
-		rw.Write(transparentPNG)
+		_, _ = rw.Write(transparentPNG)
 		return
 	}