[codex] Add checkbox confirmation issue interactions (#7649)
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Agent work is coordinated through issues, comments, interactions, and approval-style handoffs. > - Existing issue-thread interactions could ask questions, suggest tasks, and request confirmation, but they did not support a structured checkbox confirmation payload for choosing one or more options. > - That gap made board/user confirmations harder to validate consistently across API callers, plugin helpers, CLI tooling, and the UI. > - This pull request adds the shared checkbox confirmation contract, server handling, client helpers, and issue-thread UI needed to render and submit structured selections. > - The benefit is that agents can request bounded multi-select confirmations in the same audited issue-thread flow as other Paperclip interactions. ## Linked Issues or Issue Description - No public GitHub issue found for this exact branch. Internal Paperclip issue: PAP-10415 / PAP-10441 requested creating this PR for the checkbox confirmation issue-thread UI component work. - GitHub duplicate search performed for checkbox confirmation / issue-thread interaction PRs; no matching open PR was found. - Related issue search result `#7497` was unrelated company file cleanup work, so it is not linked as a related issue. ## What Changed - Added shared types, validators, constants, and tests for `request_checkbox_confirmation` interactions. - Extended server issue-thread interaction service and routes for checkbox confirmation creation, validation, expiration, and response handling. - Added CLI, MCP, and plugin SDK helper coverage so external callers can create the new interaction shape consistently. - Updated the issue-thread interaction UI to render checkbox confirmations with min/max bounds, selection summaries, stale-target states, and accept/decline flows. - Documented the checkbox confirmation interaction contract in the Paperclip skill/API reference. ## Verification - Rebased cleanly on `paperclipai/paperclip` `master` fetched into `public-gh/master` at `a4fa0eaf5`. - Confirmed the PR diff does not include `pnpm-lock.yaml` or `.github/workflows` changes. - Ran focused tests with `NODE_ENV=test`: ```sh NODE_ENV=test pnpm run preflight:workspace-links NODE_ENV=test pnpm exec vitest run packages/shared/src/issue-thread-interactions.test.ts server/src/__tests__/issue-thread-interaction-routes.test.ts server/src/__tests__/issue-thread-interactions-service.test.ts ui/src/components/IssueThreadInteractionCard.test.tsx ui/src/lib/issue-thread-interactions.test.ts cli/src/__tests__/issue-subresources.test.ts cli/src/__tests__/project-goal.test.ts packages/mcp-server/src/tools.test.ts packages/plugins/sdk/tests/testing-actions.test.ts ``` Result: 8 test files passed, 78 tests passed. - CI on latest head `63b9e55` is green. - Greptile Review passed on latest head; GraphQL review-thread check shows all Greptile threads resolved. ## Risks - Medium surface area because the interaction contract touches shared validators, server routes/services, UI rendering, CLI, MCP, plugin SDK helpers, and docs. - No database migrations are included. - `pnpm-lock.yaml` is intentionally excluded per repository lockfile policy. - UI screenshots are not attached because the task explicitly requested not to add design screenshots or images unless they were part of the work; component tests cover the new rendering and interaction states. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex coding agent based on GPT-5, with repository file access, shell command execution, git/GitHub CLI tooling, and Paperclip control-plane API access. Exact hosted model ID/context-window metadata is not exposed inside this runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Dotta
@@ -6,6 +6,7 @@ import type {
|
||||
import type { IssueTimelineEvent } from "../lib/issue-timeline-events";
|
||||
import type {
|
||||
AskUserQuestionsInteraction,
|
||||
RequestCheckboxConfirmationInteraction,
|
||||
RequestConfirmationInteraction,
|
||||
SuggestTasksInteraction,
|
||||
} from "../lib/issue-thread-interactions";
|
||||
@@ -224,6 +225,65 @@ function createRequestConfirmationInteraction(
|
||||
};
|
||||
}
|
||||
|
||||
function createRequestCheckboxConfirmationInteraction(
|
||||
overrides: Partial<RequestCheckboxConfirmationInteraction>,
|
||||
): RequestCheckboxConfirmationInteraction {
|
||||
return {
|
||||
id: "interaction-checkbox-default",
|
||||
companyId: issueThreadInteractionFixtureMeta.companyId,
|
||||
issueId: issueThreadInteractionFixtureMeta.issueId,
|
||||
kind: "request_checkbox_confirmation",
|
||||
title: "Choose the stale drafts to delete",
|
||||
summary:
|
||||
"The agent found several stale draft documents and needs the board to confirm exactly which ones to remove.",
|
||||
status: "pending",
|
||||
continuationPolicy: "wake_assignee",
|
||||
createdByAgentId: "agent-codex",
|
||||
createdByUserId: null,
|
||||
resolvedByAgentId: null,
|
||||
resolvedByUserId: null,
|
||||
createdAt: new Date("2026-04-20T14:46:00.000Z"),
|
||||
updatedAt: new Date("2026-04-20T14:46:00.000Z"),
|
||||
resolvedAt: null,
|
||||
payload: {
|
||||
version: 1,
|
||||
prompt: "Check the draft documents you want me to delete.",
|
||||
detailsMarkdown:
|
||||
"Only the checked items will be deleted. Leave an item unchecked to keep it for now.",
|
||||
options: [
|
||||
{
|
||||
id: "draft-march-report",
|
||||
label: "Old draft report",
|
||||
description: "Created by QA during the March test pass.",
|
||||
},
|
||||
{
|
||||
id: "draft-spec-v1",
|
||||
label: "Spec v1 (superseded)",
|
||||
description: "Replaced by the approved v2 specification.",
|
||||
},
|
||||
{
|
||||
id: "draft-scratch-notes",
|
||||
label: "Scratch notes",
|
||||
description: "Unstructured notes from the kickoff call.",
|
||||
},
|
||||
{
|
||||
id: "draft-import-sample",
|
||||
label: "Import sample fixture",
|
||||
description: "Temporary fixture used while wiring the importer.",
|
||||
},
|
||||
],
|
||||
defaultSelectedOptionIds: [],
|
||||
minSelected: 0,
|
||||
maxSelected: null,
|
||||
acceptLabel: "Delete selected",
|
||||
rejectLabel: "Request changes",
|
||||
rejectRequiresReason: false,
|
||||
},
|
||||
result: null,
|
||||
...overrides,
|
||||
};
|
||||
}
|
||||
|
||||
export const pendingSuggestedTasksInteraction = createSuggestTasksInteraction({});
|
||||
|
||||
export const acceptedSuggestedTasksInteraction = createSuggestTasksInteraction({
|
||||
@@ -465,6 +525,145 @@ export const failedRequestConfirmationInteraction = createRequestConfirmationInt
|
||||
updatedAt: new Date("2026-04-20T14:42:00.000Z"),
|
||||
});
|
||||
|
||||
export const pendingRequestCheckboxConfirmationInteraction =
|
||||
createRequestCheckboxConfirmationInteraction({});
|
||||
|
||||
export const boundedRequestCheckboxConfirmationInteraction =
|
||||
createRequestCheckboxConfirmationInteraction({
|
||||
id: "interaction-checkbox-bounded",
|
||||
title: "Pick the regions to deploy first",
|
||||
summary: "Choose between two and three regions for the Phase 1 rollout.",
|
||||
payload: {
|
||||
version: 1,
|
||||
prompt: "Which regions should we deploy to initially?",
|
||||
detailsMarkdown: "Select at least 2 and at most 3 regions.",
|
||||
options: [
|
||||
{ id: "us-west", label: "US West (Oregon)", description: "Lowest latency for our primary user base." },
|
||||
{ id: "us-east", label: "US East (Virginia)", description: "Redundancy and east coast coverage." },
|
||||
{ id: "eu-west", label: "EU West (Ireland)", description: "GDPR compliance and European users." },
|
||||
{ id: "ap-southeast", label: "AP Southeast (Singapore)", description: "Asia-Pacific expansion." },
|
||||
],
|
||||
defaultSelectedOptionIds: ["us-west", "us-east"],
|
||||
minSelected: 2,
|
||||
maxSelected: 3,
|
||||
acceptLabel: "Confirm regions",
|
||||
rejectLabel: "Reconsider",
|
||||
rejectRequiresReason: true,
|
||||
rejectReasonLabel: "What should change about the region set?",
|
||||
},
|
||||
});
|
||||
|
||||
export const acceptedRequestCheckboxConfirmationInteraction =
|
||||
createRequestCheckboxConfirmationInteraction({
|
||||
id: "interaction-checkbox-accepted",
|
||||
status: "accepted",
|
||||
resolvedByUserId: issueThreadInteractionFixtureMeta.currentUserId,
|
||||
resolvedAt: new Date("2026-04-20T14:49:00.000Z"),
|
||||
updatedAt: new Date("2026-04-20T14:49:00.000Z"),
|
||||
result: {
|
||||
version: 1,
|
||||
outcome: "accepted",
|
||||
selectedOptionIds: ["draft-march-report", "draft-spec-v1"],
|
||||
},
|
||||
});
|
||||
|
||||
const manyOptionList = Array.from({ length: 100 }, (_, index) => {
|
||||
const number = index + 1;
|
||||
return {
|
||||
id: `record-${number}`,
|
||||
label: `Customer record #${number}`,
|
||||
description: number % 4 === 0
|
||||
? "Flagged as a possible duplicate during the last import."
|
||||
: undefined,
|
||||
};
|
||||
});
|
||||
|
||||
export const manyOptionsRequestCheckboxConfirmationInteraction =
|
||||
createRequestCheckboxConfirmationInteraction({
|
||||
id: "interaction-checkbox-many",
|
||||
title: "Select the customer records to archive",
|
||||
summary: "The cleanup job found 100 stale customer records. Confirm which ones to archive.",
|
||||
payload: {
|
||||
version: 1,
|
||||
prompt: "Check every customer record you want archived.",
|
||||
detailsMarkdown: "The list scrolls. Use Select all / Clear selection to move quickly.",
|
||||
options: manyOptionList,
|
||||
defaultSelectedOptionIds: [],
|
||||
minSelected: 0,
|
||||
maxSelected: null,
|
||||
acceptLabel: "Archive selected",
|
||||
rejectLabel: "Request changes",
|
||||
rejectRequiresReason: false,
|
||||
},
|
||||
});
|
||||
|
||||
export const acceptedManyRequestCheckboxConfirmationInteraction =
|
||||
createRequestCheckboxConfirmationInteraction({
|
||||
id: "interaction-checkbox-many-accepted",
|
||||
status: "accepted",
|
||||
title: "Select the customer records to archive",
|
||||
resolvedByUserId: issueThreadInteractionFixtureMeta.currentUserId,
|
||||
resolvedAt: new Date("2026-04-20T14:52:00.000Z"),
|
||||
updatedAt: new Date("2026-04-20T14:52:00.000Z"),
|
||||
payload: manyOptionsRequestCheckboxConfirmationInteraction.payload,
|
||||
result: {
|
||||
version: 1,
|
||||
outcome: "accepted",
|
||||
selectedOptionIds: manyOptionList.slice(0, 42).map((option) => option.id),
|
||||
},
|
||||
});
|
||||
|
||||
export const rejectedRequestCheckboxConfirmationInteraction =
|
||||
createRequestCheckboxConfirmationInteraction({
|
||||
id: "interaction-checkbox-rejected",
|
||||
status: "rejected",
|
||||
resolvedByUserId: issueThreadInteractionFixtureMeta.currentUserId,
|
||||
resolvedAt: new Date("2026-04-20T14:50:00.000Z"),
|
||||
updatedAt: new Date("2026-04-20T14:50:00.000Z"),
|
||||
result: {
|
||||
version: 1,
|
||||
outcome: "rejected",
|
||||
reason: "Don't delete anything yet — let me confirm with the data owner first.",
|
||||
},
|
||||
});
|
||||
|
||||
export const staleTargetRequestCheckboxConfirmationInteraction =
|
||||
createRequestCheckboxConfirmationInteraction({
|
||||
id: "interaction-checkbox-stale",
|
||||
status: "expired",
|
||||
resolvedByAgentId: "agent-codex",
|
||||
resolvedAt: new Date("2026-04-20T14:51:00.000Z"),
|
||||
updatedAt: new Date("2026-04-20T14:51:00.000Z"),
|
||||
payload: {
|
||||
version: 1,
|
||||
prompt: "Check the draft documents you want me to delete.",
|
||||
acceptLabel: "Delete selected",
|
||||
rejectLabel: "Request changes",
|
||||
options: [
|
||||
{ id: "draft-march-report", label: "Old draft report" },
|
||||
{ id: "draft-spec-v1", label: "Spec v1 (superseded)" },
|
||||
],
|
||||
target: {
|
||||
type: "issue_document",
|
||||
issueId: issueThreadInteractionFixtureMeta.issueId,
|
||||
key: "plan",
|
||||
revisionId: "44444444-4444-4444-8444-444444444444",
|
||||
revisionNumber: 4,
|
||||
},
|
||||
},
|
||||
result: {
|
||||
version: 1,
|
||||
outcome: "stale_target",
|
||||
staleTarget: {
|
||||
type: "issue_document",
|
||||
issueId: issueThreadInteractionFixtureMeta.issueId,
|
||||
key: "plan",
|
||||
revisionId: "11111111-1111-4111-8111-111111111111",
|
||||
revisionNumber: 3,
|
||||
},
|
||||
},
|
||||
});
|
||||
|
||||
export const issueThreadInteractionComments: IssueChatComment[] = [
|
||||
createComment({
|
||||
id: "comment-thread-board",
|
||||
|
||||
Reference in New Issue
Block a user