feat(ui): NUX rework behind enableConferenceRoomChat experimental flag — capsule onboarding, conference-room chat, unified composer (#8000)
## Thinking Path
> - Paperclip is the open source app people use to manage AI agents for
work
> - The first-run experience (onboarding wizard) and the chat surfaces
(conference-room/board chat, task threads, composers) are the product's
front door — they decide whether a new operator understands "hire
agents, give them work, review results" in the first five minutes
> - Today those surfaces feel ticket-y and form-like: the wizard is a
static multi-step form that ends in an anticlimactic "Launch" screen,
the task composer and board chat behave differently from each other, and
agent-feed issue quicklooks misbehave (multiple flyouts open at once,
cards jump on hover)
> - We wanted to iterate toward a conversational, team-centric NUX — but
without risking the workflows of everyone already running Paperclip
> - This PR reworks the NUX behind a new default-OFF
`enableConferenceRoomChat` experimental flag: a capsule-motif onboarding
wizard that builds your team as you answer, a conference-room chat
surface, one shared ChatComposer across surfaces, brand-accurate status
chips, and feed-quicklook fixes — with the pre-existing UI
fork-and-frozen as `*Classic` components that flag-OFF users keep
> - The benefit is a complete, testable modern NUX that anyone can opt
into from Settings → Experimental, with zero default behavior change and
a clean path to either graduate or drop the experiment
## Linked Issues or Issue Description
No pre-existing GitHub issue — feature description per
`feature_request.yml`:
- **Problem / motivation:** Paperclip's onboarding wizard and chat
surfaces grew up as separate ticket-centric forms. New users get a
form-filling experience rather than the feeling of standing up a team;
the board chat and task threads use different composers with different
affordances; the agent feed's issue quicklook can stack multiple
popovers and shifts cards on hover.
- **Proposed solution:** A coherent NUX experiment behind one
experimental flag (`enableConferenceRoomChat`, Settings → Experimental,
default OFF): capsule onboarding wizard with an evolving team capsule,
conference-room chat, unified `ChatComposer`, team-centric copy, brand
status chips, quicklook single-flight fix. Flag-OFF users get the exact
pre-experiment UI via frozen `*Classic` forks, verified by an on/off
parity test matrix.
- **Alternatives considered:** (a) incremental unflagged restyling —
rejected: the changes interlock across surfaces and would drip risk into
every release; (b) a separate app shell / route for the new NUX —
rejected: too much divergence, the flag + classic-fork pattern keeps the
diff reviewable and reversible.
- **Roadmap alignment:** `ROADMAP.md` lists **CEO Chat** ("a
lighter-weight way to talk to leadership agents... should still resolve
to real work objects"). This experiment is groundwork in that direction
(conference-room chat resolves to issues/tasks via the same composer
used in task threads) and does not change the core task-and-comments
model.
Related PRs found in the dedup search (same area, none duplicate this
work — they target the classic wizard, which this PR intentionally
leaves intact and mergeable):
- #5385 — Coach-driven onboarding: conversational entry +
agent-companies package import
- #5378 — Onboarding wizard: reusable adapter picker + probe card
- #6636 — ui(onboarding): friendly error surface + retry for the wizard
- #7005 — fix(onboarding): explicitly await first-task wake
- #2616 — fix: restore workspace directory config in onboarding wizard
## What Changed
- **Experimental flag plumbing** — `enableConferenceRoomChat` in shared
types/validators, server instance-settings service + API, Settings →
Experimental card with explicit enable/disable copy
- **Onboarding wizard** — classic wizard forked and frozen
(`OnboardingWizardClassic`); flag-ON variant is a 5-step capsule wizard
with a persistent evolving `AgentCapsule` (gradient/glow motif),
team-centric reframed copy, and a typing-dots intro (hardened with
fake-timer tests)
- **Conference-room chat** — flag-ON board-chat surface with agent
bubble name/icon headers and copy/vote/timestamp action rows
(`AgentBubbleActionRow`)
- **Unified composer** — shared `ChatComposer` adopted across surfaces;
translucent surface + scroll-mask removal; "Agent mode"/"Plan mode"
relabels; no-assignee confirmation `AlertDialog` (new
`ui/alert-dialog.tsx` primitive); `@task` reference picker +
linkification in mentions
- **Agent feed** — single-flight issue-quicklook store (one popover at a
time), flyouts open to the left, removed hover translate-y jitter
- **Status chips** — brand-accurate task status chips behind the flag
(light/dark, 1px borders per paperclip.ing/brand)
- **Tests** — flag on/off parity matrix across IssueDetail,
NewIssueDialog, Sidebar, wizard, gate components; component tests for
all new pieces
- **Merge with `master`** — one conflict in
`ui/src/components/IssueChatThread.tsx`, resolved by keeping master's
new `AssigneeChip`/`HandoffWakeRow`/`RunStatusBadge` components inside
the flag-gated metadata-row chrome (details in commit `21a5642a`);
post-merge fixes: vitest 4 mock typing in `MarkdownEditor.test.tsx`,
flag hook made safe for provider-less mounts (master's new isolated
component tests)
- **Branch hygiene** — internal design wireframes/mockups stripped
before the PR (they live in the Paperclip issue threads)
- No user-facing documentation changes required: the flag is
intentionally experimental and self-described in the Settings card; no
existing docs reference the affected surfaces
## Verification
- `pnpm run typecheck` — green across the workspace (ui, server, shared,
plugins)
- Full UI suite (`vitest run` in `ui/`, clean worktree at this HEAD):
**1593/1595 passing, 223/224 files** — the 2 remaining failures are in
`src/components/artifacts/ArtifactCard.test.tsx` and **fail identically
on pristine `origin/master`** (pre-existing upstream, unrelated to this
branch)
- Full server suite (`vitest run` in `server/`, same clean worktree):
results in PR checks; flag plumbing covered by instance-settings tests
- Targeted post-merge resolution check: `IssueChatThread`,
`IssueChatThreadSystemNotice`, `IssueDetail`, `Sidebar`,
`ConferenceRoomChatGate`, `OnboardingWizardVariant`, `NewIssueDialog`,
`InstanceExperimentalSettings`, `MarkdownEditor` — 172/172 passing
- Manual walkthrough: flag OFF (default) → onboarding wizard, task
thread, board chat, composer all render the classic UI; flag ON via
Settings → Experimental → capsule wizard, conference-room chat, unified
composer, status chips active
- Screenshots: see below
**Flag on/off screenshots** (committed on this branch under
`screenshots/PR-8000-*`):
| Surface | Flag OFF (classic, default) | Flag ON (experimental) |
| --- | --- | --- |
| Settings → Experimental | 
| 
|
| Task thread | 
| 
|
| Home / nav | 
| 
|
| Conference Room (flag-ON only surface) | — | 
|
Capsule onboarding wizard walkthrough screenshots (flag ON) are attached
to the Paperclip design/implementation threads; the wizard requires a
fresh instance so it is captured via the e2e harness
(`tests/e2e/nux-phase4-screenshots.spec.ts`).
## Risks
- **Large surface, but gated:** all new behavior sits behind
`enableConferenceRoomChat`, default OFF; flag-OFF rendering is locked by
frozen `*Classic` forks plus an on/off parity test suite
- **Classic forks are frozen at the fork point (`e3aada1d`):** master
features added to the live thread component after that point (assignee
handoff chips, run status badge, composer mention coach) render in the
flag-ON path; the flag-OFF task thread keeps the fork-point behavior
until the experiment graduates (forks deleted) or is dropped (forks
restored as canonical). Called out for reviewer attention.
- **Merge-conflict resolution in `IssueChatThread.tsx`** (commit
`21a5642a`) deserves reviewer eyes: master's new handoff/run-status
components were kept; the base toast-style no-assignee flow remains
replaced by the AlertDialog flow introduced on this branch
- Schema/server changes are additive (one optional boolean instance
setting); no migrations of existing data
## Model Used
- Claude (Anthropic) via Claude Code running in the Paperclip agent
harness (agent: ClaudeCoder)
- Branch implemented across multiple agent sessions on Claude Opus-class
models with extended thinking + tool use (file edits, shell, Playwright
screenshots); merge/PR session model ID as reported by the harness:
`claude-fable-5` (Claude Code CLI)
- All code was agent-authored and board-reviewed through Paperclip issue
threads (plans, wireframes, confirmations) before merging
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes (none
required — experimental flag, self-documenting Settings card; noted
above)
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green (run 3 on `8af3041a`: all 16
gates SUCCESS, incl. e2e and all 4 serialized-suite shards)
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
(re-review verdict: Confidence 5/5, “Safe to merge”; all 4 round-1
findings fixed + confirmed resolved; both summary notes addressed in
`8af3041a`)
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
scotttong
@@ -0,0 +1,243 @@
|
||||
// @vitest-environment jsdom
|
||||
|
||||
import { act, useState } from "react";
|
||||
import { createRoot } from "react-dom/client";
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { ChatComposer, type ChatComposerProps } from "./ChatComposer";
|
||||
|
||||
(globalThis as unknown as { IS_REACT_ACT_ENVIRONMENT: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
|
||||
|
||||
/** Stateful harness so the controlled textarea reflects typed input. */
|
||||
function Harness(props: Partial<ChatComposerProps> & { initial?: string }) {
|
||||
const { initial = "", onChange, ...rest } = props;
|
||||
const [value, setValue] = useState(initial);
|
||||
return (
|
||||
<ChatComposer
|
||||
value={value}
|
||||
onChange={(v) => {
|
||||
setValue(v);
|
||||
onChange?.(v);
|
||||
}}
|
||||
onSubmit={rest.onSubmit ?? (() => {})}
|
||||
{...rest}
|
||||
/>
|
||||
);
|
||||
}
|
||||
|
||||
function typeInput(textarea: HTMLTextAreaElement, text: string) {
|
||||
const setter = Object.getOwnPropertyDescriptor(
|
||||
window.HTMLTextAreaElement.prototype,
|
||||
"value",
|
||||
)?.set;
|
||||
setter?.call(textarea, text);
|
||||
textarea.dispatchEvent(new Event("input", { bubbles: true }));
|
||||
}
|
||||
|
||||
describe("ChatComposer", () => {
|
||||
let container: HTMLDivElement;
|
||||
|
||||
beforeEach(() => {
|
||||
container = document.createElement("div");
|
||||
document.body.appendChild(container);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
container.remove();
|
||||
});
|
||||
|
||||
function input() {
|
||||
return container.querySelector<HTMLTextAreaElement>('[data-testid="chat-composer-input"]')!;
|
||||
}
|
||||
function sendButton() {
|
||||
return container.querySelector<HTMLButtonElement>('button[aria-label="Send message"]')!;
|
||||
}
|
||||
function attachButton() {
|
||||
return container.querySelector<HTMLButtonElement>('button[aria-label="Attach files"]');
|
||||
}
|
||||
|
||||
it("renders a bare textarea + send and no attach button without a handler", () => {
|
||||
const root = createRoot(container);
|
||||
act(() => {
|
||||
root.render(<Harness placeholder="Ask anything…" />);
|
||||
});
|
||||
expect(input()).toBeTruthy();
|
||||
expect(input().placeholder).toBe("Ask anything…");
|
||||
expect(attachButton()).toBeNull();
|
||||
// No formatting toolbar — there is exactly one button (send) when bare.
|
||||
expect(container.querySelectorAll("button").length).toBe(1);
|
||||
act(() => root.unmount());
|
||||
});
|
||||
|
||||
it("shows the attach affordance when onAttachFiles is provided", () => {
|
||||
const root = createRoot(container);
|
||||
act(() => {
|
||||
root.render(<Harness onAttachFiles={() => {}} />);
|
||||
});
|
||||
expect(attachButton()).toBeTruthy();
|
||||
act(() => root.unmount());
|
||||
});
|
||||
|
||||
it("disables send while empty and enables it once there is text", () => {
|
||||
const root = createRoot(container);
|
||||
act(() => {
|
||||
root.render(<Harness />);
|
||||
});
|
||||
expect(sendButton().disabled).toBe(true);
|
||||
act(() => {
|
||||
typeInput(input(), "hello");
|
||||
});
|
||||
expect(sendButton().disabled).toBe(false);
|
||||
act(() => root.unmount());
|
||||
});
|
||||
|
||||
it("submits on click", () => {
|
||||
const onSubmit = vi.fn();
|
||||
const root = createRoot(container);
|
||||
act(() => {
|
||||
root.render(<Harness onSubmit={onSubmit} initial="hi" />);
|
||||
});
|
||||
act(() => {
|
||||
sendButton().dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
||||
});
|
||||
expect(onSubmit).toHaveBeenCalledTimes(1);
|
||||
act(() => root.unmount());
|
||||
});
|
||||
|
||||
it('submitKey="enter": plain Enter submits, Shift+Enter does not', () => {
|
||||
const onSubmit = vi.fn();
|
||||
const root = createRoot(container);
|
||||
act(() => {
|
||||
root.render(<Harness onSubmit={onSubmit} initial="hi" submitKey="enter" />);
|
||||
});
|
||||
act(() => {
|
||||
input().dispatchEvent(new KeyboardEvent("keydown", { key: "Enter", bubbles: true, shiftKey: true }));
|
||||
});
|
||||
expect(onSubmit).not.toHaveBeenCalled();
|
||||
act(() => {
|
||||
input().dispatchEvent(new KeyboardEvent("keydown", { key: "Enter", bubbles: true }));
|
||||
});
|
||||
expect(onSubmit).toHaveBeenCalledTimes(1);
|
||||
act(() => root.unmount());
|
||||
});
|
||||
|
||||
it('submitKey="mod-enter": plain Enter does not submit, Cmd/Ctrl+Enter does', () => {
|
||||
const onSubmit = vi.fn();
|
||||
const root = createRoot(container);
|
||||
act(() => {
|
||||
root.render(<Harness onSubmit={onSubmit} initial="hi" submitKey="mod-enter" />);
|
||||
});
|
||||
act(() => {
|
||||
input().dispatchEvent(new KeyboardEvent("keydown", { key: "Enter", bubbles: true }));
|
||||
});
|
||||
expect(onSubmit).not.toHaveBeenCalled();
|
||||
act(() => {
|
||||
input().dispatchEvent(new KeyboardEvent("keydown", { key: "Enter", bubbles: true, metaKey: true }));
|
||||
});
|
||||
expect(onSubmit).toHaveBeenCalledTimes(1);
|
||||
act(() => root.unmount());
|
||||
});
|
||||
|
||||
it("singleLine strips newlines from input", () => {
|
||||
const onChange = vi.fn();
|
||||
const root = createRoot(container);
|
||||
act(() => {
|
||||
root.render(<Harness singleLine onChange={onChange} />);
|
||||
});
|
||||
act(() => {
|
||||
typeInput(input(), "one\ntwo");
|
||||
});
|
||||
expect(onChange).toHaveBeenLastCalledWith("one two");
|
||||
act(() => root.unmount());
|
||||
});
|
||||
|
||||
it("default (multiline) mode soft-wraps and auto-grows instead of clipping (PAP-116)", () => {
|
||||
// The conference room composer adopts this default mode. Text must wrap and
|
||||
// the box grow up to a cap — never clip horizontally or show an idle scrollbar.
|
||||
const root = createRoot(container);
|
||||
act(() => {
|
||||
root.render(<Harness />);
|
||||
});
|
||||
const el = input();
|
||||
expect(el.getAttribute("wrap")).toBe("soft");
|
||||
expect(el.className).toContain("overflow-y-auto");
|
||||
expect(el.className).toContain("max-h-[200px]");
|
||||
expect(el.className).not.toContain("whitespace-nowrap");
|
||||
expect(el.className).not.toContain("overflow-x-auto");
|
||||
act(() => root.unmount());
|
||||
});
|
||||
|
||||
it("singleLine mode clips to one row (opt-in only)", () => {
|
||||
const root = createRoot(container);
|
||||
act(() => {
|
||||
root.render(<Harness singleLine />);
|
||||
});
|
||||
const el = input();
|
||||
expect(el.getAttribute("wrap")).toBe("off");
|
||||
expect(el.className).toContain("whitespace-nowrap");
|
||||
expect(el.className).toContain("max-h-[22px]");
|
||||
act(() => root.unmount());
|
||||
});
|
||||
|
||||
it('tone="planning" is reflected on the container', () => {
|
||||
const root = createRoot(container);
|
||||
act(() => {
|
||||
root.render(<Harness tone="planning" />);
|
||||
});
|
||||
const box = container.querySelector('[data-testid="chat-composer"]');
|
||||
expect(box?.getAttribute("data-tone")).toBe("planning");
|
||||
act(() => root.unmount());
|
||||
});
|
||||
|
||||
it('defaults to the opaque "card" surface', () => {
|
||||
// PAP-131: surface is opt-in — existing adopters keep the bg-card box.
|
||||
const root = createRoot(container);
|
||||
act(() => {
|
||||
root.render(<Harness />);
|
||||
});
|
||||
const box = container.querySelector('[data-testid="chat-composer"]')!;
|
||||
expect(box.getAttribute("data-surface")).toBe("card");
|
||||
expect(box.className).toContain("bg-card");
|
||||
expect(box.className).not.toContain("backdrop-blur");
|
||||
// Rounded corners are shared chrome on both surfaces.
|
||||
expect(box.className).toContain("rounded-xl");
|
||||
act(() => root.unmount());
|
||||
});
|
||||
|
||||
it('surface="translucent" applies the task glass recipe and keeps shared chrome (PAP-131)', () => {
|
||||
const root = createRoot(container);
|
||||
act(() => {
|
||||
root.render(<Harness surface="translucent" />);
|
||||
});
|
||||
const box = container.querySelector('[data-testid="chat-composer"]')!;
|
||||
expect(box.getAttribute("data-surface")).toBe("translucent");
|
||||
// Glass recipe — mirrors the task-comments composer shell.
|
||||
expect(box.className).toContain("bg-background/95");
|
||||
expect(box.className).toContain("supports-[backdrop-filter]:bg-background/85");
|
||||
expect(box.className).toContain("backdrop-blur");
|
||||
expect(box.className).toContain("shadow-[0_-12px_28px_rgba(15,23,42,0.08)]");
|
||||
expect(box.className).toContain("dark:shadow-[0_-12px_28px_rgba(0,0,0,0.28)]");
|
||||
expect(box.className).not.toContain("bg-card");
|
||||
// Shared chrome survives: rounded-xl corners + neutral focus darkening.
|
||||
expect(box.className).toContain("rounded-xl");
|
||||
expect(box.className).toContain("focus-within:border-muted-foreground/40");
|
||||
act(() => root.unmount());
|
||||
});
|
||||
|
||||
it("translucent surface keeps the drag-over attach layering", () => {
|
||||
const root = createRoot(container);
|
||||
act(() => {
|
||||
root.render(<Harness surface="translucent" onAttachFiles={() => {}} />);
|
||||
});
|
||||
const box = container.querySelector<HTMLDivElement>('[data-testid="chat-composer"]')!;
|
||||
act(() => {
|
||||
const dataTransfer = { types: ["Files"], dropEffect: "none" };
|
||||
const evt = new Event("dragenter", { bubbles: true }) as DragEvent & {
|
||||
dataTransfer: typeof dataTransfer;
|
||||
};
|
||||
Object.defineProperty(evt, "dataTransfer", { value: dataTransfer });
|
||||
box.dispatchEvent(evt);
|
||||
});
|
||||
expect(container.querySelector('[data-testid="chat-composer-drop-overlay"]')).toBeTruthy();
|
||||
act(() => root.unmount());
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user