[codex] Move instance settings under company settings (#7680)
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Operators manage both company-scoped configuration and instance-level runtime/admin settings from the board UI > - Instance settings previously lived as their own top-level sidebar area, separate from the company settings context operators already use > - That split made settings navigation feel heavier and made instance configuration less discoverable from the settings tab > - This pull request moves instance settings under company settings while preserving the existing instance settings routes and plugin/admin surfaces > - The benefit is a smaller primary sidebar and a more coherent settings hierarchy for operators ## Linked Issues or Issue Description - Refs #338 - Internal: PAP-10491, PAP-10538 ## What Changed - Moved instance settings navigation under the company settings area. - Added route helpers and sidebar entries for nested instance settings paths. - Updated plugin/admin settings routes to use the company settings instance scope. - Preserved legacy instance-settings bookmarks through compatibility redirects that keep the active company prefix. - Updated focused UI and plugin tests for the new navigation shape. - Stabilized the process-loss retry test that was failing the serialized server shard in CI. - Rebased the branch onto current `paperclipai/paperclip` `master` and pushed the current head. ## Verification - `pnpm exec vitest run ui/src/components/CompanySettingsSidebar.test.tsx ui/src/components/access/CompanySettingsNav.test.tsx ui/src/lib/instance-settings.test.ts ui/src/components/InstanceSidebar.test.tsx ui/src/components/Layout.test.tsx ui/src/components/SidebarAccountMenu.test.tsx ui/src/pages/PluginPage.test.tsx ui/src/plugins/bridge.test.ts packages/shared/src/validators/plugin.test.ts` - `pnpm exec vitest run ui/src/lib/instance-settings.test.ts ui/src/components/CompanySettingsSidebar.test.tsx ui/src/components/access/CompanySettingsNav.test.tsx ui/src/components/Layout.test.tsx ui/src/plugins/bridge.test.ts` - `pnpm exec vitest run server/src/__tests__/heartbeat-process-recovery.test.ts -t "queues exactly one retry when the recorded local pid is dead"` - `pnpm test:run:serialized -- --shard-index 0 --shard-count 4` - GitHub PR checks are green on head `fe7b0955169dcae55cbe10889c1876a70ab0b80c`, including `verify`, `General tests (server)`, all serialized server shards, build, e2e, policy, security checks, and Greptile. - Confirmed the PR diff does not include `pnpm-lock.yaml` or `.github/workflows` changes. ## Risks - Medium UI/navigation risk: instance settings links are intentionally moving under company settings, so stale external bookmarks to legacy paths rely on the compatibility routing in this branch. - Low test-only risk from the CI stabilization commit: it makes the recovery assertion select the actual retry run by `retryOfRunId` instead of whichever non-original run appears first. - No database migrations. - No dependency lockfile or workflow changes. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex coding agent based on GPT-5, with shell/tool execution in a local repository worktree. Exact context window was not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
@@ -1,7 +1,7 @@
|
||||
// @vitest-environment jsdom
|
||||
import * as React from "react";
|
||||
import * as ReactDOM from "react-dom";
|
||||
import { act } from "react";
|
||||
import { flushSync } from "react-dom";
|
||||
import { createRoot } from "react-dom/client";
|
||||
import type { MouseEvent as ReactMouseEvent } from "react";
|
||||
import { renderToStaticMarkup } from "react-dom/server";
|
||||
@@ -46,6 +46,10 @@ afterEach(() => {
|
||||
delete globalThis.__paperclipPluginBridge__;
|
||||
});
|
||||
|
||||
function act(callback: () => void) {
|
||||
flushSync(callback);
|
||||
}
|
||||
|
||||
describe("plugin host navigation", () => {
|
||||
it("resolves plugin page routes into the active company prefix", () => {
|
||||
expect(resolveHostNavigationHref("/wiki", "PAP")).toBe("/PAP/wiki");
|
||||
@@ -57,8 +61,14 @@ describe("plugin host navigation", () => {
|
||||
it("does not double-prefix active company paths or global host paths", () => {
|
||||
expect(resolveHostNavigationHref("/PAP/wiki", "PAP")).toBe("/PAP/wiki");
|
||||
expect(resolveHostNavigationHref("/pap/wiki", "PAP")).toBe("/pap/wiki");
|
||||
});
|
||||
|
||||
it("rewrites legacy instance settings paths into the active company settings scope", () => {
|
||||
expect(resolveHostNavigationHref("/instance/settings/plugins", "PAP")).toBe(
|
||||
"/instance/settings/plugins",
|
||||
"/PAP/company/settings/instance/plugins",
|
||||
);
|
||||
expect(resolveHostNavigationHref("/settings/experimental?x=1#auto", "pap")).toBe(
|
||||
"/PAP/company/settings/instance/experimental?x=1#auto",
|
||||
);
|
||||
});
|
||||
|
||||
|
||||
@@ -38,6 +38,7 @@ import { ApiError } from "@/api/client";
|
||||
import { useToastActions, type ToastInput } from "@/context/ToastContext";
|
||||
import { useSidebar } from "@/context/SidebarContext";
|
||||
import { isGlobalPath, normalizeCompanyPrefix } from "@/lib/company-routes";
|
||||
import { normalizeRememberedInstanceSettingsPath } from "@/lib/instance-settings";
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Bridge error type (mirrors the SDK's PluginBridgeError)
|
||||
@@ -281,6 +282,16 @@ function hasCompanyPrefix(pathname: string, companyPrefix: string): boolean {
|
||||
return firstSegment?.toUpperCase() === normalizeCompanyPrefix(companyPrefix);
|
||||
}
|
||||
|
||||
function isLegacyInstanceSettingsPath(pathname: string): boolean {
|
||||
return (
|
||||
pathname === "/instance" ||
|
||||
pathname === "/instance/settings" ||
|
||||
pathname.startsWith("/instance/settings/") ||
|
||||
pathname === "/settings" ||
|
||||
pathname.startsWith("/settings/")
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* Resolve a plugin-provided Paperclip path to the active company scope.
|
||||
*
|
||||
@@ -295,6 +306,12 @@ export function resolveHostNavigationHref(
|
||||
if (sameOriginPath === null) return to;
|
||||
|
||||
const { pathname, search, hash } = splitPath(sameOriginPath);
|
||||
if (isLegacyInstanceSettingsPath(pathname)) {
|
||||
const canonicalPath = normalizeRememberedInstanceSettingsPath(`${pathname}${search}${hash}`);
|
||||
if (!companyPrefix) return canonicalPath;
|
||||
return `/${normalizeCompanyPrefix(companyPrefix)}${canonicalPath}`;
|
||||
}
|
||||
|
||||
if (!pathname.startsWith("/") || isGlobalPath(pathname) || !companyPrefix) {
|
||||
return sameOriginPath;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user