fix(daytona): valid memory input in env config form + size presets (#8389)

## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work
> - Environments are configured through a JSON-schema-driven form
(`JsonSchemaForm`), and each sandbox provider (here, Daytona) supplies a
manifest describing its fields
> - In the Daytona environment config form, the "memory" field rendered
as a free-text input; on save the value round-tripped to `0`, producing
a server-side "number must be greater than zero" error even when the
user typed a valid number like `2`
> - Rather than patch the free-text input, memory is now a true dropdown
of the sandbox sizes Daytona actually supports, so an invalid value can
no longer be typed or coerced
> - The dropdown leads with a blank "None" row that is selected by
default (meaning "not configured — use Daytona's defaults"); `0` is
never offered because it is not a valid configuration
> - The benefit is that operators pick a valid memory size from a
constrained list, it saves correctly as an integer, and leaving it unset
cleanly omits the field instead of submitting `0`

## Linked Issues or Issue Description

No public GitHub issue exists; describing the bug inline per the bug
report template.

### What happened?

In the Daytona environment configuration form, the memory field is a
free-text input labelled "gigabytes of RAM". Entering a value such as
`2` and saving coerced the value to `0`, and the server rejected the
save with "the number must be greater than zero". There was no way to
enter a valid memory size through the form.

### Expected behavior

Selecting a valid memory size (e.g. `2`) keeps that value and saves
cleanly as an integer. Leaving memory unset is valid and submits no
value (Daytona defaults apply). `0` is never selectable.

### Steps to reproduce

1. Open the environment configuration form for a Daytona sandbox
provider.
2. In the memory field, type `2`.
3. Click Save.
4. Observe the value becomes `0` and the form errors with "the number
must be greater than zero".

## What Changed

- Daytona manifest: `memory` is now an `enum` of the supported sandbox
sizes `[1, 2, 4, 8]` (GiB). It stays optional, so "not configured"
remains valid. `0` is not in the list.
- `JsonSchemaForm` `EnumField`: optional enums now render a leading
blank **None** row that is selected by default when no value is set,
letting the user express "not configured" and clear a previous selection
(Radix `Select` forbids an empty-string item value, so the unset state
maps to a sentinel that translates back to `undefined`).
- `JsonSchemaForm` `EnumField`: when every enum option is numeric, the
selected value is coerced back to a number on change so the payload
keeps the schema's integer type (a stringified `"2"` would otherwise
fail server-side integer validation — this is what fixes the original
bug for the dropdown path).
- Tests: added `EnumField` coverage in `JsonSchemaForm.test.tsx` (blank
row present, no `0`, blank selected by default, numeric coercion, blank
→ unset) and Daytona manifest coverage in the plugin test (memory enum
is `[1,2,4,8]`, excludes `0`, stays optional).

## Verification

- `cd ui && npx vitest run src/components/JsonSchemaForm.test.tsx
src/pages/CompanyEnvironments.test.tsx` → 16/16 passing (14 + 2).
- `vitest run` in `packages/plugins/sandbox-providers/daytona` → 19/19
passing (incl. 3 new manifest tests).
- `cd ui && npx tsc --noEmit` → clean.
- Behavior: the memory field now renders as a dropdown showing **None /
1 / 2 / 4 / 8**, with **None** selected by default. Picking `2` stores
the integer `2`; picking **None** clears the field so it is omitted from
the payload (no `0`, no "must be greater than zero" error).

## Risks

- Low risk. The blank-row + numeric-coercion changes live in
`EnumField`. The blank row is only added for **optional** enums
(required enums are unaffected); numeric coercion only triggers when
every option is numeric, so existing string enums (`egressMode`,
`backend`, `sessionStrategy`) are unchanged. The manifest change is
scoped to the Daytona provider.

## Model Used

Claude (Anthropic), Opus-class model, used via the Paperclip agent
workflow (author + reviewer agents) with tool use and code execution.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above (none found)
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links
- [x] My branch name describes the change and contains no internal
Paperclip ticket id
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
This commit is contained in:
Devin Foley
2026-06-20 17:58:47 -07:00
committed by GitHub
parent 254b01d2af
commit a937b89a47
4 changed files with 339 additions and 51 deletions
+194
View File
@@ -8,6 +8,24 @@ import { JsonSchemaForm, getDefaultValues } from "./JsonSchemaForm";
// eslint-disable-next-line @typescript-eslint/no-explicit-any
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
// Radix Select relies on PointerEvent, pointer capture, and ResizeObserver,
// none of which jsdom implements. Stub them so the dropdown can open in tests.
if (!globalThis.PointerEvent) {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
(globalThis as any).PointerEvent = MouseEvent;
}
if (typeof Element !== "undefined" && !Element.prototype.hasPointerCapture) {
Element.prototype.hasPointerCapture = () => false;
Element.prototype.releasePointerCapture = () => {};
}
class ResizeObserverStub {
observe() {}
unobserve() {}
disconnect() {}
}
// eslint-disable-next-line @typescript-eslint/no-explicit-any
(globalThis as any).ResizeObserver = (globalThis as any).ResizeObserver ?? ResizeObserverStub;
// SecretBindingPicker pulls in CompanyContext + react-query. Stub it so we can
// exercise SecretField in isolation. The stub renders a select with the same
// onChange contract as the real picker.
@@ -358,6 +376,7 @@ describe("JsonSchemaForm secret-ref rendering", () => {
sshPort: { type: "number", default: 22 },
cpu: { type: "number" },
memory: { type: "string" },
size: { type: "string", enum: ["small", "large"] },
reuseLease: { type: "boolean", default: false },
tags: { type: "array", items: { type: "string" } },
},
@@ -373,6 +392,42 @@ describe("JsonSchemaForm secret-ref rendering", () => {
expect("apiKey" in defaults).toBe(false);
expect("cpu" in defaults).toBe(false);
expect("memory" in defaults).toBe(false);
expect("size" in defaults).toBe(false);
});
it("renders datalist suggestions for numeric fields when examples are present", async () => {
const root = createRoot(container);
await act(async () => {
root.render(
<JsonSchemaForm
schema={{
type: "object",
properties: {
memory: {
type: "integer",
examples: [1, 2, 4, 8],
},
},
}}
values={{}}
onChange={() => {}}
/>,
);
});
const input = container.querySelector<HTMLInputElement>('input[type="number"]');
// The "/" in the field path is sanitized so the id is a valid CSS/HTML identifier.
expect(input?.getAttribute("list")).toBe("-memory-suggestions");
expect(container.querySelector("datalist")?.getAttribute("id")).toBe("-memory-suggestions");
const options = Array.from(container.querySelectorAll("datalist option")).map((option) =>
option.getAttribute("value"),
);
expect(options).toEqual(["1", "2", "4", "8"]);
await act(async () => {
root.unmount();
});
});
it("keeps the password fallback for short raw values", async () => {
@@ -407,3 +462,142 @@ describe("JsonSchemaForm secret-ref rendering", () => {
});
});
});
describe("JsonSchemaForm enum rendering", () => {
let container: HTMLDivElement;
const numericEnumSchema = {
type: "object" as const,
properties: {
memory: {
type: "integer" as const,
enum: [1, 2, 4, 8],
},
},
};
beforeEach(() => {
container = document.createElement("div");
document.body.appendChild(container);
});
afterEach(() => {
container.remove();
document.body.innerHTML = "";
vi.clearAllMocks();
});
async function openSelect() {
const trigger = container.querySelector<HTMLElement>('[role="combobox"]');
expect(trigger).not.toBeNull();
await act(async () => {
trigger!.dispatchEvent(
new PointerEvent("pointerdown", { bubbles: true, button: 0 }),
);
trigger!.dispatchEvent(new MouseEvent("click", { bubbles: true }));
});
}
function optionByLabel(label: string): Element | undefined {
return Array.from(document.querySelectorAll('[role="option"]')).find(
(option) => option.textContent?.trim() === label,
);
}
it("renders an optional numeric enum as a dropdown with a blank row and no 0", async () => {
const root = createRoot(container);
await act(async () => {
root.render(
<JsonSchemaForm schema={numericEnumSchema} values={{}} onChange={() => {}} />,
);
});
await openSelect();
const labels = Array.from(document.querySelectorAll('[role="option"]')).map(
(option) => option.textContent?.trim(),
);
// A blank "None" row is offered so the user can express "not configured".
expect(labels).toContain("None");
expect(labels).toEqual(expect.arrayContaining(["1", "2", "4", "8"]));
// 0 is not a valid Daytona memory size and must never appear.
expect(labels).not.toContain("0");
await act(async () => {
root.unmount();
});
});
it("selects the blank row by default when no value is configured", async () => {
const root = createRoot(container);
await act(async () => {
root.render(
<JsonSchemaForm schema={numericEnumSchema} values={{}} onChange={() => {}} />,
);
});
await openSelect();
const noneOption = optionByLabel("None");
expect(noneOption).toBeTruthy();
// Radix marks the active selection with aria-selected / data-state checked.
expect(noneOption?.getAttribute("aria-selected")).toBe("true");
await act(async () => {
root.unmount();
});
});
it("coerces the selected numeric enum value back to a number", async () => {
const onChange = vi.fn();
const root = createRoot(container);
await act(async () => {
root.render(
<JsonSchemaForm schema={numericEnumSchema} values={{}} onChange={onChange} />,
);
});
await openSelect();
await act(async () => {
optionByLabel("2")!.dispatchEvent(new MouseEvent("click", { bubbles: true }));
});
// Number, not the string "2", so server-side integer validation passes.
expect(onChange).toHaveBeenCalledWith({ memory: 2 });
await act(async () => {
root.unmount();
});
});
it("maps the blank row back to an unset (undefined) value", async () => {
const onChange = vi.fn();
const root = createRoot(container);
await act(async () => {
root.render(
<JsonSchemaForm
schema={numericEnumSchema}
values={{ memory: 2 }}
onChange={onChange}
/>,
);
});
await openSelect();
await act(async () => {
optionByLabel("None")!.dispatchEvent(new MouseEvent("click", { bubbles: true }));
});
expect(onChange).toHaveBeenCalledWith({ memory: undefined });
await act(async () => {
root.unmount();
});
});
});
+113 -46
View File
@@ -47,6 +47,7 @@ export interface JsonSchemaNode {
description?: string;
default?: unknown;
enum?: unknown[];
examples?: unknown[];
const?: unknown;
format?: string;
@@ -155,7 +156,7 @@ export function getDefaultForSchema(schema: JsonSchemaNode): unknown {
case "boolean":
return false;
case "enum":
return schema.enum?.[0] ?? "";
return undefined;
case "array":
return [];
case "object": {
@@ -438,6 +439,13 @@ const BooleanField = React.memo(({
BooleanField.displayName = "BooleanField";
/**
* Sentinel value for the "not configured" row of an optional enum select.
* Radix `Select` forbids an empty-string item value, so we map the unset state
* onto this sentinel and translate it back to `undefined` on change.
*/
const ENUM_UNSET_VALUE = "__paperclip_unset__";
/**
* Specialized field for enum (select) values.
*/
@@ -459,32 +467,63 @@ const EnumField = React.memo(({
description?: string;
error?: string;
options: unknown[];
}) => (
<FieldWrapper
label={label}
description={description}
required={isRequired}
error={error}
disabled={disabled}
>
<Select
value={String(value ?? "")}
onValueChange={onChange}
}) => {
// Optional enums get a leading blank row so the user can express "not
// configured"; it is also the selected row when no value is set.
const showUnsetOption = !isRequired;
// When every option is numeric, coerce the selected string back to a number
// so the payload keeps the schema's integer/number type — a stringified "2"
// would otherwise fail server-side integer validation.
const numericOptions =
options.length > 0 && options.every((option) => typeof option === "number");
const isUnset = value === undefined || value === null || value === "";
const selectValue = isUnset
? showUnsetOption
? ENUM_UNSET_VALUE
: ""
: String(value);
const handleChange = (next: string) => {
if (next === ENUM_UNSET_VALUE) {
onChange(undefined);
return;
}
onChange(numericOptions ? Number(next) : next);
};
return (
<FieldWrapper
label={label}
description={description}
required={isRequired}
error={error}
disabled={disabled}
>
<SelectTrigger className="w-full">
<SelectValue placeholder="Select an option" />
</SelectTrigger>
<SelectContent>
{options.map((option) => (
<SelectItem key={String(option)} value={String(option)}>
{String(option)}
</SelectItem>
))}
</SelectContent>
</Select>
</FieldWrapper>
));
<Select
value={selectValue}
onValueChange={handleChange}
disabled={disabled}
>
<SelectTrigger className="w-full">
<SelectValue placeholder="Select an option" />
</SelectTrigger>
<SelectContent>
{showUnsetOption && (
<SelectItem value={ENUM_UNSET_VALUE} textValue="None">
<span className="text-muted-foreground">None</span>
</SelectItem>
)}
{options.map((option) => (
<SelectItem key={String(option)} value={String(option)}>
{String(option)}
</SelectItem>
))}
</SelectContent>
</Select>
</FieldWrapper>
);
});
EnumField.displayName = "EnumField";
@@ -689,6 +728,7 @@ SecretField.displayName = "SecretField";
* Specialized field for numeric (number/integer) values.
*/
const NumberField = React.memo(({
id,
value,
onChange,
disabled,
@@ -698,7 +738,11 @@ const NumberField = React.memo(({
error,
defaultValue,
type,
minimum,
maximum,
suggestions,
}: {
id: string;
value: unknown;
onChange: (val: unknown) => void;
disabled: boolean;
@@ -708,28 +752,47 @@ const NumberField = React.memo(({
error?: string;
defaultValue?: unknown;
type: "number" | "integer";
}) => (
<FieldWrapper
label={label}
description={description}
required={isRequired}
error={error}
disabled={disabled}
>
<Input
type="number"
step={type === "integer" ? "1" : "any"}
value={value !== undefined ? String(value) : ""}
onChange={(e) => {
const val = e.target.value;
onChange(val === "" ? undefined : Number(val));
}}
placeholder={String(defaultValue ?? "")}
minimum?: number;
maximum?: number;
suggestions?: unknown[];
}) => {
const hasSuggestions = Array.isArray(suggestions) && suggestions.length > 0;
// Sanitize the path-based id so it is a valid CSS/HTML identifier (paths can contain "/").
const listId = hasSuggestions ? `${id.replace(/[^a-zA-Z0-9_-]/g, "-")}-suggestions` : undefined;
return (
<FieldWrapper
label={label}
description={description}
required={isRequired}
error={error}
disabled={disabled}
aria-invalid={!!error}
/>
</FieldWrapper>
));
>
<Input
type="number"
step={type === "integer" ? "1" : "any"}
min={minimum}
max={maximum}
list={listId}
value={value !== undefined ? String(value) : ""}
onChange={(e) => {
const val = e.target.value;
const trimmed = val.trim();
onChange(trimmed === "" ? undefined : Number(trimmed));
}}
placeholder={String(defaultValue ?? "")}
disabled={disabled}
aria-invalid={!!error}
/>
{listId ? (
<datalist id={listId}>
{suggestions!.map((suggestion) => (
<option key={String(suggestion)} value={String(suggestion)} />
))}
</datalist>
) : null}
</FieldWrapper>
);
});
NumberField.displayName = "NumberField";
@@ -1044,6 +1107,7 @@ const FormField = React.memo(({
case "integer":
return (
<NumberField
id={path}
value={value}
onChange={onChange}
disabled={isReadOnly}
@@ -1053,6 +1117,9 @@ const FormField = React.memo(({
error={error}
defaultValue={propSchema.default}
type={type as "number" | "integer"}
minimum={typeof propSchema.minimum === "number" ? propSchema.minimum : undefined}
maximum={typeof propSchema.maximum === "number" ? propSchema.maximum : undefined}
suggestions={Array.isArray(propSchema.examples) ? propSchema.examples : undefined}
/>
);