[codex] Filter document artifacts from issue outputs (#7608)
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Issue detail pages promote certain artifact work products into the dedicated Output surface while also listing raw attachments below > - Document-like artifacts such as plan markdown can currently be promoted like binary outputs, which makes the same work product story look like both an output and a document/attachment > - The output surface should stay focused on inspectable generated media, archives, PDFs, WebAssembly, SVG/images, and true binary deliverables while document-like artifacts remain in the document or attachment flow > - This pull request filters document-like artifact metadata out of the Output section and avoids duplicating the attachments that back promoted outputs > - The benefit is a cleaner issue detail page where plans and markdown reports do not appear as binary outputs, while real output files still get highlighted ## Linked Issues or Issue Description Fixes #7609 Refs PAP-10354 Refs PAP-10369 ## What Changed - Added output MIME-type normalization and eligibility checks for issue artifact work products. - Filtered markdown, text, JSON, XML, CSV, YAML, source-like files, and generic binary artifacts with document-like filenames out of promoted issue outputs. - Kept video, image including SVG, PDF, ZIP, WebAssembly, and true binary artifacts eligible for the Output section. - Hid attachments that back promoted outputs while leaving filtered document-like artifact attachments visible. - Preserved the full image attachment set for chat image gallery lookup even when promoted image outputs are hidden from the attachment list. - Added focused tests for output eligibility, glyph labeling, output promotion, attachment filtering, gallery image preservation, and the output section render behavior. ## Verification - `pnpm vitest run ui/src/lib/issue-output.test.ts ui/src/pages/IssueDetail.test.tsx ui/src/components/issue-output/IssueOutputSection.test.tsx` - GitHub PR checks are green on `7d1b80f9702f20ab86cc502bffce599b13f1b088`. - Greptile confidence score is 5/5 and both Greptile review threads are resolved. ## Risks - Low risk. The change only affects UI classification of Paperclip artifact work products. The main behavioral risk is an uncommon text-like generated artifact no longer appearing in the Output section; it remains available through the normal attachment/document surfaces. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used OpenAI GPT-5 Codex via Paperclip CodexCoder, with repository tool use and local command execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Dotta
@@ -5,6 +5,8 @@ import {
|
||||
formatDuration,
|
||||
getIssueOutputs,
|
||||
getOutputFileGlyph,
|
||||
getPromotedOutputAttachmentIds,
|
||||
isOutputEligibleContentType,
|
||||
} from "./issue-output";
|
||||
|
||||
function makeWorkProduct(overrides: Partial<IssueWorkProduct> & { id: string }): IssueWorkProduct {
|
||||
@@ -50,6 +52,14 @@ function videoMetadata(attachmentId = uuid()) {
|
||||
};
|
||||
}
|
||||
|
||||
function artifactMetadata(contentType: string, originalFilename: string, attachmentId = uuid()) {
|
||||
return {
|
||||
...videoMetadata(attachmentId),
|
||||
contentType,
|
||||
originalFilename,
|
||||
};
|
||||
}
|
||||
|
||||
describe("formatBytes", () => {
|
||||
it("renders bytes below 1KB as whole bytes", () => {
|
||||
expect(formatBytes(0)).toBe("0 B");
|
||||
@@ -83,6 +93,7 @@ describe("formatDuration", () => {
|
||||
describe("getOutputFileGlyph", () => {
|
||||
it("maps known mime types to tone + label", () => {
|
||||
expect(getOutputFileGlyph("video/mp4")).toEqual({ label: "MP4", tone: "video" });
|
||||
expect(getOutputFileGlyph("video/mp4; charset=binary")).toEqual({ label: "MP4", tone: "video" });
|
||||
expect(getOutputFileGlyph("video/quicktime")).toEqual({ label: "MOV", tone: "video" });
|
||||
expect(getOutputFileGlyph("application/pdf")).toEqual({ label: "PDF", tone: "pdf" });
|
||||
expect(getOutputFileGlyph("application/zip")).toEqual({ label: "ZIP", tone: "zip" });
|
||||
@@ -93,6 +104,39 @@ describe("getOutputFileGlyph", () => {
|
||||
expect(getOutputFileGlyph("application/octet-stream")).toEqual({ label: "BIN", tone: "bin" });
|
||||
expect(getOutputFileGlyph(undefined)).toEqual({ label: "BIN", tone: "bin" });
|
||||
});
|
||||
|
||||
it("labels document-like fallbacks defensively", () => {
|
||||
expect(getOutputFileGlyph("text/plain")).toEqual({ label: "TXT", tone: "bin" });
|
||||
expect(getOutputFileGlyph("text/markdown")).toEqual({ label: "MD", tone: "bin" });
|
||||
expect(getOutputFileGlyph("application/json; charset=utf-8")).toEqual({ label: "JSON", tone: "bin" });
|
||||
expect(getOutputFileGlyph("application/wasm")).toEqual({ label: "WASM", tone: "bin" });
|
||||
});
|
||||
});
|
||||
|
||||
describe("isOutputEligibleContentType", () => {
|
||||
it("keeps media, pdf, zip, and true generic binary outputs eligible", () => {
|
||||
expect(isOutputEligibleContentType("video/mp4; charset=binary")).toBe(true);
|
||||
expect(isOutputEligibleContentType("image/png")).toBe(true);
|
||||
expect(isOutputEligibleContentType("image/svg+xml")).toBe(true);
|
||||
expect(isOutputEligibleContentType("application/pdf")).toBe(true);
|
||||
expect(isOutputEligibleContentType("application/vnd.example.bundle+zip")).toBe(true);
|
||||
expect(isOutputEligibleContentType("application/wasm")).toBe(true);
|
||||
expect(isOutputEligibleContentType("application/octet-stream")).toBe(true);
|
||||
expect(isOutputEligibleContentType("application/octet-stream", "build.bin")).toBe(true);
|
||||
});
|
||||
|
||||
it("filters document-like and source formats out of outputs", () => {
|
||||
expect(isOutputEligibleContentType("text/markdown")).toBe(false);
|
||||
expect(isOutputEligibleContentType("text/plain")).toBe(false);
|
||||
expect(isOutputEligibleContentType("application/json")).toBe(false);
|
||||
expect(isOutputEligibleContentType("application/vnd.api+json")).toBe(false);
|
||||
expect(isOutputEligibleContentType("text/html")).toBe(false);
|
||||
expect(isOutputEligibleContentType("application/xml")).toBe(false);
|
||||
expect(isOutputEligibleContentType("text/csv")).toBe(false);
|
||||
expect(isOutputEligibleContentType("application/x-yaml")).toBe(false);
|
||||
expect(isOutputEligibleContentType("application/octet-stream", "report.md")).toBe(false);
|
||||
expect(isOutputEligibleContentType("application/octet-stream", "notes.txt")).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe("getIssueOutputs", () => {
|
||||
@@ -118,6 +162,30 @@ describe("getIssueOutputs", () => {
|
||||
expect(result.rest).toEqual([]);
|
||||
});
|
||||
|
||||
it("ignores markdown and text artifact metadata instead of promoting them to outputs", () => {
|
||||
const result = getIssueOutputs([
|
||||
makeWorkProduct({ id: "markdown", metadata: artifactMetadata("text/markdown", "report.md") }),
|
||||
makeWorkProduct({ id: "text", metadata: artifactMetadata("text/plain", "notes.txt") }),
|
||||
makeWorkProduct({ id: "json", metadata: artifactMetadata("application/json", "summary.json") }),
|
||||
makeWorkProduct({ id: "generic-markdown", metadata: artifactMetadata("application/octet-stream", "legacy-report.md") }),
|
||||
]);
|
||||
expect(result.count).toBe(0);
|
||||
expect(result.primary).toBeNull();
|
||||
});
|
||||
|
||||
it("keeps video, image, pdf, zip, and binary artifact metadata as outputs", () => {
|
||||
const result = getIssueOutputs([
|
||||
makeWorkProduct({ id: "video", metadata: artifactMetadata("video/mp4", "demo.mp4") }),
|
||||
makeWorkProduct({ id: "image", metadata: artifactMetadata("image/png", "screenshot.png") }),
|
||||
makeWorkProduct({ id: "svg", metadata: artifactMetadata("image/svg+xml", "diagram.svg") }),
|
||||
makeWorkProduct({ id: "pdf", metadata: artifactMetadata("application/pdf", "brief.pdf") }),
|
||||
makeWorkProduct({ id: "zip", metadata: artifactMetadata("application/zip; charset=binary", "bundle.zip") }),
|
||||
makeWorkProduct({ id: "wasm", metadata: artifactMetadata("application/wasm", "module.wasm") }),
|
||||
makeWorkProduct({ id: "binary", metadata: artifactMetadata("application/octet-stream", "build.bin") }),
|
||||
]);
|
||||
expect(result.items.map((item) => item.id)).toEqual(["video", "image", "svg", "pdf", "zip", "wasm", "binary"]);
|
||||
});
|
||||
|
||||
it("orders the explicit primary first, then most recent", () => {
|
||||
const result = getIssueOutputs([
|
||||
makeWorkProduct({
|
||||
@@ -153,3 +221,17 @@ describe("getIssueOutputs", () => {
|
||||
expect(result.primary?.metadata).toBeNull();
|
||||
});
|
||||
});
|
||||
|
||||
describe("getPromotedOutputAttachmentIds", () => {
|
||||
it("returns backing attachment ids only for work products promoted to outputs", () => {
|
||||
const videoAttachmentId = uuid();
|
||||
const markdownAttachmentId = uuid();
|
||||
const ids = getPromotedOutputAttachmentIds([
|
||||
makeWorkProduct({ id: "video", metadata: videoMetadata(videoAttachmentId) }),
|
||||
makeWorkProduct({ id: "markdown", metadata: artifactMetadata("text/markdown", "report.md", markdownAttachmentId) }),
|
||||
makeWorkProduct({ id: "broken", metadata: { attachmentId: "bad" } as Record<string, unknown> }),
|
||||
]);
|
||||
|
||||
expect(Array.from(ids)).toEqual([videoAttachmentId]);
|
||||
});
|
||||
});
|
||||
|
||||
+140
-7
@@ -58,30 +58,151 @@ export function formatDuration(seconds: number): string {
|
||||
return `${mins}:${pad(secs)}`;
|
||||
}
|
||||
|
||||
const GENERIC_BINARY_CONTENT_TYPES = new Set([
|
||||
"application/octet-stream",
|
||||
"binary/octet-stream",
|
||||
"application/x-binary",
|
||||
]);
|
||||
|
||||
const BINARY_OUTPUT_APPLICATION_TYPES = new Set([
|
||||
"application/wasm",
|
||||
]);
|
||||
|
||||
const ZIP_CONTENT_TYPES = new Set([
|
||||
"application/zip",
|
||||
"application/x-zip",
|
||||
"application/x-zip-compressed",
|
||||
]);
|
||||
|
||||
const MARKDOWN_CONTENT_TYPES = new Set([
|
||||
"text/markdown",
|
||||
"text/x-markdown",
|
||||
"application/markdown",
|
||||
"application/x-markdown",
|
||||
]);
|
||||
|
||||
const DOCUMENT_LIKE_APPLICATION_TYPES = new Set([
|
||||
"application/csv",
|
||||
"application/ecmascript",
|
||||
"application/graphql",
|
||||
"application/html",
|
||||
"application/javascript",
|
||||
"application/json",
|
||||
"application/ld+json",
|
||||
"application/sql",
|
||||
"application/toml",
|
||||
"application/x-httpd-php",
|
||||
"application/x-javascript",
|
||||
"application/x-python",
|
||||
"application/x-sh",
|
||||
"application/x-yaml",
|
||||
"application/xhtml+xml",
|
||||
"application/xml",
|
||||
"application/yaml",
|
||||
]);
|
||||
|
||||
const DOCUMENT_LIKE_FILENAME_EXTENSIONS = [
|
||||
".csv",
|
||||
".css",
|
||||
".graphql",
|
||||
".htm",
|
||||
".html",
|
||||
".js",
|
||||
".json",
|
||||
".jsx",
|
||||
".log",
|
||||
".markdown",
|
||||
".md",
|
||||
".mdx",
|
||||
".php",
|
||||
".py",
|
||||
".sh",
|
||||
".sql",
|
||||
".toml",
|
||||
".ts",
|
||||
".tsx",
|
||||
".txt",
|
||||
".xml",
|
||||
".yaml",
|
||||
".yml",
|
||||
];
|
||||
|
||||
export function normalizeOutputContentType(contentType: string | null | undefined): string {
|
||||
return (contentType ?? "").toLowerCase().split(";")[0]?.trim() ?? "";
|
||||
}
|
||||
|
||||
function hasDocumentLikeFilename(originalFilename: string | null | undefined): boolean {
|
||||
const filename = (originalFilename ?? "").trim().toLowerCase();
|
||||
if (!filename) return false;
|
||||
return DOCUMENT_LIKE_FILENAME_EXTENSIONS.some((extension) => filename.endsWith(extension));
|
||||
}
|
||||
|
||||
function isZipContentType(contentType: string): boolean {
|
||||
return ZIP_CONTENT_TYPES.has(contentType) || contentType.endsWith("+zip");
|
||||
}
|
||||
|
||||
function isDocumentLikeOutputContentType(contentType: string): boolean {
|
||||
if (!contentType) return false;
|
||||
if (contentType.startsWith("text/")) return true;
|
||||
if (MARKDOWN_CONTENT_TYPES.has(contentType)) return true;
|
||||
if (DOCUMENT_LIKE_APPLICATION_TYPES.has(contentType)) return true;
|
||||
if (contentType.startsWith("application/") && (contentType.endsWith("+json") || contentType.endsWith("+xml"))) return true;
|
||||
return false;
|
||||
}
|
||||
|
||||
export function isOutputEligibleContentType(
|
||||
contentType: string | null | undefined,
|
||||
originalFilename?: string | null | undefined,
|
||||
): boolean {
|
||||
const type = normalizeOutputContentType(contentType);
|
||||
if (!type) return false;
|
||||
if (isDocumentLikeOutputContentType(type)) return false;
|
||||
if (GENERIC_BINARY_CONTENT_TYPES.has(type) && hasDocumentLikeFilename(originalFilename)) return false;
|
||||
return (
|
||||
type.startsWith("video/") ||
|
||||
type.startsWith("image/") ||
|
||||
type === "application/pdf" ||
|
||||
BINARY_OUTPUT_APPLICATION_TYPES.has(type) ||
|
||||
isZipContentType(type) ||
|
||||
GENERIC_BINARY_CONTENT_TYPES.has(type)
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* Map a MIME type to a short label + tone for the 32×32 file-type tile.
|
||||
*/
|
||||
export function getOutputFileGlyph(contentType: string | null | undefined): OutputFileGlyph {
|
||||
const type = (contentType ?? "").toLowerCase();
|
||||
const type = normalizeOutputContentType(contentType);
|
||||
if (type.startsWith("video/")) {
|
||||
const subtype = type.slice("video/".length);
|
||||
if (subtype === "quicktime") return { label: "MOV", tone: "video" };
|
||||
return { label: (subtype || "vid").toUpperCase().slice(0, 4), tone: "video" };
|
||||
}
|
||||
if (type === "application/pdf") return { label: "PDF", tone: "pdf" };
|
||||
if (type === "application/zip" || type === "application/x-zip-compressed" || type.endsWith("+zip")) {
|
||||
if (isZipContentType(type)) {
|
||||
return { label: "ZIP", tone: "zip" };
|
||||
}
|
||||
if (type.startsWith("image/")) return { label: "IMG", tone: "image" };
|
||||
if (MARKDOWN_CONTENT_TYPES.has(type)) return { label: "MD", tone: "bin" };
|
||||
if (type === "text/plain") return { label: "TXT", tone: "bin" };
|
||||
if (type === "text/csv" || type === "application/csv") return { label: "CSV", tone: "bin" };
|
||||
if (type === "text/html" || type === "application/html" || type === "application/xhtml+xml") {
|
||||
return { label: "HTML", tone: "bin" };
|
||||
}
|
||||
if (type === "application/json" || type.endsWith("+json")) return { label: "JSON", tone: "bin" };
|
||||
if (type === "application/xml" || type === "text/xml" || type.endsWith("+xml")) {
|
||||
return { label: "XML", tone: "bin" };
|
||||
}
|
||||
if (type === "application/wasm") return { label: "WASM", tone: "bin" };
|
||||
return { label: "BIN", tone: "bin" };
|
||||
}
|
||||
|
||||
export function isVideoContentType(contentType: string | null | undefined): boolean {
|
||||
return (contentType ?? "").toLowerCase().startsWith("video/");
|
||||
return normalizeOutputContentType(contentType).startsWith("video/");
|
||||
}
|
||||
|
||||
export function isImageContentType(contentType: string | null | undefined): boolean {
|
||||
return (contentType ?? "").toLowerCase().startsWith("image/");
|
||||
return normalizeOutputContentType(contentType).startsWith("image/");
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -125,9 +246,12 @@ function toTime(value: string | Date): number {
|
||||
export function getIssueOutputs(workProducts: IssueWorkProduct[] | null | undefined): IssueOutputs {
|
||||
const artifacts = (workProducts ?? []).filter((wp) => wp.type === "artifact" && wp.provider === "paperclip");
|
||||
|
||||
const items: IssueOutputItem[] = artifacts.map((wp) => {
|
||||
const items: IssueOutputItem[] = artifacts.flatMap((wp) => {
|
||||
const parsed = attachmentArtifactWorkProductMetadataSchema.safeParse(wp.metadata);
|
||||
return {
|
||||
if (parsed.success && !isOutputEligibleContentType(parsed.data.contentType, parsed.data.originalFilename)) {
|
||||
return [];
|
||||
}
|
||||
return [{
|
||||
id: wp.id,
|
||||
title: wp.title,
|
||||
status: typeof wp.status === "string" ? wp.status : "active",
|
||||
@@ -136,7 +260,7 @@ export function getIssueOutputs(workProducts: IssueWorkProduct[] | null | undefi
|
||||
metadata: parsed.success ? parsed.data : null,
|
||||
degraded: !parsed.success,
|
||||
workProduct: wp,
|
||||
};
|
||||
}];
|
||||
});
|
||||
|
||||
items.sort((a, b) => {
|
||||
@@ -156,3 +280,12 @@ export function getIssueOutputs(workProducts: IssueWorkProduct[] | null | undefi
|
||||
export function outputFilename(item: IssueOutputItem): string {
|
||||
return item.metadata?.originalFilename || item.title || "output";
|
||||
}
|
||||
|
||||
export function getPromotedOutputAttachmentIds(workProducts: IssueWorkProduct[] | null | undefined): Set<string> {
|
||||
return new Set(
|
||||
getIssueOutputs(workProducts).items.flatMap((item) => {
|
||||
const attachmentId = item.metadata?.attachmentId;
|
||||
return attachmentId ? [attachmentId] : [];
|
||||
}),
|
||||
);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user