Add low-trust review containment (#7530)
## Thinking Path > - Paperclip is a control plane for AI-agent companies, so execution policy and trust boundaries are part of the product's safety contract. > - Low-trust review work needs narrower authority than normal same-company agents because hostile PRs, comments, attachments, and generated output can carry prompt-injection payloads. > - The current V1 shape gives trusted workers broad company context, which is useful for normal execution but too permissive for a reviewer assigned to hostile content. > - This branch adds a `low_trust_review` preset, source-trust tagging, route-level containment, and quarantine handling so low-trust output does not automatically flow into higher-trust wake context. > - The branch has been rebased onto current `origin/master`, and the low-trust migration was renumbered to `0097_low_trust_source_trust.sql` to avoid collisions with existing `0091` through `0096` migrations. > - Greptile feedback was addressed by tightening low-trust detection, preserving project-level trust policy checks, fixing issue-kind promotion lookup, removing duplicate post-lease isolation assertion, documenting fail-closed source-trust behavior, bounding ancestry checks, enforcing runtime issue context for CEOs, awaiting accepted-plan monitor authorization, and making low-trust issue source-trust tagging atomic. > - The benefit is a first production slice of deny-by-default review containment with regression coverage for the main control-plane pivot surfaces. Fixes #7531. ## What Changed - Added shared trust-policy types and validators, plus database/source-trust fields for issues, comments, documents, and work products. - Implemented server enforcement for low-trust issue scope, agent self-view redaction, secret/plugin/runtime denial paths, promotion checks, and quarantined continuation/wake context. - Added focused low-trust regression tests for resolver behavior, source trust, route authorization, heartbeat preflight ordering, runtime containment, and quarantine redaction. - Added board UI affordances for selecting/reviewing the low-trust preset and surfacing source-trust badges in relevant issue views. - Added `doc/LOW-TRUST-PRESETS.md`, updated `doc/SPEC-implementation.md`, and committed the low-trust review contract plan under `doc/plans/`. - Rebasing note: the original `0097_low_trust_source_trust.sql` migration was renamed to `0097_low_trust_source_trust.sql`; the SQL uses `ADD COLUMN IF NOT EXISTS` so users who already applied the old-numbered migration are not broken by the renumbered migration. ## Verification - Rebased branch onto current `origin/master` and force-pushed with lease to `origin/PAP-10211-low-trust-agent` at head `2719f31e3`. - Confirmed the PR diff does not include `pnpm-lock.yaml` or `.github/workflows` changes. - Resolved upstream UI/comment conflicts by preserving deleted-comment tombstone behavior and low-trust source-trust badges/metadata. - Renumbered the low-trust source-trust migration to `0097_low_trust_source_trust.sql`; the SQL uses `ADD COLUMN IF NOT EXISTS` so users who already applied an old-numbered copy are not broken. - `pnpm exec vitest run ui/src/lib/issue-chat-messages.test.ts server/src/__tests__/heartbeat-workspace-session.test.ts` - `pnpm exec vitest run server/src/__tests__/source-trust.test.ts server/src/__tests__/workspace-runtime-service-authz.test.ts ui/src/lib/trust-policy-ui.test.ts ui/src/components/TrustPresetSection.test.tsx` - `pnpm run typecheck:build-gaps` - `git diff --check` - GitHub checks pass on head `2719f31e3`: build, typecheck/release registry, general tests, serialized server suites, e2e, canary, verify, policy/review, Socket, and Snyk. - Greptile Review passes with Confidence Score 5/5 and zero unresolved Greptile review threads. - No design screenshots/images were added because the task explicitly says not to add them unless they are specifically part of the work. ## Risks - Medium risk: this touches shared trust-policy contracts, server authorization paths, heartbeat context generation, migration metadata, and UI preset controls. - Low-trust containment is intentionally deny-by-default; legitimate future review workflows may need explicit allowlisted exceptions. - Plugin/runtime/security surfaces are broad, so regression tests cover the current known routes but future integrations must route through the same containment layer. - The PR is ready for review; GitHub checks are green and Greptile is 5/5. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent, tool-enabled shell and GitHub CLI workflow. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] UI changes are covered by focused tests; no screenshots were added per task instruction not to add design images unless specifically required - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
@@ -7,10 +7,13 @@ import {
|
||||
} from "../constants.js";
|
||||
import { agentAdapterTypeSchema } from "../adapter-type.js";
|
||||
import { envConfigSchema } from "./secret.js";
|
||||
import { trustAuthorizationPolicySchema, trustPresetSchema } from "./trust-policy.js";
|
||||
|
||||
export const agentPermissionsSchema = z.object({
|
||||
canCreateAgents: z.boolean().optional().default(false),
|
||||
});
|
||||
trustPreset: trustPresetSchema.optional(),
|
||||
authorizationPolicy: trustAuthorizationPolicySchema.optional(),
|
||||
}).catchall(z.unknown());
|
||||
|
||||
export const agentInstructionsBundleModeSchema = z.enum(["managed", "external"]);
|
||||
|
||||
@@ -158,6 +161,8 @@ export type TestAdapterEnvironment = z.infer<typeof testAdapterEnvironmentSchema
|
||||
export const updateAgentPermissionsSchema = z.object({
|
||||
canCreateAgents: z.boolean(),
|
||||
canAssignTasks: z.boolean(),
|
||||
trustPreset: trustPresetSchema.optional(),
|
||||
authorizationPolicy: trustAuthorizationPolicySchema.optional(),
|
||||
});
|
||||
|
||||
export type UpdateAgentPermissions = z.infer<typeof updateAgentPermissionsSchema>;
|
||||
|
||||
@@ -146,6 +146,19 @@ export {
|
||||
type CompanyPortabilityImport,
|
||||
} from "./company-portability.js";
|
||||
|
||||
export {
|
||||
trustPresetSchema,
|
||||
lowTrustBoundarySchema,
|
||||
lowTrustReviewPresetPolicySchema,
|
||||
trustAuthorizationPolicySchema,
|
||||
sourceTrustArtifactKindSchema,
|
||||
sourceTrustMetadataSchema,
|
||||
type TrustPresetInput,
|
||||
type LowTrustBoundaryInput,
|
||||
type TrustAuthorizationPolicyInput,
|
||||
type SourceTrustMetadataInput,
|
||||
} from "./trust-policy.js";
|
||||
|
||||
export {
|
||||
createAgentSchema,
|
||||
createAgentHireSchema,
|
||||
|
||||
@@ -27,6 +27,7 @@ import {
|
||||
MODEL_PROFILE_KEYS,
|
||||
} from "../constants.js";
|
||||
import { multilineTextSchema } from "./text.js";
|
||||
import { lowTrustReviewPresetPolicySchema, trustAuthorizationPolicySchema } from "./trust-policy.js";
|
||||
|
||||
export const issueBlockedInboxStateSchema = z.enum([
|
||||
"needs_attention",
|
||||
@@ -197,6 +198,8 @@ export const issueExecutionPolicySchema = z.object({
|
||||
commentRequired: z.boolean().optional().default(true),
|
||||
stages: z.array(issueExecutionStageSchema).default([]),
|
||||
monitor: issueExecutionMonitorPolicySchema.optional().nullable(),
|
||||
reviewPreset: lowTrustReviewPresetPolicySchema.optional(),
|
||||
authorizationPolicy: trustAuthorizationPolicySchema.optional(),
|
||||
});
|
||||
|
||||
export const issueExecutionMonitorStateSchema = z.object({
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
import { z } from "zod";
|
||||
import { PROJECT_STATUSES } from "../constants.js";
|
||||
import { envConfigSchema } from "./secret.js";
|
||||
import { trustAuthorizationPolicySchema } from "./trust-policy.js";
|
||||
|
||||
const executionWorkspaceStrategySchema = z
|
||||
.object({
|
||||
@@ -26,6 +27,7 @@ export const projectExecutionWorkspacePolicySchema = z
|
||||
pullRequestPolicy: z.record(z.string(), z.unknown()).optional().nullable(),
|
||||
runtimePolicy: z.record(z.string(), z.unknown()).optional().nullable(),
|
||||
cleanupPolicy: z.record(z.string(), z.unknown()).optional().nullable(),
|
||||
authorizationPolicy: trustAuthorizationPolicySchema.optional().nullable(),
|
||||
})
|
||||
.strict();
|
||||
|
||||
|
||||
@@ -0,0 +1,61 @@
|
||||
import { z } from "zod";
|
||||
import {
|
||||
LOW_TRUST_REVIEW_PRESET,
|
||||
LOW_TRUST_REVIEW_PRESET_VERSION,
|
||||
LOW_TRUST_REVIEW_RAW_OUTPUT_DISPOSITION,
|
||||
TRUST_PRESETS,
|
||||
} from "../trust-policy.js";
|
||||
|
||||
export const trustPresetSchema = z.enum(TRUST_PRESETS);
|
||||
|
||||
export const lowTrustOutputPromotionTargetSchema = z.object({
|
||||
type: z.literal("issue"),
|
||||
issueId: z.string().uuid(),
|
||||
}).strict();
|
||||
|
||||
export const lowTrustBoundarySchema = z.object({
|
||||
mode: z.literal(LOW_TRUST_REVIEW_PRESET),
|
||||
companyId: z.string().uuid().optional(),
|
||||
projectIds: z.array(z.string().uuid()).optional(),
|
||||
rootIssueId: z.string().uuid().optional(),
|
||||
issueIds: z.array(z.string().uuid()).optional(),
|
||||
allowedAgentIds: z.array(z.string().uuid()).optional(),
|
||||
allowedSecretBindingIds: z.array(z.string().uuid()).optional(),
|
||||
allowedToolClasses: z.array(z.string().trim().min(1)).optional(),
|
||||
outputPromotionTarget: lowTrustOutputPromotionTargetSchema.optional(),
|
||||
}).strict();
|
||||
|
||||
export const lowTrustReviewPresetPolicySchema = z.object({
|
||||
id: z.literal(LOW_TRUST_REVIEW_PRESET),
|
||||
version: z.literal(LOW_TRUST_REVIEW_PRESET_VERSION),
|
||||
rawOutputDisposition: z.literal(LOW_TRUST_REVIEW_RAW_OUTPUT_DISPOSITION),
|
||||
}).strict();
|
||||
|
||||
export const trustAuthorizationPolicySchema = z.object({
|
||||
trustPreset: trustPresetSchema.optional(),
|
||||
reviewPreset: lowTrustReviewPresetPolicySchema.optional(),
|
||||
trustBoundary: lowTrustBoundarySchema.optional(),
|
||||
}).catchall(z.unknown());
|
||||
|
||||
export const sourceTrustArtifactKindSchema = z.enum(["issue", "comment", "document", "work_product"]);
|
||||
|
||||
export const sourceTrustMetadataSchema = z.object({
|
||||
preset: trustPresetSchema,
|
||||
disposition: z.enum(["quarantined", "promoted"]),
|
||||
sourceIssueId: z.string().uuid().nullable().optional(),
|
||||
sourceRunId: z.string().uuid().nullable().optional(),
|
||||
sourceAgentId: z.string().uuid().nullable().optional(),
|
||||
promotedFrom: z.object({
|
||||
artifactKind: sourceTrustArtifactKindSchema,
|
||||
artifactId: z.string().uuid(),
|
||||
issueId: z.string().uuid().nullable().optional(),
|
||||
}).strict().nullable().optional(),
|
||||
promotedByActorType: z.enum(["agent", "user", "system"]).nullable().optional(),
|
||||
promotedByActorId: z.string().trim().min(1).nullable().optional(),
|
||||
promotedAt: z.string().datetime({ offset: true }).nullable().optional(),
|
||||
}).strict();
|
||||
|
||||
export type TrustPresetInput = z.infer<typeof trustPresetSchema>;
|
||||
export type LowTrustBoundaryInput = z.infer<typeof lowTrustBoundarySchema>;
|
||||
export type TrustAuthorizationPolicyInput = z.infer<typeof trustAuthorizationPolicySchema>;
|
||||
export type SourceTrustMetadataInput = z.infer<typeof sourceTrustMetadataSchema>;
|
||||
Reference in New Issue
Block a user