139cdebe51
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Human operators sign in through the main auth page and through invite acceptance flows. > - Those forms need to be understandable to assistive technology and password managers. > - The login fields did not consistently expose stable names, ids, autocomplete hints, required state, and error relationships. > - That made it easier for password managers such as 1Password to miss the username/password pairing and harder for screen readers to associate validation errors. > - This pull request tightens the auth and invite form metadata while keeping the visible flow unchanged. > - The benefit is a smoother login and invite-acceptance experience without changing server-side auth behavior. ## Linked Issues or Issue Description No matching GitHub issue found after searching `login accessibility 1Password username password` in `paperclipai/paperclip` issues and PRs. ## What happened? Login and invite auth fields were missing password-manager and accessibility metadata, including stable field identifiers, autocomplete hints, required semantics, and error-region relationships. That made it easier for password managers such as 1Password to miss the username/password pairing and harder for screen readers to associate validation errors. ## Expected behavior Auth fields should be discoverable as username/password fields, distinguish sign-in and sign-up password autocomplete behavior, and expose validation errors through an alert region referenced by invalid inputs. ## Steps to reproduce 1. Open the main `/auth` form or an invite auth form. 2. Inspect the email, password, and sign-up name field attributes. 3. Trigger a validation/auth error and inspect whether invalid inputs reference the displayed error text. ## Paperclip version or commit Prior to this PR on `master`. ## Deployment mode Board UI, all deployments using these forms. ## What Changed - Added stable `id`, `name`, `required`, `aria-required`, `aria-invalid`, `aria-describedby`, and autocomplete metadata to the main auth form. - Added invite auth field metadata so invite sign-up uses `new-password`, invite sign-in uses `current-password`, and the email field is recognized as `username`. - Added alert regions for auth and invite auth errors so invalid fields can reference the displayed error text. - Added focused Vitest coverage for the main auth form and invite auth flow metadata/error behavior. ## Verification - `pnpm exec vitest run ui/src/pages/Auth.test.tsx ui/src/pages/InviteLanding.test.tsx` passes: 2 files, 16 tests. - `pnpm build` passes locally. - PR CI is green on head `3531d1900`, including Build, Canary Dry Run, Typecheck + Release Registry, e2e, general/serialized test shards, policy, commitperclip review, security checks, and aggregate `verify`. - Greptile Review is passing on head `3531d1900`; the P2 alert/live-region review thread was fixed and resolved. - Rebasing onto `public-gh/master` completed cleanly; current base ref is `e50666e4c`. - Confirmed the branch diff does not include `pnpm-lock.yaml`, `.github/workflows`, migrations, or design/image assets. - No screenshots attached: this is a form metadata/accessibility change, and the task specifically asked not to add design screenshots or images unless they are part of the work. ## Risks Low risk. The change is limited to UI form attributes and error wiring. Main risk is password-manager/browser interpretation differences, covered by asserting the emitted DOM metadata rather than a specific vendor integration. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used OpenAI Codex, GPT-5-based coding model with repository tool use and shell execution. Exact hosted model ID/context window are not exposed in this runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
202 lines
7.5 KiB
TypeScript
202 lines
7.5 KiB
TypeScript
import { useEffect, useMemo, useState } from "react";
|
|
import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
|
|
import { useNavigate, useSearchParams } from "@/lib/router";
|
|
import { authApi } from "../api/auth";
|
|
import { queryKeys } from "../lib/queryKeys";
|
|
import { getRememberedInvitePath } from "../lib/invite-memory";
|
|
import { Button } from "@/components/ui/button";
|
|
import { AsciiArtAnimation } from "@/components/AsciiArtAnimation";
|
|
import { Sparkles } from "lucide-react";
|
|
|
|
type AuthMode = "sign_in" | "sign_up";
|
|
|
|
export function AuthPage() {
|
|
const queryClient = useQueryClient();
|
|
const navigate = useNavigate();
|
|
const [searchParams] = useSearchParams();
|
|
const [mode, setMode] = useState<AuthMode>("sign_in");
|
|
const [name, setName] = useState("");
|
|
const [email, setEmail] = useState("");
|
|
const [password, setPassword] = useState("");
|
|
const [error, setError] = useState<string | null>(null);
|
|
const errorId = "auth-error";
|
|
|
|
const nextPath = useMemo(
|
|
() => searchParams.get("next") || getRememberedInvitePath() || "/",
|
|
[searchParams],
|
|
);
|
|
const { data: session, isLoading: isSessionLoading } = useQuery({
|
|
queryKey: queryKeys.auth.session,
|
|
queryFn: () => authApi.getSession(),
|
|
retry: false,
|
|
});
|
|
|
|
useEffect(() => {
|
|
if (session) {
|
|
navigate(nextPath, { replace: true });
|
|
}
|
|
}, [session, navigate, nextPath]);
|
|
|
|
const mutation = useMutation({
|
|
mutationFn: async () => {
|
|
if (mode === "sign_in") {
|
|
await authApi.signInEmail({ email: email.trim(), password });
|
|
return;
|
|
}
|
|
await authApi.signUpEmail({
|
|
name: name.trim(),
|
|
email: email.trim(),
|
|
password,
|
|
});
|
|
},
|
|
onSuccess: async () => {
|
|
setError(null);
|
|
await queryClient.invalidateQueries({ queryKey: queryKeys.auth.session });
|
|
await queryClient.invalidateQueries({ queryKey: queryKeys.companies.all });
|
|
navigate(nextPath, { replace: true });
|
|
},
|
|
onError: (err) => {
|
|
setError(err instanceof Error ? err.message : "Authentication failed");
|
|
},
|
|
});
|
|
|
|
const canSubmit =
|
|
email.trim().length > 0 &&
|
|
password.trim().length > 0 &&
|
|
(mode === "sign_in" || (name.trim().length > 0 && password.trim().length >= 8));
|
|
|
|
if (isSessionLoading) {
|
|
return (
|
|
<div className="fixed inset-0 flex items-center justify-center">
|
|
<p className="text-sm text-muted-foreground">Loading…</p>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<div className="fixed inset-0 flex bg-background">
|
|
{/* Left half — form */}
|
|
<div className="w-full md:w-1/2 flex flex-col overflow-y-auto">
|
|
<div className="w-full max-w-md mx-auto my-auto px-8 py-12">
|
|
<div className="flex items-center gap-2 mb-8">
|
|
<Sparkles className="h-4 w-4 text-muted-foreground" />
|
|
<span className="text-sm font-medium">Paperclip</span>
|
|
</div>
|
|
|
|
<h1 className="text-xl font-semibold">
|
|
{mode === "sign_in" ? "Sign in to Paperclip" : "Create your Paperclip account"}
|
|
</h1>
|
|
<p className="mt-1 text-sm text-muted-foreground">
|
|
{mode === "sign_in"
|
|
? "Use your email and password to access this instance."
|
|
: "Create an account for this instance. Email confirmation is not required in v1."}
|
|
</p>
|
|
|
|
<form
|
|
className="mt-6 space-y-4"
|
|
method="post"
|
|
action={mode === "sign_up" ? "/api/auth/sign-up/email" : "/api/auth/sign-in/email"}
|
|
onSubmit={(event) => {
|
|
event.preventDefault();
|
|
if (mutation.isPending) return;
|
|
if (!canSubmit) {
|
|
setError("Please fill in all required fields.");
|
|
return;
|
|
}
|
|
mutation.mutate();
|
|
}}
|
|
>
|
|
{mode === "sign_up" && (
|
|
<div>
|
|
<label htmlFor="name" className="text-xs text-muted-foreground mb-1 block">Name</label>
|
|
<input
|
|
id="name"
|
|
name="name"
|
|
className="w-full rounded-md border border-border bg-transparent px-3 py-2 text-sm outline-none focus:ring-1 focus:ring-ring placeholder:text-muted-foreground/50"
|
|
value={name}
|
|
onChange={(event) => setName(event.target.value)}
|
|
autoComplete="name"
|
|
required
|
|
aria-required="true"
|
|
aria-invalid={error ? true : undefined}
|
|
aria-describedby={error ? errorId : undefined}
|
|
autoFocus
|
|
/>
|
|
</div>
|
|
)}
|
|
<div>
|
|
<label htmlFor="email" className="text-xs text-muted-foreground mb-1 block">Email</label>
|
|
<input
|
|
id="email"
|
|
name="email"
|
|
className="w-full rounded-md border border-border bg-transparent px-3 py-2 text-sm outline-none focus:ring-1 focus:ring-ring placeholder:text-muted-foreground/50"
|
|
type="email"
|
|
value={email}
|
|
onChange={(event) => setEmail(event.target.value)}
|
|
autoComplete="username"
|
|
required
|
|
aria-required="true"
|
|
aria-invalid={error ? true : undefined}
|
|
aria-describedby={error ? errorId : undefined}
|
|
autoFocus={mode === "sign_in"}
|
|
/>
|
|
</div>
|
|
<div>
|
|
<label htmlFor="password" className="text-xs text-muted-foreground mb-1 block">Password</label>
|
|
<input
|
|
id="password"
|
|
name="password"
|
|
className="w-full rounded-md border border-border bg-transparent px-3 py-2 text-sm outline-none focus:ring-1 focus:ring-ring placeholder:text-muted-foreground/50"
|
|
type="password"
|
|
value={password}
|
|
onChange={(event) => setPassword(event.target.value)}
|
|
autoComplete={mode === "sign_in" ? "current-password" : "new-password"}
|
|
required
|
|
aria-required="true"
|
|
aria-invalid={error ? true : undefined}
|
|
aria-describedby={error ? errorId : undefined}
|
|
/>
|
|
</div>
|
|
{error && (
|
|
<p id={errorId} role="alert" className="text-xs text-destructive">
|
|
{error}
|
|
</p>
|
|
)}
|
|
<Button
|
|
type="submit"
|
|
disabled={mutation.isPending}
|
|
aria-disabled={!canSubmit || mutation.isPending}
|
|
className={`w-full ${!canSubmit && !mutation.isPending ? "opacity-50" : ""}`}
|
|
>
|
|
{mutation.isPending
|
|
? "Working…"
|
|
: mode === "sign_in"
|
|
? "Sign In"
|
|
: "Create Account"}
|
|
</Button>
|
|
</form>
|
|
|
|
<div className="mt-5 text-sm text-muted-foreground">
|
|
{mode === "sign_in" ? "Need an account?" : "Already have an account?"}{" "}
|
|
<button
|
|
type="button"
|
|
className="font-medium text-foreground underline underline-offset-2"
|
|
onClick={() => {
|
|
setError(null);
|
|
setMode(mode === "sign_in" ? "sign_up" : "sign_in");
|
|
}}
|
|
>
|
|
{mode === "sign_in" ? "Create one" : "Sign in"}
|
|
</button>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
{/* Right half — ASCII art animation (hidden on mobile) */}
|
|
<div className="hidden md:block w-1/2 overflow-hidden">
|
|
<AsciiArtAnimation />
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|