2e74d32871
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The board UI is the operator surface where users create, assign, monitor, and review work items. > - The product language is moving toward "tasks" for user-facing work items while the internal API and database still use "issues". > - PR #7543 bundled this copy migration with broader information-architecture work, which made the branch too large for Greptile review. > - This pull request peels the Issue-to-Task copy migration into a smaller, independently reviewable change. > - The benefit is clearer user-facing terminology, less agent confusion via the Paperclip skill note, and a smaller PR that Greptile can review. ## Linked Issues or Issue Description Refs #7645 Refs #7543 Refs PAP-10430 This PR was split out of #7543 so the Issue-to-Task copy migration can be reviewed separately and the remaining IA PR can fall under Greptile's file limit. ## What Changed - Preserves Scott Tong's original `PAP-57` copy-only commit, with author and co-author credit intact, to rename user-facing "Issues" copy to "Tasks" across the UI while keeping routes/API/internal symbols as `issue`. - Updates onboarding and release-smoke browser selectors from `Create & Open Issue` to `Create & Open Task`. - Adds a terminology note to `skills/paperclip/SKILL.md` clarifying that task and issue refer to the same Paperclip work item. - Resolves the only cherry-pick conflict by keeping current search artifacts support and changing visible search copy to "tasks". ## Verification - `pnpm --filter @paperclipai/ui build` passed. - `NODE_ENV=test pnpm exec vitest run ui/src/components/IssuesList.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/NewIssueDialog.test.tsx ui/src/pages/IssueDetail.test.tsx` passed: 4 files, 66 tests. - `git diff --check origin/master...HEAD` passed. - Diff is 80 files, below Greptile's 100-file limit. - Before/after UI copy examples: "Issues" -> "Tasks", "New Issue" -> "New Task", "Create & Open Issue" -> "Create & Open Task". ## Risks - Medium copy-risk: this intentionally changes user-facing terminology broadly while keeping internal issue identifiers and routes unchanged. - Some docs and APIs still say `issue`; the skill note clarifies this so agents do not treat task and issue as separate entities. - Browser-level visual validation is expected from CI because this local container is missing usable browser dependencies. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used Scott Tong authored the original `PAP-57` copy migration, assisted by Claude Opus 4.8 and Paperclip agents per the preserved commit metadata. Codex / GPT-5-class coding agent with shell, GitHub CLI, and repository access performed the PR split, conflict resolution, skill note, and verification. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: scotttong <scott.tong@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
142 lines
4.7 KiB
TypeScript
142 lines
4.7 KiB
TypeScript
import { expect, test, type Page } from "@playwright/test";
|
|
|
|
const ADMIN_EMAIL =
|
|
process.env.PAPERCLIP_RELEASE_SMOKE_EMAIL ??
|
|
process.env.SMOKE_ADMIN_EMAIL ??
|
|
"smoke-admin@paperclip.local";
|
|
const ADMIN_PASSWORD =
|
|
process.env.PAPERCLIP_RELEASE_SMOKE_PASSWORD ??
|
|
process.env.SMOKE_ADMIN_PASSWORD ??
|
|
"paperclip-smoke-password";
|
|
|
|
const COMPANY_NAME = `Release-Smoke-${Date.now()}`;
|
|
const AGENT_NAME = "CEO";
|
|
const TASK_TITLE = "Release smoke task";
|
|
|
|
async function signIn(page: Page) {
|
|
await page.goto("/");
|
|
await expect(page).toHaveURL(/\/auth/);
|
|
|
|
await page.locator('input[type="email"]').fill(ADMIN_EMAIL);
|
|
await page.locator('input[type="password"]').fill(ADMIN_PASSWORD);
|
|
await page.getByRole("button", { name: "Sign In" }).click();
|
|
|
|
await expect(page).not.toHaveURL(/\/auth/, { timeout: 20_000 });
|
|
}
|
|
|
|
async function openOnboarding(page: Page) {
|
|
const wizardHeading = page.locator("h3", { hasText: "Name your company" });
|
|
const startButton = page.getByRole("button", { name: "Start Onboarding" });
|
|
|
|
await expect(wizardHeading.or(startButton)).toBeVisible({ timeout: 20_000 });
|
|
|
|
if (await startButton.isVisible()) {
|
|
await startButton.click();
|
|
}
|
|
|
|
await expect(wizardHeading).toBeVisible({ timeout: 10_000 });
|
|
}
|
|
|
|
test.describe("Docker authenticated onboarding smoke", () => {
|
|
test("logs in, completes onboarding, and triggers the first CEO run", async ({
|
|
page,
|
|
}) => {
|
|
await signIn(page);
|
|
await openOnboarding(page);
|
|
|
|
await page.locator('input[placeholder="Acme Corp"]').fill(COMPANY_NAME);
|
|
await page.getByRole("button", { name: "Next" }).click();
|
|
|
|
await expect(
|
|
page.locator("h3", { hasText: "Create your first agent" })
|
|
).toBeVisible({ timeout: 10_000 });
|
|
|
|
await expect(page.locator('input[placeholder="CEO"]')).toHaveValue(AGENT_NAME);
|
|
await page.getByRole("button", { name: "Next" }).click();
|
|
|
|
await expect(
|
|
page.locator("h3", { hasText: "Give it something to do" })
|
|
).toBeVisible({ timeout: 10_000 });
|
|
await page
|
|
.locator('input[placeholder="e.g. Research competitor pricing"]')
|
|
.fill(TASK_TITLE);
|
|
await page.getByRole("button", { name: "Next" }).click();
|
|
|
|
await expect(
|
|
page.locator("h3", { hasText: "Ready to launch" })
|
|
).toBeVisible({ timeout: 10_000 });
|
|
await expect(page.getByText(COMPANY_NAME)).toBeVisible();
|
|
await expect(page.getByText(AGENT_NAME)).toBeVisible();
|
|
await expect(page.getByText(TASK_TITLE)).toBeVisible();
|
|
|
|
await page.getByRole("button", { name: "Create & Open Task" }).click();
|
|
await expect(page).toHaveURL(/\/issues\//, { timeout: 10_000 });
|
|
|
|
const baseUrl = new URL(page.url()).origin;
|
|
|
|
const companiesRes = await page.request.get(`${baseUrl}/api/companies`);
|
|
expect(companiesRes.ok()).toBe(true);
|
|
const companies = (await companiesRes.json()) as Array<{ id: string; name: string }>;
|
|
const company = companies.find((entry) => entry.name === COMPANY_NAME);
|
|
expect(company).toBeTruthy();
|
|
|
|
const agentsRes = await page.request.get(
|
|
`${baseUrl}/api/companies/${company!.id}/agents`
|
|
);
|
|
expect(agentsRes.ok()).toBe(true);
|
|
const agents = (await agentsRes.json()) as Array<{
|
|
id: string;
|
|
name: string;
|
|
role: string;
|
|
adapterType: string;
|
|
}>;
|
|
const ceoAgent = agents.find((entry) => entry.name === AGENT_NAME);
|
|
expect(ceoAgent).toBeTruthy();
|
|
expect(ceoAgent!.role).toBe("ceo");
|
|
expect(ceoAgent!.adapterType).not.toBe("process");
|
|
|
|
const issuesRes = await page.request.get(
|
|
`${baseUrl}/api/companies/${company!.id}/issues`
|
|
);
|
|
expect(issuesRes.ok()).toBe(true);
|
|
const issues = (await issuesRes.json()) as Array<{
|
|
id: string;
|
|
title: string;
|
|
assigneeAgentId: string | null;
|
|
}>;
|
|
const issue = issues.find((entry) => entry.title === TASK_TITLE);
|
|
expect(issue).toBeTruthy();
|
|
expect(issue!.assigneeAgentId).toBe(ceoAgent!.id);
|
|
|
|
await expect.poll(
|
|
async () => {
|
|
const runsRes = await page.request.get(
|
|
`${baseUrl}/api/companies/${company!.id}/heartbeat-runs?agentId=${ceoAgent!.id}`
|
|
);
|
|
expect(runsRes.ok()).toBe(true);
|
|
const runs = (await runsRes.json()) as Array<{
|
|
agentId: string;
|
|
invocationSource: string;
|
|
status: string;
|
|
}>;
|
|
const latestRun = runs.find((entry) => entry.agentId === ceoAgent!.id);
|
|
return latestRun
|
|
? {
|
|
invocationSource: latestRun.invocationSource,
|
|
status: latestRun.status,
|
|
}
|
|
: null;
|
|
},
|
|
{
|
|
timeout: 30_000,
|
|
intervals: [1_000, 2_000, 5_000],
|
|
}
|
|
).toEqual(
|
|
expect.objectContaining({
|
|
invocationSource: "assignment",
|
|
status: expect.stringMatching(/^(queued|running|succeeded|failed)$/),
|
|
})
|
|
);
|
|
});
|
|
});
|