2e74d32871
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The board UI is the operator surface where users create, assign, monitor, and review work items. > - The product language is moving toward "tasks" for user-facing work items while the internal API and database still use "issues". > - PR #7543 bundled this copy migration with broader information-architecture work, which made the branch too large for Greptile review. > - This pull request peels the Issue-to-Task copy migration into a smaller, independently reviewable change. > - The benefit is clearer user-facing terminology, less agent confusion via the Paperclip skill note, and a smaller PR that Greptile can review. ## Linked Issues or Issue Description Refs #7645 Refs #7543 Refs PAP-10430 This PR was split out of #7543 so the Issue-to-Task copy migration can be reviewed separately and the remaining IA PR can fall under Greptile's file limit. ## What Changed - Preserves Scott Tong's original `PAP-57` copy-only commit, with author and co-author credit intact, to rename user-facing "Issues" copy to "Tasks" across the UI while keeping routes/API/internal symbols as `issue`. - Updates onboarding and release-smoke browser selectors from `Create & Open Issue` to `Create & Open Task`. - Adds a terminology note to `skills/paperclip/SKILL.md` clarifying that task and issue refer to the same Paperclip work item. - Resolves the only cherry-pick conflict by keeping current search artifacts support and changing visible search copy to "tasks". ## Verification - `pnpm --filter @paperclipai/ui build` passed. - `NODE_ENV=test pnpm exec vitest run ui/src/components/IssuesList.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/NewIssueDialog.test.tsx ui/src/pages/IssueDetail.test.tsx` passed: 4 files, 66 tests. - `git diff --check origin/master...HEAD` passed. - Diff is 80 files, below Greptile's 100-file limit. - Before/after UI copy examples: "Issues" -> "Tasks", "New Issue" -> "New Task", "Create & Open Issue" -> "Create & Open Task". ## Risks - Medium copy-risk: this intentionally changes user-facing terminology broadly while keeping internal issue identifiers and routes unchanged. - Some docs and APIs still say `issue`; the skill note clarifies this so agents do not treat task and issue as separate entities. - Browser-level visual validation is expected from CI because this local container is missing usable browser dependencies. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used Scott Tong authored the original `PAP-57` copy migration, assisted by Claude Opus 4.8 and Paperclip agents per the preserved commit metadata. Codex / GPT-5-class coding agent with shell, GitHub CLI, and repository access performed the PR split, conflict resolution, skill note, and verification. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: scotttong <scott.tong@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
126 lines
4.1 KiB
TypeScript
126 lines
4.1 KiB
TypeScript
import { useMemo } from "react";
|
|
import { NavLink, useLocation } from "@/lib/router";
|
|
import {
|
|
House,
|
|
CircleDot,
|
|
SquarePen,
|
|
Users,
|
|
Inbox,
|
|
} from "lucide-react";
|
|
import { useCompany } from "../context/CompanyContext";
|
|
import { useDialogActions } from "../context/DialogContext";
|
|
import { SIDEBAR_SCROLL_RESET_STATE } from "../lib/navigation-scroll";
|
|
import { cn } from "../lib/utils";
|
|
import { useInboxBadge } from "../hooks/useInboxBadge";
|
|
|
|
interface MobileBottomNavProps {
|
|
visible: boolean;
|
|
}
|
|
|
|
interface MobileNavLinkItem {
|
|
type: "link";
|
|
to: string;
|
|
label: string;
|
|
icon: typeof House;
|
|
badge?: number;
|
|
}
|
|
|
|
interface MobileNavActionItem {
|
|
type: "action";
|
|
label: string;
|
|
icon: typeof SquarePen;
|
|
onClick: () => void;
|
|
}
|
|
|
|
type MobileNavItem = MobileNavLinkItem | MobileNavActionItem;
|
|
|
|
export function MobileBottomNav({ visible }: MobileBottomNavProps) {
|
|
const location = useLocation();
|
|
const { selectedCompanyId } = useCompany();
|
|
const { openNewIssue } = useDialogActions();
|
|
const inboxBadge = useInboxBadge(selectedCompanyId);
|
|
|
|
const items = useMemo<MobileNavItem[]>(
|
|
() => [
|
|
{ type: "link", to: "/dashboard", label: "Home", icon: House },
|
|
{ type: "link", to: "/issues", label: "Tasks", icon: CircleDot },
|
|
{ type: "action", label: "Create", icon: SquarePen, onClick: () => openNewIssue() },
|
|
{ type: "link", to: "/agents/all", label: "Agents", icon: Users },
|
|
{
|
|
type: "link",
|
|
to: "/inbox",
|
|
label: "Inbox",
|
|
icon: Inbox,
|
|
badge: inboxBadge.inbox,
|
|
},
|
|
],
|
|
[openNewIssue, inboxBadge.inbox],
|
|
);
|
|
|
|
return (
|
|
<nav
|
|
className={cn(
|
|
"fixed bottom-0 left-0 right-0 z-30 border-t border-border bg-background/95 backdrop-blur supports-[backdrop-filter]:bg-background/85 transition-transform duration-200 ease-out md:hidden pb-[env(safe-area-inset-bottom)]",
|
|
visible ? "translate-y-0" : "translate-y-full",
|
|
)}
|
|
aria-label="Mobile navigation"
|
|
>
|
|
<div className="grid h-16 grid-cols-5 px-1">
|
|
{items.map((item) => {
|
|
if (item.type === "action") {
|
|
const Icon = item.icon;
|
|
const active = /\/issues\/new(?:\/|$)/.test(location.pathname);
|
|
return (
|
|
<button
|
|
key={item.label}
|
|
type="button"
|
|
onClick={item.onClick}
|
|
className={cn(
|
|
"relative flex min-w-0 flex-col items-center justify-center gap-1 rounded-md text-[10px] font-medium transition-colors",
|
|
active
|
|
? "text-foreground"
|
|
: "text-muted-foreground hover:text-foreground",
|
|
)}
|
|
>
|
|
<Icon className="h-[18px] w-[18px]" />
|
|
<span className="truncate">{item.label}</span>
|
|
</button>
|
|
);
|
|
}
|
|
|
|
const Icon = item.icon;
|
|
return (
|
|
<NavLink
|
|
key={item.label}
|
|
to={item.to}
|
|
state={SIDEBAR_SCROLL_RESET_STATE}
|
|
className={({ isActive }) =>
|
|
cn(
|
|
"relative flex min-w-0 flex-col items-center justify-center gap-1 rounded-md text-[10px] font-medium transition-colors",
|
|
isActive
|
|
? "text-foreground"
|
|
: "text-muted-foreground hover:text-foreground",
|
|
)
|
|
}
|
|
>
|
|
{({ isActive }) => (
|
|
<>
|
|
<span className="relative">
|
|
<Icon className={cn("h-[18px] w-[18px]", isActive && "stroke-[2.3]")} />
|
|
{item.badge != null && item.badge > 0 && (
|
|
<span className="absolute -right-2 -top-2 rounded-full bg-primary px-1.5 py-0.5 text-[10px] leading-none text-primary-foreground">
|
|
{item.badge > 99 ? "99+" : item.badge}
|
|
</span>
|
|
)}
|
|
</span>
|
|
<span className="truncate">{item.label}</span>
|
|
</>
|
|
)}
|
|
</NavLink>
|
|
);
|
|
})}
|
|
</div>
|
|
</nav>
|
|
);
|
|
}
|