6f9801a46b
## Thinking Path
> - Paperclip is the open source app people use to manage AI agents for
work
> - The first-run experience (onboarding wizard) and the chat surfaces
(conference-room/board chat, task threads, composers) are the product's
front door — they decide whether a new operator understands "hire
agents, give them work, review results" in the first five minutes
> - Today those surfaces feel ticket-y and form-like: the wizard is a
static multi-step form that ends in an anticlimactic "Launch" screen,
the task composer and board chat behave differently from each other, and
agent-feed issue quicklooks misbehave (multiple flyouts open at once,
cards jump on hover)
> - We wanted to iterate toward a conversational, team-centric NUX — but
without risking the workflows of everyone already running Paperclip
> - This PR reworks the NUX behind a new default-OFF
`enableConferenceRoomChat` experimental flag: a capsule-motif onboarding
wizard that builds your team as you answer, a conference-room chat
surface, one shared ChatComposer across surfaces, brand-accurate status
chips, and feed-quicklook fixes — with the pre-existing UI
fork-and-frozen as `*Classic` components that flag-OFF users keep
> - The benefit is a complete, testable modern NUX that anyone can opt
into from Settings → Experimental, with zero default behavior change and
a clean path to either graduate or drop the experiment
## Linked Issues or Issue Description
No pre-existing GitHub issue — feature description per
`feature_request.yml`:
- **Problem / motivation:** Paperclip's onboarding wizard and chat
surfaces grew up as separate ticket-centric forms. New users get a
form-filling experience rather than the feeling of standing up a team;
the board chat and task threads use different composers with different
affordances; the agent feed's issue quicklook can stack multiple
popovers and shifts cards on hover.
- **Proposed solution:** A coherent NUX experiment behind one
experimental flag (`enableConferenceRoomChat`, Settings → Experimental,
default OFF): capsule onboarding wizard with an evolving team capsule,
conference-room chat, unified `ChatComposer`, team-centric copy, brand
status chips, quicklook single-flight fix. Flag-OFF users get the exact
pre-experiment UI via frozen `*Classic` forks, verified by an on/off
parity test matrix.
- **Alternatives considered:** (a) incremental unflagged restyling —
rejected: the changes interlock across surfaces and would drip risk into
every release; (b) a separate app shell / route for the new NUX —
rejected: too much divergence, the flag + classic-fork pattern keeps the
diff reviewable and reversible.
- **Roadmap alignment:** `ROADMAP.md` lists **CEO Chat** ("a
lighter-weight way to talk to leadership agents... should still resolve
to real work objects"). This experiment is groundwork in that direction
(conference-room chat resolves to issues/tasks via the same composer
used in task threads) and does not change the core task-and-comments
model.
Related PRs found in the dedup search (same area, none duplicate this
work — they target the classic wizard, which this PR intentionally
leaves intact and mergeable):
- #5385 — Coach-driven onboarding: conversational entry +
agent-companies package import
- #5378 — Onboarding wizard: reusable adapter picker + probe card
- #6636 — ui(onboarding): friendly error surface + retry for the wizard
- #7005 — fix(onboarding): explicitly await first-task wake
- #2616 — fix: restore workspace directory config in onboarding wizard
## What Changed
- **Experimental flag plumbing** — `enableConferenceRoomChat` in shared
types/validators, server instance-settings service + API, Settings →
Experimental card with explicit enable/disable copy
- **Onboarding wizard** — classic wizard forked and frozen
(`OnboardingWizardClassic`); flag-ON variant is a 5-step capsule wizard
with a persistent evolving `AgentCapsule` (gradient/glow motif),
team-centric reframed copy, and a typing-dots intro (hardened with
fake-timer tests)
- **Conference-room chat** — flag-ON board-chat surface with agent
bubble name/icon headers and copy/vote/timestamp action rows
(`AgentBubbleActionRow`)
- **Unified composer** — shared `ChatComposer` adopted across surfaces;
translucent surface + scroll-mask removal; "Agent mode"/"Plan mode"
relabels; no-assignee confirmation `AlertDialog` (new
`ui/alert-dialog.tsx` primitive); `@task` reference picker +
linkification in mentions
- **Agent feed** — single-flight issue-quicklook store (one popover at a
time), flyouts open to the left, removed hover translate-y jitter
- **Status chips** — brand-accurate task status chips behind the flag
(light/dark, 1px borders per paperclip.ing/brand)
- **Tests** — flag on/off parity matrix across IssueDetail,
NewIssueDialog, Sidebar, wizard, gate components; component tests for
all new pieces
- **Merge with `master`** — one conflict in
`ui/src/components/IssueChatThread.tsx`, resolved by keeping master's
new `AssigneeChip`/`HandoffWakeRow`/`RunStatusBadge` components inside
the flag-gated metadata-row chrome (details in commit `21a5642a`);
post-merge fixes: vitest 4 mock typing in `MarkdownEditor.test.tsx`,
flag hook made safe for provider-less mounts (master's new isolated
component tests)
- **Branch hygiene** — internal design wireframes/mockups stripped
before the PR (they live in the Paperclip issue threads)
- No user-facing documentation changes required: the flag is
intentionally experimental and self-described in the Settings card; no
existing docs reference the affected surfaces
## Verification
- `pnpm run typecheck` — green across the workspace (ui, server, shared,
plugins)
- Full UI suite (`vitest run` in `ui/`, clean worktree at this HEAD):
**1593/1595 passing, 223/224 files** — the 2 remaining failures are in
`src/components/artifacts/ArtifactCard.test.tsx` and **fail identically
on pristine `origin/master`** (pre-existing upstream, unrelated to this
branch)
- Full server suite (`vitest run` in `server/`, same clean worktree):
results in PR checks; flag plumbing covered by instance-settings tests
- Targeted post-merge resolution check: `IssueChatThread`,
`IssueChatThreadSystemNotice`, `IssueDetail`, `Sidebar`,
`ConferenceRoomChatGate`, `OnboardingWizardVariant`, `NewIssueDialog`,
`InstanceExperimentalSettings`, `MarkdownEditor` — 172/172 passing
- Manual walkthrough: flag OFF (default) → onboarding wizard, task
thread, board chat, composer all render the classic UI; flag ON via
Settings → Experimental → capsule wizard, conference-room chat, unified
composer, status chips active
- Screenshots: see below
**Flag on/off screenshots** (committed on this branch under
`screenshots/PR-8000-*`):
| Surface | Flag OFF (classic, default) | Flag ON (experimental) |
| --- | --- | --- |
| Settings → Experimental | 
| 
|
| Task thread | 
| 
|
| Home / nav | 
| 
|
| Conference Room (flag-ON only surface) | — | 
|
Capsule onboarding wizard walkthrough screenshots (flag ON) are attached
to the Paperclip design/implementation threads; the wizard requires a
fresh instance so it is captured via the e2e harness
(`tests/e2e/nux-phase4-screenshots.spec.ts`).
## Risks
- **Large surface, but gated:** all new behavior sits behind
`enableConferenceRoomChat`, default OFF; flag-OFF rendering is locked by
frozen `*Classic` forks plus an on/off parity test suite
- **Classic forks are frozen at the fork point (`e3aada1d`):** master
features added to the live thread component after that point (assignee
handoff chips, run status badge, composer mention coach) render in the
flag-ON path; the flag-OFF task thread keeps the fork-point behavior
until the experiment graduates (forks deleted) or is dropped (forks
restored as canonical). Called out for reviewer attention.
- **Merge-conflict resolution in `IssueChatThread.tsx`** (commit
`21a5642a`) deserves reviewer eyes: master's new handoff/run-status
components were kept; the base toast-style no-assignee flow remains
replaced by the AlertDialog flow introduced on this branch
- Schema/server changes are additive (one optional boolean instance
setting); no migrations of existing data
## Model Used
- Claude (Anthropic) via Claude Code running in the Paperclip agent
harness (agent: ClaudeCoder)
- Branch implemented across multiple agent sessions on Claude Opus-class
models with extended thinking + tool use (file edits, shell, Playwright
screenshots); merge/PR session model ID as reported by the harness:
`claude-fable-5` (Claude Code CLI)
- All code was agent-authored and board-reviewed through Paperclip issue
threads (plans, wireframes, confirmations) before merging
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes (none
required — experimental flag, self-documenting Settings card; noted
above)
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green (run 3 on `8af3041a`: all 16
gates SUCCESS, incl. e2e and all 4 serialized-suite shards)
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
(re-review verdict: Confidence 5/5, “Safe to merge”; all 4 round-1
findings fixed + confirmed resolved; both summary notes addressed in
`8af3041a`)
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
436 lines
15 KiB
TypeScript
436 lines
15 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { act } from "react";
|
|
import type { ComponentProps, ReactNode } from "react";
|
|
import { createRoot, type Root } from "react-dom/client";
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import { IssueThreadInteractionCard } from "./IssueThreadInteractionCard";
|
|
import { ThemeProvider } from "../context/ThemeContext";
|
|
import { TooltipProvider } from "./ui/tooltip";
|
|
import {
|
|
pendingAskUserQuestionsInteraction,
|
|
commentExpiredRequestConfirmationInteraction,
|
|
disabledDeclineReasonRequestConfirmationInteraction,
|
|
failedRequestConfirmationInteraction,
|
|
pendingRequestConfirmationInteraction,
|
|
pendingSuggestedTasksInteraction,
|
|
staleTargetRequestConfirmationInteraction,
|
|
rejectedSuggestedTasksInteraction,
|
|
} from "../fixtures/issueThreadInteractionFixtures";
|
|
|
|
let root: Root | null = null;
|
|
let container: HTMLDivElement | null = null;
|
|
|
|
(globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
vi.mock("@/lib/router", () => ({
|
|
Link: ({ to, children, className }: { to: string; children: ReactNode; className?: string }) => (
|
|
<a href={to} className={className}>{children}</a>
|
|
),
|
|
}));
|
|
|
|
function renderCard(
|
|
props: Partial<ComponentProps<typeof IssueThreadInteractionCard>> = {},
|
|
) {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
root = createRoot(container);
|
|
|
|
act(() => {
|
|
root?.render(
|
|
<TooltipProvider>
|
|
<ThemeProvider>
|
|
<IssueThreadInteractionCard
|
|
interaction={pendingAskUserQuestionsInteraction}
|
|
{...props}
|
|
/>
|
|
</ThemeProvider>
|
|
</TooltipProvider>,
|
|
);
|
|
});
|
|
|
|
return container;
|
|
}
|
|
|
|
afterEach(() => {
|
|
if (root) {
|
|
act(() => root?.unmount());
|
|
}
|
|
container?.remove();
|
|
root = null;
|
|
container = null;
|
|
});
|
|
|
|
describe("IssueThreadInteractionCard", () => {
|
|
it("exposes pending question options as selectable radio and checkbox controls", () => {
|
|
const host = renderCard({
|
|
interaction: pendingAskUserQuestionsInteraction,
|
|
onSubmitInteractionAnswers: vi.fn(),
|
|
});
|
|
|
|
const singleGroup = host.querySelector('[role="radiogroup"]');
|
|
expect(singleGroup?.getAttribute("aria-labelledby")).toBe(
|
|
"interaction-questions-default-collapse-depth-prompt",
|
|
);
|
|
|
|
const radios = [...host.querySelectorAll('[role="radio"]')];
|
|
expect(radios).toHaveLength(2);
|
|
expect(radios[0]?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
act(() => {
|
|
(radios[0] as HTMLButtonElement).click();
|
|
});
|
|
|
|
expect(radios[0]?.getAttribute("aria-checked")).toBe("true");
|
|
expect(radios[1]?.getAttribute("aria-checked")).toBe("false");
|
|
|
|
const multiGroup = host.querySelector('[role="group"]');
|
|
expect(multiGroup?.getAttribute("aria-labelledby")).toBe(
|
|
"interaction-questions-default-post-submit-summary-prompt",
|
|
);
|
|
expect(host.querySelectorAll('[role="checkbox"]')).toHaveLength(3);
|
|
|
|
const otherLink = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent === "Other",
|
|
);
|
|
expect(otherLink?.getAttribute("role")).toBeNull();
|
|
expect(otherLink?.className).toContain("underline");
|
|
});
|
|
|
|
it("submits written Other answers for pending questions", async () => {
|
|
const onSubmitInteractionAnswers = vi.fn(async () => undefined);
|
|
const host = renderCard({
|
|
interaction: pendingAskUserQuestionsInteraction,
|
|
onSubmitInteractionAnswers,
|
|
});
|
|
|
|
const otherButtons = Array.from(host.querySelectorAll("button")).filter((button) =>
|
|
button.textContent?.includes("Other"),
|
|
);
|
|
expect(otherButtons.length).toBeGreaterThan(0);
|
|
|
|
await act(async () => {
|
|
otherButtons[0]?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
const textarea = host.querySelector("textarea") as HTMLTextAreaElement | null;
|
|
expect(textarea).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
const valueSetter = Object.getOwnPropertyDescriptor(
|
|
HTMLTextAreaElement.prototype,
|
|
"value",
|
|
)?.set;
|
|
valueSetter?.call(textarea, "Keep only the root item open");
|
|
textarea!.dispatchEvent(new Event("input", { bubbles: true }));
|
|
});
|
|
|
|
const summaryCheckbox = Array.from(host.querySelectorAll('[role="checkbox"]')).find((button) =>
|
|
button.textContent?.includes("Inline answer pills"),
|
|
);
|
|
await act(async () => {
|
|
summaryCheckbox?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
const submitButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Send answers"),
|
|
);
|
|
await act(async () => {
|
|
submitButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(onSubmitInteractionAnswers).toHaveBeenCalledWith(
|
|
expect.objectContaining({ kind: "ask_user_questions" }),
|
|
[
|
|
{
|
|
questionId: "collapse-depth",
|
|
optionIds: [],
|
|
otherText: "Keep only the root item open",
|
|
},
|
|
{
|
|
questionId: "post-submit-summary",
|
|
optionIds: ["answers-inline"],
|
|
},
|
|
],
|
|
);
|
|
});
|
|
|
|
it("only shows question cancellation when a cancel handler is wired", () => {
|
|
const withoutHandler = renderCard({
|
|
interaction: pendingAskUserQuestionsInteraction,
|
|
onSubmitInteractionAnswers: vi.fn(),
|
|
});
|
|
expect(withoutHandler.textContent).not.toContain("Cancel question");
|
|
|
|
act(() => root?.unmount());
|
|
withoutHandler.remove();
|
|
root = null;
|
|
|
|
const withHandler = renderCard({
|
|
interaction: pendingAskUserQuestionsInteraction,
|
|
onCancelInteraction: vi.fn(),
|
|
onSubmitInteractionAnswers: vi.fn(),
|
|
});
|
|
expect(withHandler.textContent).toContain("Cancel question");
|
|
});
|
|
|
|
it("makes child tasks explicit in suggested task trees", () => {
|
|
const host = renderCard({
|
|
interaction: pendingSuggestedTasksInteraction,
|
|
});
|
|
|
|
expect(host.textContent).toContain("Child task");
|
|
});
|
|
|
|
it("shows an explicit placeholder when a rejected interaction has no reason", () => {
|
|
const host = renderCard({
|
|
interaction: {
|
|
...rejectedSuggestedTasksInteraction,
|
|
result: { version: 1 },
|
|
},
|
|
});
|
|
|
|
expect(host.textContent).toContain("No reason provided.");
|
|
});
|
|
|
|
it("requires a decline reason when the request confirmation payload asks for one", async () => {
|
|
const onRejectInteraction = vi.fn(async () => undefined);
|
|
const host = renderCard({
|
|
interaction: pendingRequestConfirmationInteraction,
|
|
onRejectInteraction,
|
|
});
|
|
|
|
const declineButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Request revisions"),
|
|
);
|
|
expect(declineButton).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
declineButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
const saveButton = Array.from(host.querySelectorAll("button")).filter((button) =>
|
|
button.textContent?.includes("Request revisions"),
|
|
).at(-1);
|
|
expect(saveButton?.hasAttribute("disabled")).toBe(false);
|
|
|
|
await act(async () => {
|
|
saveButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(host.textContent).toContain("A decline reason is required.");
|
|
|
|
const textarea = host.querySelector("textarea") as HTMLTextAreaElement | null;
|
|
expect(textarea).toBeTruthy();
|
|
expect(textarea?.getAttribute("aria-invalid")).toBe("true");
|
|
|
|
await act(async () => {
|
|
const valueSetter = Object.getOwnPropertyDescriptor(
|
|
HTMLTextAreaElement.prototype,
|
|
"value",
|
|
)?.set;
|
|
valueSetter?.call(textarea, "Needs a smaller phase split");
|
|
textarea!.dispatchEvent(new Event("input", { bubbles: true }));
|
|
});
|
|
const enabledSaveButton = Array.from(host.querySelectorAll("button")).filter((button) =>
|
|
button.textContent?.includes("Request revisions"),
|
|
).at(-1);
|
|
expect(enabledSaveButton?.hasAttribute("disabled")).toBe(false);
|
|
await act(async () => {
|
|
enabledSaveButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(onRejectInteraction).toHaveBeenCalledWith(
|
|
expect.objectContaining({ kind: "request_confirmation" }),
|
|
"Needs a smaller phase split",
|
|
);
|
|
});
|
|
|
|
it("invokes the confirm callback with pending request confirmations", async () => {
|
|
const onAcceptInteraction = vi.fn(async () => undefined);
|
|
const host = renderCard({
|
|
interaction: pendingRequestConfirmationInteraction,
|
|
onAcceptInteraction,
|
|
});
|
|
|
|
const confirmButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Approve plan"),
|
|
);
|
|
expect(confirmButton).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
confirmButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(onAcceptInteraction).toHaveBeenCalledWith(
|
|
expect.objectContaining({ kind: "request_confirmation" }),
|
|
);
|
|
});
|
|
|
|
it("labels accept-only continuation policies in the card header", () => {
|
|
const host = renderCard({
|
|
interaction: {
|
|
...pendingRequestConfirmationInteraction,
|
|
continuationPolicy: "wake_assignee_on_accept",
|
|
},
|
|
});
|
|
|
|
expect(host.textContent).toContain("Wakes on confirm");
|
|
});
|
|
|
|
it("renders request confirmation target links and stale-target expiry", () => {
|
|
const host = renderCard({
|
|
interaction: staleTargetRequestConfirmationInteraction,
|
|
});
|
|
|
|
const targetLinks = host.querySelectorAll("a");
|
|
expect(host.textContent).toContain("Expired by target change");
|
|
expect(host.textContent).toContain("Plan v3");
|
|
expect(host.textContent).toContain("Plan v4");
|
|
expect(targetLinks[0]?.getAttribute("href")).toContain("#document-plan");
|
|
expect(targetLinks[1]?.getAttribute("href")).toContain("#document-plan");
|
|
expect(host.textContent).not.toContain("Approve plan");
|
|
});
|
|
|
|
it("renders a jump link for confirmations expired by comment", () => {
|
|
const host = renderCard({
|
|
interaction: commentExpiredRequestConfirmationInteraction,
|
|
});
|
|
|
|
const jumpLink = Array.from(host.querySelectorAll("a")).find((link) =>
|
|
link.textContent?.includes("Jump to comment"),
|
|
);
|
|
|
|
expect(jumpLink?.getAttribute("href")).toBe(
|
|
"#comment-22222222-2222-4222-8222-222222222222",
|
|
);
|
|
});
|
|
|
|
it("declines immediately when decline reasons are disabled", async () => {
|
|
const onRejectInteraction = vi.fn(async () => undefined);
|
|
const host = renderCard({
|
|
interaction: disabledDeclineReasonRequestConfirmationInteraction,
|
|
onRejectInteraction,
|
|
});
|
|
|
|
const declineButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Keep it"),
|
|
);
|
|
expect(declineButton).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
declineButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(host.querySelector("textarea")).toBeNull();
|
|
expect(onRejectInteraction).toHaveBeenCalledWith(
|
|
expect.objectContaining({ kind: "request_confirmation" }),
|
|
undefined,
|
|
);
|
|
});
|
|
|
|
it("renders explicit copy for failed request confirmations", () => {
|
|
const host = renderCard({
|
|
interaction: failedRequestConfirmationInteraction,
|
|
});
|
|
|
|
expect(host.textContent).toContain(
|
|
"This request could not be resolved. Try again or create a new request.",
|
|
);
|
|
});
|
|
|
|
it("renders a plan confirmation as a distinct state-coloured plan card", () => {
|
|
const pending = renderCard({ interaction: pendingRequestConfirmationInteraction });
|
|
const pendingShell = pending.firstElementChild as HTMLElement;
|
|
expect(pendingShell.className).toContain("border-violet-500/80");
|
|
expect(pendingShell.className).not.toContain("border-l-");
|
|
expect(pending.textContent).toContain("Plan");
|
|
expect(pending.textContent).toContain("In review");
|
|
// Approve is a neutral CTA (foreground/background), not the blue primary.
|
|
const approve = Array.from(pending.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Approve plan"),
|
|
);
|
|
expect(approve?.className).toContain("bg-foreground");
|
|
expect(approve?.className).not.toContain("bg-primary");
|
|
|
|
act(() => root?.unmount());
|
|
pending.remove();
|
|
root = null;
|
|
|
|
const accepted = renderCard({
|
|
interaction: { ...pendingRequestConfirmationInteraction, status: "accepted" },
|
|
});
|
|
expect((accepted.firstElementChild as HTMLElement).className).toContain("border-green-500/80");
|
|
expect(accepted.textContent).toContain("Approved");
|
|
|
|
act(() => root?.unmount());
|
|
accepted.remove();
|
|
root = null;
|
|
|
|
const rejected = renderCard({
|
|
interaction: {
|
|
...pendingRequestConfirmationInteraction,
|
|
status: "rejected",
|
|
result: { version: 1, outcome: "rejected", reason: "Tighten the spacing" },
|
|
},
|
|
});
|
|
expect((rejected.firstElementChild as HTMLElement).className).toContain("border-red-500/80");
|
|
expect(rejected.textContent).toContain("Changes requested");
|
|
});
|
|
|
|
it("attaches screenshots to a plan request-changes reason as markdown images", async () => {
|
|
const onRejectInteraction = vi.fn(async () => undefined);
|
|
const onUploadImage = vi.fn(async () => "https://cdn.example/shot.png");
|
|
const host = renderCard({
|
|
interaction: {
|
|
...pendingRequestConfirmationInteraction,
|
|
payload: {
|
|
...pendingRequestConfirmationInteraction.payload,
|
|
rejectRequiresReason: false,
|
|
},
|
|
},
|
|
onRejectInteraction,
|
|
onUploadImage,
|
|
});
|
|
|
|
const declineButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Request revisions"),
|
|
);
|
|
await act(async () => {
|
|
declineButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
const attachButton = Array.from(host.querySelectorAll("button")).find((button) =>
|
|
button.textContent?.includes("Attach screenshots"),
|
|
);
|
|
expect(attachButton).toBeTruthy();
|
|
|
|
const fileInput = host.querySelector('input[type="file"]') as HTMLInputElement | null;
|
|
expect(fileInput).toBeTruthy();
|
|
const file = new File(["x"], "bug.png", { type: "image/png" });
|
|
Object.defineProperty(fileInput!, "files", { value: [file], configurable: true });
|
|
Object.defineProperty(fileInput!, "value", {
|
|
value: "C:/fake/bug.png",
|
|
writable: true,
|
|
configurable: true,
|
|
});
|
|
|
|
await act(async () => {
|
|
fileInput!.dispatchEvent(new Event("change", { bubbles: true }));
|
|
});
|
|
expect(onUploadImage).toHaveBeenCalledTimes(1);
|
|
|
|
const saveButton = Array.from(host.querySelectorAll("button")).filter((button) =>
|
|
button.textContent?.includes("Request revisions"),
|
|
).at(-1);
|
|
await act(async () => {
|
|
saveButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(onRejectInteraction).toHaveBeenCalledWith(
|
|
expect.objectContaining({ kind: "request_confirmation" }),
|
|
"",
|
|
);
|
|
});
|
|
});
|