eaef47f4c7
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The board UI is the control surface for issues, projects, agents, goals, workspaces, and operator settings. > - The existing navigation and list surfaces make several high-frequency workflows feel harder to scan than they should, especially around projects and agents. > - The product direction is to improve those surfaces without breaking the existing route model or forcing a new IA on every operator at once. > - This pull request now keeps the dependent IA, project identity, and agent-list visual refresh work together while the Issue-to-Task copy migration is split into #7651. > - The benefit is a clearer left nav, better project identity, denser agent/project list rows, and brand-aligned status treatment while preserving the classic default experience behind a flag. ## Linked Issues or Issue Description Refs #7645 Refs #7651 Internal planning/work references: PAP-53, PAP-56, PAP-58, PAP-59, PAP-60, PAP-61, PAP-68, PAP-69, PAP-70, PAP-71, PAP-72, PAP-75, PAP-76, PAP-80, PAP-85, PAP-86, PAP-87, PAP-88, PAP-89. ## What Changed - Adds `enableStreamlinedLeftNavigation`, defaulting off, and gates sidebar presentation so classic navigation remains the default. - Adds project icon persistence, validation, portability, picker UI, and `ProjectTile` rendering while defaulting new projects to neutral gray. - Adds projects-list task-count and budget summary data with focused server/shared/UI coverage. - Refreshes agent list rows, row actions, active/recent sidebar behavior, and status capsule/chip styling for the approved brand state system. - Removes the placeholder Conference room and Artifacts nav/routes from the finalized experimental nav direction. - Removes `pnpm-lock.yaml` and the Issue-to-Task copy migration from this PR diff; the copy migration now lives in #7651. ## Verification - Existing branch verification from the authored commits: UI typecheck, targeted unit tests, and light/dark visual checks for `/agents`, agent detail, and design-guide status states. - Maintainer cleanup verification on `75e34e5`: `git diff --check origin/master...HEAD` passed, the `design/` diff is empty, and the PR diff is 61 files, below Greptile's 100-file review limit. - `pnpm --filter @paperclipai/ui build` passed. - `NODE_ENV=test pnpm exec vitest run ui/src/components/Sidebar.test.tsx` passed: 1 file, 8 tests. - CI and Greptile should rerun on the latest push. ## Risks - Broad UI surface area: the experimental flag keeps the classic nav default, but changed shared components such as `EntityRow`, `ProjectTile`, and agent status badges could affect multiple pages. - Database migration: `projects.icon` is additive and nullable, but migration ordering and portability import/export must stay aligned. - The Issue-to-Task copy migration is now separated into #7651, so reviewers should evaluate this PR as IA/project/agent presentation work only. - Visual regressions are possible across smaller widths because the PR intentionally changes dense list-row layouts. ## Model Used Claude Opus 4.8 assisted the original feature commits. Paperclip-Paperclip agents assisted some planning/design commits. Codex / GPT-5-class coding agent with shell, GitHub CLI, and repository access performed this PR-readiness cleanup and split. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Dotta <bippadotta@protonmail.com>
438 lines
13 KiB
TypeScript
438 lines
13 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { act } from "react";
|
|
import { createRoot } from "react-dom/client";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import type { Agent, ExecutionWorkspace, Project } from "@paperclipai/shared";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { RoutineRunVariablesDialog } from "./RoutineRunVariablesDialog";
|
|
|
|
let issueWorkspaceDraftCalls = 0;
|
|
let issueWorkspaceDraft = {
|
|
executionWorkspaceId: null as string | null,
|
|
executionWorkspacePreference: "shared_workspace",
|
|
executionWorkspaceSettings: { mode: "shared_workspace" },
|
|
};
|
|
let issueWorkspaceBranchName: string | null = null;
|
|
let latestWorkspaceIssue: Record<string, unknown> | null = null;
|
|
|
|
vi.mock("../api/instanceSettings", () => ({
|
|
instanceSettingsApi: {
|
|
getExperimental: vi.fn(async () => ({ enableIsolatedWorkspaces: true })),
|
|
},
|
|
}));
|
|
|
|
vi.mock("./IssueWorkspaceCard", async () => {
|
|
const React = await import("react");
|
|
|
|
return {
|
|
IssueWorkspaceCard: ({
|
|
issue,
|
|
onDraftChange,
|
|
}: {
|
|
issue: Record<string, unknown>;
|
|
onDraftChange?: (
|
|
data: Record<string, unknown>,
|
|
meta: { canSave: boolean; workspaceBranchName?: string | null },
|
|
) => void;
|
|
}) => {
|
|
React.useEffect(() => {
|
|
latestWorkspaceIssue = issue;
|
|
issueWorkspaceDraftCalls += 1;
|
|
if (issueWorkspaceDraftCalls > 20) {
|
|
throw new Error("IssueWorkspaceCard onDraftChange looped");
|
|
}
|
|
onDraftChange?.(issueWorkspaceDraft, {
|
|
canSave: true,
|
|
workspaceBranchName: issueWorkspaceBranchName,
|
|
});
|
|
}, [onDraftChange]);
|
|
|
|
return <div data-testid="workspace-card">Workspace card</div>;
|
|
},
|
|
};
|
|
});
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
function createProject(): Project {
|
|
return {
|
|
id: "project-1",
|
|
companyId: "company-1",
|
|
urlKey: "workspace-project",
|
|
goalId: null,
|
|
goalIds: [],
|
|
goals: [],
|
|
name: "Workspace project",
|
|
description: null,
|
|
status: "in_progress",
|
|
leadAgentId: null,
|
|
targetDate: null,
|
|
color: "#22c55e",
|
|
icon: null,
|
|
env: null,
|
|
pauseReason: null,
|
|
pausedAt: null,
|
|
archivedAt: null,
|
|
executionWorkspacePolicy: {
|
|
enabled: true,
|
|
defaultMode: "shared_workspace",
|
|
allowIssueOverride: true,
|
|
},
|
|
codebase: {
|
|
workspaceId: null,
|
|
repoUrl: null,
|
|
repoRef: null,
|
|
defaultRef: null,
|
|
repoName: null,
|
|
localFolder: null,
|
|
managedFolder: "/tmp/paperclip/project-1",
|
|
effectiveLocalFolder: "/tmp/paperclip/project-1",
|
|
origin: "managed_checkout",
|
|
},
|
|
workspaces: [],
|
|
primaryWorkspace: null,
|
|
createdAt: new Date("2026-04-02T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-04-02T00:00:00.000Z"),
|
|
};
|
|
}
|
|
|
|
function createAgent(): Agent {
|
|
return {
|
|
id: "agent-1",
|
|
companyId: "company-1",
|
|
name: "Routine Agent",
|
|
role: "engineer",
|
|
title: null,
|
|
status: "active",
|
|
reportsTo: null,
|
|
capabilities: null,
|
|
adapterType: "process",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
budgetMonthlyCents: 0,
|
|
spentMonthlyCents: 0,
|
|
lastHeartbeatAt: null,
|
|
icon: "code",
|
|
metadata: null,
|
|
createdAt: new Date("2026-04-02T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-04-02T00:00:00.000Z"),
|
|
urlKey: "routine-agent",
|
|
pauseReason: null,
|
|
pausedAt: null,
|
|
permissions: { canCreateAgents: false },
|
|
};
|
|
}
|
|
|
|
function createExecutionWorkspace(): ExecutionWorkspace {
|
|
return {
|
|
id: "workspace-1",
|
|
companyId: "company-1",
|
|
projectId: "project-1",
|
|
projectWorkspaceId: "project-workspace-1",
|
|
sourceIssueId: null,
|
|
mode: "isolated_workspace",
|
|
strategyType: "git_worktree",
|
|
name: "PAP-1634",
|
|
status: "active",
|
|
cwd: "/tmp/paperclip/PAP-1634",
|
|
repoUrl: null,
|
|
baseRef: "main",
|
|
branchName: "pap-1634-routine-branch",
|
|
providerType: "local_fs",
|
|
providerRef: null,
|
|
derivedFromExecutionWorkspaceId: null,
|
|
lastUsedAt: new Date("2026-04-02T00:00:00.000Z"),
|
|
openedAt: new Date("2026-04-02T00:00:00.000Z"),
|
|
closedAt: null,
|
|
cleanupEligibleAt: null,
|
|
cleanupReason: null,
|
|
config: {
|
|
provisionCommand: null,
|
|
teardownCommand: null,
|
|
cleanupCommand: null,
|
|
workspaceRuntime: null,
|
|
desiredState: null,
|
|
},
|
|
metadata: null,
|
|
runtimeServices: [],
|
|
createdAt: new Date("2026-04-02T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-04-02T00:00:00.000Z"),
|
|
};
|
|
}
|
|
|
|
describe("RoutineRunVariablesDialog", () => {
|
|
let container: HTMLDivElement;
|
|
|
|
beforeEach(() => {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
issueWorkspaceDraftCalls = 0;
|
|
issueWorkspaceDraft = {
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: "shared_workspace",
|
|
executionWorkspaceSettings: { mode: "shared_workspace" },
|
|
};
|
|
issueWorkspaceBranchName = null;
|
|
latestWorkspaceIssue = null;
|
|
});
|
|
|
|
afterEach(() => {
|
|
container.remove();
|
|
document.body.innerHTML = "";
|
|
});
|
|
|
|
it("does not loop when the workspace card reports the same draft repeatedly", async () => {
|
|
const root = createRoot(container);
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: {
|
|
queries: {
|
|
retry: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
await act(async () => {
|
|
root.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<RoutineRunVariablesDialog
|
|
open
|
|
onOpenChange={() => {}}
|
|
companyId="company-1"
|
|
projects={[createProject()]}
|
|
agents={[createAgent()]}
|
|
defaultProjectId="project-1"
|
|
defaultAssigneeAgentId="agent-1"
|
|
variables={[]}
|
|
isPending={false}
|
|
onSubmit={() => {}}
|
|
/>
|
|
</QueryClientProvider>,
|
|
);
|
|
await Promise.resolve();
|
|
await Promise.resolve();
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
});
|
|
|
|
expect(issueWorkspaceDraftCalls).toBeLessThanOrEqual(2);
|
|
expect(document.body.textContent).toContain("Run routine");
|
|
expect(document.body.textContent).not.toContain("Search agents...");
|
|
expect(document.body.textContent).not.toContain("Search projects...");
|
|
|
|
await act(async () => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("keeps the mobile dialog bounded with an internal form scroll region", async () => {
|
|
const root = createRoot(container);
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: {
|
|
queries: {
|
|
retry: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
await act(async () => {
|
|
root.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<RoutineRunVariablesDialog
|
|
open
|
|
onOpenChange={() => {}}
|
|
companyId="company-1"
|
|
projects={[createProject()]}
|
|
agents={[createAgent()]}
|
|
defaultProjectId="project-1"
|
|
defaultAssigneeAgentId="agent-1"
|
|
variables={[
|
|
{
|
|
name: "notes",
|
|
label: "notes",
|
|
type: "textarea",
|
|
defaultValue: null,
|
|
required: false,
|
|
options: [],
|
|
},
|
|
]}
|
|
isPending={false}
|
|
onSubmit={() => {}}
|
|
/>
|
|
</QueryClientProvider>,
|
|
);
|
|
await Promise.resolve();
|
|
await Promise.resolve();
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
});
|
|
|
|
const dialogContent = Array.from(document.body.querySelectorAll("div")).find((element) =>
|
|
typeof element.className === "string" && element.className.includes("max-h-[calc(100dvh-2rem)]"),
|
|
);
|
|
expect(dialogContent?.className).toContain("h-[calc(100dvh-2rem)]");
|
|
expect(dialogContent?.className).toContain("overflow-hidden");
|
|
|
|
const notesInput = document.querySelector("textarea");
|
|
const formScrollRegion = Array.from(document.body.querySelectorAll("div")).find((element) =>
|
|
typeof element.className === "string" && element.className.includes("overscroll-contain"),
|
|
);
|
|
expect(formScrollRegion?.className).toContain("min-h-0");
|
|
expect(formScrollRegion?.className).toContain("flex-1");
|
|
expect(formScrollRegion?.className).toContain("overflow-y-auto");
|
|
expect(formScrollRegion?.contains(notesInput)).toBe(true);
|
|
|
|
const footer = Array.from(document.body.querySelectorAll("div")).find((element) =>
|
|
typeof element.className === "string" && element.className.includes("pb-[calc(1rem+env(safe-area-inset-bottom))]"),
|
|
);
|
|
expect(footer?.className).toContain("shrink-0");
|
|
expect(footer?.contains(formScrollRegion ?? null)).toBe(false);
|
|
expect(footer?.textContent).toContain("Run routine");
|
|
|
|
await act(async () => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("renders workspaceBranch as a read-only selected workspace value", async () => {
|
|
issueWorkspaceDraft = {
|
|
executionWorkspaceId: "workspace-1",
|
|
executionWorkspacePreference: "reuse_existing",
|
|
executionWorkspaceSettings: { mode: "isolated_workspace" },
|
|
};
|
|
issueWorkspaceBranchName = "pap-1634-routine-branch";
|
|
const onSubmit = vi.fn();
|
|
const root = createRoot(container);
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: {
|
|
queries: {
|
|
retry: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
await act(async () => {
|
|
root.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<RoutineRunVariablesDialog
|
|
open
|
|
onOpenChange={() => {}}
|
|
companyId="company-1"
|
|
projects={[createProject()]}
|
|
agents={[createAgent()]}
|
|
defaultProjectId="project-1"
|
|
defaultAssigneeAgentId="agent-1"
|
|
variables={[
|
|
{
|
|
name: "workspaceBranch",
|
|
label: null,
|
|
type: "text",
|
|
defaultValue: null,
|
|
required: true,
|
|
options: [],
|
|
},
|
|
]}
|
|
isPending={false}
|
|
onSubmit={onSubmit}
|
|
/>
|
|
</QueryClientProvider>,
|
|
);
|
|
await Promise.resolve();
|
|
await Promise.resolve();
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
});
|
|
|
|
for (let i = 0; i < 10 && !document.querySelector('[data-testid="workspace-card"]'); i += 1) {
|
|
await act(async () => {
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
});
|
|
}
|
|
|
|
const branchInput = Array.from(document.querySelectorAll("input"))
|
|
.find((input) => input.value === "pap-1634-routine-branch");
|
|
expect(branchInput?.disabled).toBe(true);
|
|
expect(document.body.textContent).not.toContain("Missing: workspaceBranch");
|
|
|
|
const runButton = Array.from(document.querySelectorAll("button"))
|
|
.find((button) => button.textContent === "Run routine");
|
|
expect(runButton).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
runButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(onSubmit).toHaveBeenCalledWith({
|
|
variables: {
|
|
workspaceBranch: "pap-1634-routine-branch",
|
|
},
|
|
assigneeAgentId: "agent-1",
|
|
projectId: "project-1",
|
|
executionWorkspaceId: "workspace-1",
|
|
executionWorkspacePreference: "reuse_existing",
|
|
executionWorkspaceSettings: { mode: "isolated_workspace" },
|
|
});
|
|
|
|
await act(async () => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("prefills the supplied execution workspace for workspace-specific routine runs", async () => {
|
|
const workspace = createExecutionWorkspace();
|
|
issueWorkspaceDraft = {
|
|
executionWorkspaceId: workspace.id,
|
|
executionWorkspacePreference: "reuse_existing",
|
|
executionWorkspaceSettings: { mode: "isolated_workspace" },
|
|
};
|
|
issueWorkspaceBranchName = workspace.branchName;
|
|
|
|
const root = createRoot(container);
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: {
|
|
queries: {
|
|
retry: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
await act(async () => {
|
|
root.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<RoutineRunVariablesDialog
|
|
open
|
|
onOpenChange={() => {}}
|
|
companyId="company-1"
|
|
projects={[createProject()]}
|
|
agents={[createAgent()]}
|
|
defaultProjectId="project-1"
|
|
defaultAssigneeAgentId="agent-1"
|
|
defaultExecutionWorkspace={workspace}
|
|
variables={[]}
|
|
isPending={false}
|
|
onSubmit={() => {}}
|
|
/>
|
|
</QueryClientProvider>,
|
|
);
|
|
await Promise.resolve();
|
|
await Promise.resolve();
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
});
|
|
|
|
for (let i = 0; i < 10 && latestWorkspaceIssue === null; i += 1) {
|
|
await act(async () => {
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
});
|
|
}
|
|
|
|
expect(latestWorkspaceIssue).toMatchObject({
|
|
executionWorkspaceId: workspace.id,
|
|
executionWorkspacePreference: "reuse_existing",
|
|
currentExecutionWorkspace: workspace,
|
|
projectWorkspaceId: workspace.projectWorkspaceId,
|
|
});
|
|
|
|
await act(async () => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
});
|