4518f272b2
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work, distributed primarily via the `paperclipai` npm package and its `@paperclipai/*` workspace packages. > - The release subsystem (`scripts/release-package-*`) decides which workspace packages CI republishes at the unified calver version each release, and `replaceWorkspaceDeps()` rewrites every internal `workspace:` dependency to that calver version at publish time. > - The gap: a package that publishes from CI can declare a `workspace:` dependency on a package that is NOT enrolled for CI publish. The dependency spec gets rewritten to a calver version that is never actually published, so the dependent becomes uninstallable. > - This shipped for real: a recent change made `@paperclipai/server` depend on `@paperclipai/skills-catalog`, but skills-catalog was not on the calver release train — so canary builds after that merge failed to resolve `@paperclipai/skills-catalog@<calver>` and `npx paperclipai@canary run` broke. > - This PR addresses it durably by (a) putting every remaining internal package on the CI release train so no internal dependency can dangle, and (b) adding a fail-fast guard so this class of break can never ship again. > - The benefit is that canary and stable installs resolve all internal dependencies, and any future unpublishable workspace edge fails the release build with a clear, named error instead of producing a broken package. ## Linked Issues or Issue Description Refs #8327 (introduced the `server -> skills-catalog` runtime dependency that surfaced the gap). No public issue tracks this; describing it in-PR: - **Problem:** After #8327, `npx paperclipai@canary run` failed for builds past the merge because `@paperclipai/skills-catalog` was rewritten to a calver version that was never published (the package was not enrolled for CI publish). Versions before the merge still ran. - **Root cause:** A `publishFromCi:true` package can declare a `workspace:` dependency on a package that is not `publishFromCi:true`; the release-time version rewrite then points at a non-existent published version. ## What Changed - Enrolled every remaining internal package on the calver release train by setting `publishFromCi: true` in `scripts/release-package-manifest.json`: `skills-catalog`, `teams-catalog`, `plugin-workspace-diff`, `plugin-kubernetes`, `plugin-novita-sandbox`. There are now zero `publishFromCi:false` entries. - `skills-catalog`, `teams-catalog`, `plugin-workspace-diff` already existed on npm — CI simply republishes them at calver. - `plugin-kubernetes` and `plugin-novita-sandbox` were not on npm; their one-time first publish was bootstrapped so the `check-release-package-bootstrap` gate passes. - Added `findUnpublishableWorkspaceEdges()` to `scripts/release-package-map.mjs`, wired into `buildReleasePackagePlan()`. The release map build now fails fast (surfaced by the `check` CI already runs) whenever a `publishFromCi:true` package declares a runtime `workspace:` dependency (`dependencies`/`optionalDependencies`/`peerDependencies`) on a non-`publishFromCi:true` `@paperclipai/*` package, naming the offending edge. - Added tests covering positive/negative detection, all three dependency sections, unknown-package edges, off-train edges, and the live manifest. ## Verification - `node --test scripts/release-package-map.test.mjs` → 9/9 pass (includes a test asserting the live manifest has no unpublishable edges). - `node scripts/check-release-package-bootstrap.mjs scripts/release-package-manifest.json` → passes, naming all five newly-enabled packages (all confirmed present on npm). - Confirmed via `npm view` that all five packages resolve on the public registry. ## Risks - Low risk. The change only enrolls already-existing (or freshly-bootstrapped) packages onto the existing release train and adds a build-time validation. No runtime code paths change. The new guard can only *fail* a release that was already going to ship a broken package. ## Model Used Claude Opus 4.7 (claude-opus-4-7), extended thinking, with tool use / code execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots (N/A — no UI changes) - [x] I have updated relevant documentation to reflect my changes (N/A — no doc-facing behavior change) - [x] I have considered and documented any risks above - [ ] All Paperclip CI gates are green - [ ] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [ ] I will address all Greptile and reviewer comments before requesting merge
84 lines
3.0 KiB
JavaScript
84 lines
3.0 KiB
JavaScript
#!/usr/bin/env node
|
|
/**
|
|
* check-pr-test-coverage.mjs
|
|
* Checks that a PR diff includes at least one test file. Respects conventional
|
|
* commit prefixes — skips check for docs/chore/build/ci/style/refactor PRs.
|
|
* Also detects mismatch: docs/chore PRs that contain real source code changes.
|
|
* Export: checkTestCoverage(files, prTitle) → { passed, failures }
|
|
*/
|
|
import { fileURLToPath } from 'node:url';
|
|
|
|
const TEST_PATTERNS = [
|
|
/\.test\.(ts|js|tsx|jsx|mjs|cjs)$/,
|
|
/\.spec\.(ts|js|tsx|jsx|mjs|cjs)$/,
|
|
/(?:^|\/)tests?\//,
|
|
/\/__tests__\//,
|
|
];
|
|
|
|
const SOURCE_CODE_PATTERN = /\.(ts|tsx|js|jsx|mjs|cjs)$/;
|
|
|
|
// Prefixes where test coverage is NOT required
|
|
const SKIP_TEST_PREFIXES = ['docs', 'chore', 'build', 'ci', 'style', 'refactor', 'revert'];
|
|
|
|
// Prefixes where source code changes are NOT expected (mismatch detection)
|
|
// Note: 'style' is excluded — formatting PRs legitimately touch source files
|
|
const NO_SOURCE_CODE_PREFIXES = ['docs', 'chore', 'build', 'ci'];
|
|
|
|
function parsePrefix(title) {
|
|
if (!title) return null;
|
|
const match = title.match(/^([a-z]+)(?:\([^)]*\))?:/);
|
|
return match ? match[1].toLowerCase() : null;
|
|
}
|
|
|
|
function isSourceFile(filename) {
|
|
if (!SOURCE_CODE_PATTERN.test(filename)) return false;
|
|
if (TEST_PATTERNS.some(p => p.test(filename))) return false;
|
|
return true;
|
|
}
|
|
|
|
export function checkTestCoverage(files, prTitle = '') {
|
|
const prefix = parsePrefix(prTitle);
|
|
|
|
// Mismatch detection: docs/chore/etc PR with real source code changes
|
|
if (prefix && NO_SOURCE_CODE_PREFIXES.includes(prefix)) {
|
|
const sourceChanges = files.filter(f => f.status !== 'removed' && isSourceFile(f.filename));
|
|
if (sourceChanges.length > 0) {
|
|
return {
|
|
passed: false,
|
|
failures: [
|
|
`PR is titled \`${prefix}:\` but includes source code changes ` +
|
|
`(${sourceChanges.slice(0, 3).map(f => f.filename).join(', ')}` +
|
|
`${sourceChanges.length > 3 ? ', ...' : ''}). ` +
|
|
`Please retitle as \`fix:\`, \`feat:\`, or \`refactor:\` so the right gates run, ` +
|
|
`or remove the source code changes if this is genuinely a \`${prefix}:\` PR.`,
|
|
],
|
|
};
|
|
}
|
|
}
|
|
|
|
// Skip test requirement for prefixes that don't change behavior
|
|
if (prefix && SKIP_TEST_PREFIXES.includes(prefix)) {
|
|
return { passed: true, failures: [] };
|
|
}
|
|
|
|
const hasTests = files.some(
|
|
f => f.status !== 'removed' && TEST_PATTERNS.some(p => p.test(f.filename))
|
|
);
|
|
|
|
return {
|
|
passed: hasTests,
|
|
failures: hasTests ? [] : [
|
|
'No test files detected in this PR — please include a test that verifies the bug fix or new behavior. ' +
|
|
'If this PR genuinely doesn\'t need a test (e.g. a refactor), please retitle with `refactor:` prefix.',
|
|
],
|
|
};
|
|
}
|
|
|
|
if (process.argv[1] === fileURLToPath(import.meta.url)) {
|
|
const files = JSON.parse(process.env.PR_FILES ?? '[]');
|
|
const title = process.env.PR_TITLE ?? '';
|
|
const result = checkTestCoverage(files, title);
|
|
console.log(JSON.stringify(result));
|
|
process.exit(result.passed ? 0 : 1);
|
|
}
|