2e74d32871
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - The board UI is the operator surface where users create, assign, monitor, and review work items. > - The product language is moving toward "tasks" for user-facing work items while the internal API and database still use "issues". > - PR #7543 bundled this copy migration with broader information-architecture work, which made the branch too large for Greptile review. > - This pull request peels the Issue-to-Task copy migration into a smaller, independently reviewable change. > - The benefit is clearer user-facing terminology, less agent confusion via the Paperclip skill note, and a smaller PR that Greptile can review. ## Linked Issues or Issue Description Refs #7645 Refs #7543 Refs PAP-10430 This PR was split out of #7543 so the Issue-to-Task copy migration can be reviewed separately and the remaining IA PR can fall under Greptile's file limit. ## What Changed - Preserves Scott Tong's original `PAP-57` copy-only commit, with author and co-author credit intact, to rename user-facing "Issues" copy to "Tasks" across the UI while keeping routes/API/internal symbols as `issue`. - Updates onboarding and release-smoke browser selectors from `Create & Open Issue` to `Create & Open Task`. - Adds a terminology note to `skills/paperclip/SKILL.md` clarifying that task and issue refer to the same Paperclip work item. - Resolves the only cherry-pick conflict by keeping current search artifacts support and changing visible search copy to "tasks". ## Verification - `pnpm --filter @paperclipai/ui build` passed. - `NODE_ENV=test pnpm exec vitest run ui/src/components/IssuesList.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/NewIssueDialog.test.tsx ui/src/pages/IssueDetail.test.tsx` passed: 4 files, 66 tests. - `git diff --check origin/master...HEAD` passed. - Diff is 80 files, below Greptile's 100-file limit. - Before/after UI copy examples: "Issues" -> "Tasks", "New Issue" -> "New Task", "Create & Open Issue" -> "Create & Open Task". ## Risks - Medium copy-risk: this intentionally changes user-facing terminology broadly while keeping internal issue identifiers and routes unchanged. - Some docs and APIs still say `issue`; the skill note clarifies this so agents do not treat task and issue as separate entities. - Browser-level visual validation is expected from CI because this local container is missing usable browser dependencies. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used Scott Tong authored the original `PAP-57` copy migration, assisted by Claude Opus 4.8 and Paperclip agents per the preserved commit metadata. Codex / GPT-5-class coding agent with shell, GitHub CLI, and repository access performed the PR split, conflict resolution, skill note, and verification. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: scotttong <scott.tong@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Paperclip <noreply@paperclip.ing>
131 lines
4.0 KiB
TypeScript
131 lines
4.0 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { act, type AnchorHTMLAttributes, type ReactNode } from "react";
|
|
import { createRoot, type Root } from "react-dom/client";
|
|
import type { Issue } from "@paperclipai/shared";
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import { IssueSiblingNavigation } from "./IssueSiblingNavigation";
|
|
|
|
vi.mock("@/lib/router", () => ({
|
|
Link: ({
|
|
children,
|
|
to,
|
|
issueQuicklookAlign,
|
|
issueQuicklookSide,
|
|
issuePrefetch: _issuePrefetch,
|
|
state: _state,
|
|
...props
|
|
}: AnchorHTMLAttributes<HTMLAnchorElement> & {
|
|
to: string;
|
|
issueQuicklookAlign?: string;
|
|
issueQuicklookSide?: string;
|
|
issuePrefetch?: unknown;
|
|
state?: unknown;
|
|
children?: ReactNode;
|
|
}) => (
|
|
<a
|
|
href={to}
|
|
data-quicklook-align={issueQuicklookAlign}
|
|
data-quicklook-side={issueQuicklookSide}
|
|
{...props}
|
|
>
|
|
{children}
|
|
</a>
|
|
),
|
|
}));
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
function issue(id: string, overrides: Partial<Issue> = {}): Issue {
|
|
return {
|
|
id,
|
|
identifier: `PAP-${id}`,
|
|
title: `Sibling ${id}`,
|
|
status: "todo",
|
|
blockerAttention: null,
|
|
createdAt: new Date("2026-05-01T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-05-01T00:00:00.000Z"),
|
|
...overrides,
|
|
} as Issue;
|
|
}
|
|
|
|
let root: Root | null = null;
|
|
let container: HTMLDivElement | null = null;
|
|
|
|
afterEach(() => {
|
|
if (root) {
|
|
act(() => root?.unmount());
|
|
}
|
|
root = null;
|
|
container?.remove();
|
|
container = null;
|
|
});
|
|
|
|
function render(node: ReactNode) {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
root = createRoot(container);
|
|
act(() => root?.render(node));
|
|
return container;
|
|
}
|
|
|
|
describe("IssueSiblingNavigation", () => {
|
|
it("renders the locked card anatomy for previous and next siblings", () => {
|
|
const node = render(
|
|
<IssueSiblingNavigation
|
|
navigation={{
|
|
previous: issue("1", { title: "Previous sibling title" }),
|
|
next: issue("3", { title: "Next sibling title" }),
|
|
currentIndex: 1,
|
|
totalCount: 3,
|
|
}}
|
|
/>,
|
|
);
|
|
|
|
const nav = node.querySelector("nav");
|
|
expect(nav?.getAttribute("aria-label")).toBe("Sub-task navigation");
|
|
expect(nav?.className).toContain("sm:grid-cols-2");
|
|
expect(nav?.className).not.toContain("border-t");
|
|
|
|
const links = Array.from(node.querySelectorAll("a"));
|
|
expect(links).toHaveLength(2);
|
|
expect(links[0].textContent).toContain("Previous");
|
|
expect(links[0].textContent).toContain("PAP-1");
|
|
expect(links[0].textContent).toContain("Previous sibling title");
|
|
expect(links[0].getAttribute("aria-label")).toBe("Previous sub-task: PAP-1 - Previous sibling title");
|
|
expect(links[0].getAttribute("data-quicklook-align")).toBe("start");
|
|
|
|
expect(links[1].textContent).toContain("Next");
|
|
expect(links[1].textContent).toContain("PAP-3");
|
|
expect(links[1].textContent).toContain("Next sibling title");
|
|
expect(links[1].getAttribute("aria-label")).toBe("Next sub-task: PAP-3 - Next sibling title");
|
|
expect(links[1].getAttribute("data-quicklook-align")).toBe("end");
|
|
expect(links[1].className).toContain("sm:text-right");
|
|
|
|
expect(links[0].className).toContain("rounded-lg");
|
|
expect(links[0].className).toContain("hover:bg-accent/50");
|
|
expect(links[0].className).toContain("focus-visible:ring-[3px]");
|
|
expect(node.querySelector(".truncate")?.textContent).toBe("Previous sibling title");
|
|
});
|
|
|
|
it("keeps a lone next card in the right desktop column", () => {
|
|
const node = render(
|
|
<IssueSiblingNavigation
|
|
navigation={{
|
|
previous: null,
|
|
next: issue("2"),
|
|
currentIndex: 0,
|
|
totalCount: 2,
|
|
}}
|
|
/>,
|
|
);
|
|
|
|
const links = Array.from(node.querySelectorAll("a"));
|
|
expect(links).toHaveLength(1);
|
|
expect(links[0].textContent).toContain("Next");
|
|
expect(links[0].className).toContain("sm:col-start-2");
|
|
expect(node.textContent).not.toContain("Previous");
|
|
});
|
|
});
|