4d5322c821
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work. > - Agent work is coordinated through issues, comments, interactions, and approval-style handoffs. > - Existing issue-thread interactions could ask questions, suggest tasks, and request confirmation, but they did not support a structured checkbox confirmation payload for choosing one or more options. > - That gap made board/user confirmations harder to validate consistently across API callers, plugin helpers, CLI tooling, and the UI. > - This pull request adds the shared checkbox confirmation contract, server handling, client helpers, and issue-thread UI needed to render and submit structured selections. > - The benefit is that agents can request bounded multi-select confirmations in the same audited issue-thread flow as other Paperclip interactions. ## Linked Issues or Issue Description - No public GitHub issue found for this exact branch. Internal Paperclip issue: PAP-10415 / PAP-10441 requested creating this PR for the checkbox confirmation issue-thread UI component work. - GitHub duplicate search performed for checkbox confirmation / issue-thread interaction PRs; no matching open PR was found. - Related issue search result `#7497` was unrelated company file cleanup work, so it is not linked as a related issue. ## What Changed - Added shared types, validators, constants, and tests for `request_checkbox_confirmation` interactions. - Extended server issue-thread interaction service and routes for checkbox confirmation creation, validation, expiration, and response handling. - Added CLI, MCP, and plugin SDK helper coverage so external callers can create the new interaction shape consistently. - Updated the issue-thread interaction UI to render checkbox confirmations with min/max bounds, selection summaries, stale-target states, and accept/decline flows. - Documented the checkbox confirmation interaction contract in the Paperclip skill/API reference. ## Verification - Rebased cleanly on `paperclipai/paperclip` `master` fetched into `public-gh/master` at `a4fa0eaf5`. - Confirmed the PR diff does not include `pnpm-lock.yaml` or `.github/workflows` changes. - Ran focused tests with `NODE_ENV=test`: ```sh NODE_ENV=test pnpm run preflight:workspace-links NODE_ENV=test pnpm exec vitest run packages/shared/src/issue-thread-interactions.test.ts server/src/__tests__/issue-thread-interaction-routes.test.ts server/src/__tests__/issue-thread-interactions-service.test.ts ui/src/components/IssueThreadInteractionCard.test.tsx ui/src/lib/issue-thread-interactions.test.ts cli/src/__tests__/issue-subresources.test.ts cli/src/__tests__/project-goal.test.ts packages/mcp-server/src/tools.test.ts packages/plugins/sdk/tests/testing-actions.test.ts ``` Result: 8 test files passed, 78 tests passed. - CI on latest head `63b9e55` is green. - Greptile Review passed on latest head; GraphQL review-thread check shows all Greptile threads resolved. ## Risks - Medium surface area because the interaction contract touches shared validators, server routes/services, UI rendering, CLI, MCP, plugin SDK helpers, and docs. - No database migrations are included. - `pnpm-lock.yaml` is intentionally excluded per repository lockfile policy. - UI screenshots are not attached because the task explicitly requested not to add design screenshots or images unless they were part of the work; component tests cover the new rendering and interaction states. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex coding agent based on GPT-5, with repository file access, shell command execution, git/GitHub CLI tooling, and Paperclip control-plane API access. Exact hosted model ID/context-window metadata is not exposed inside this runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
131 lines
3.8 KiB
TypeScript
131 lines
3.8 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
|
|
import { createTestHarness } from "../src/testing.js";
|
|
import type { PaperclipPluginManifestV1 } from "../src/types.js";
|
|
|
|
const manifest = {
|
|
id: "paperclip.test-actions",
|
|
apiVersion: 1,
|
|
version: "1.0.0",
|
|
displayName: "Test Actions",
|
|
description: "Test plugin",
|
|
author: "Paperclip",
|
|
categories: ["automation"],
|
|
capabilities: [],
|
|
entrypoints: {},
|
|
} satisfies PaperclipPluginManifestV1;
|
|
|
|
describe("createTestHarness action context", () => {
|
|
it("passes immutable authenticated actor context and overrides caller company scope", async () => {
|
|
const harness = createTestHarness({ manifest });
|
|
|
|
harness.ctx.actions.register("inspect", async (params, context) => ({
|
|
paramsCompanyId: params.companyId,
|
|
actor: context.actor,
|
|
companyId: context.companyId,
|
|
contextFrozen: Object.isFrozen(context),
|
|
actorFrozen: Object.isFrozen(context.actor),
|
|
}));
|
|
|
|
const result = await harness.performAction<{
|
|
paramsCompanyId: unknown;
|
|
actor: {
|
|
type: string;
|
|
userId: string | null;
|
|
agentId: string | null;
|
|
runId: string | null;
|
|
companyId: string | null;
|
|
};
|
|
companyId: string | null;
|
|
contextFrozen: boolean;
|
|
actorFrozen: boolean;
|
|
}>(
|
|
"inspect",
|
|
{ companyId: "spoofed-company", value: true },
|
|
{
|
|
companyId: "host-company",
|
|
actor: {
|
|
type: "user",
|
|
userId: "board-user-1",
|
|
runId: "run-1",
|
|
},
|
|
},
|
|
);
|
|
|
|
expect(result.paramsCompanyId).toBe("host-company");
|
|
expect(result.companyId).toBe("host-company");
|
|
expect(result.actor).toEqual({
|
|
type: "user",
|
|
userId: "board-user-1",
|
|
agentId: null,
|
|
runId: "run-1",
|
|
companyId: "host-company",
|
|
});
|
|
expect(result.contextFrozen).toBe(true);
|
|
expect(result.actorFrozen).toBe(true);
|
|
});
|
|
|
|
it("keeps existing one-argument action handlers compatible", async () => {
|
|
const harness = createTestHarness({ manifest });
|
|
harness.ctx.actions.register("legacy", async (params) => ({ ok: params.ok }));
|
|
|
|
await expect(harness.performAction("legacy", { ok: true })).resolves.toEqual({ ok: true });
|
|
});
|
|
});
|
|
|
|
describe("createTestHarness issue interactions", () => {
|
|
it("creates request_checkbox_confirmation interactions through the typed host helper", async () => {
|
|
const harness = createTestHarness({
|
|
manifest,
|
|
capabilities: ["issues.create", "issue.interactions.create"],
|
|
});
|
|
const issue = await harness.ctx.issues.create({
|
|
companyId: "company-1",
|
|
title: "Pick files",
|
|
});
|
|
|
|
const interaction = await harness.ctx.issues.requestCheckboxConfirmation(
|
|
issue.id,
|
|
{
|
|
idempotencyKey: "checkbox:files",
|
|
title: "Choose files",
|
|
payload: {
|
|
version: 1,
|
|
prompt: "Which files should be included?",
|
|
options: [
|
|
{ id: "file-a", label: "File A" },
|
|
{ id: "file-b", label: "File B", description: "Secondary draft" },
|
|
],
|
|
defaultSelectedOptionIds: ["file-a"],
|
|
minSelected: 1,
|
|
maxSelected: 2,
|
|
},
|
|
},
|
|
"company-1",
|
|
{ authorAgentId: "agent-1" },
|
|
);
|
|
|
|
expect(interaction).toMatchObject({
|
|
issueId: issue.id,
|
|
companyId: "company-1",
|
|
kind: "request_checkbox_confirmation",
|
|
status: "pending",
|
|
continuationPolicy: "wake_assignee",
|
|
idempotencyKey: "checkbox:files",
|
|
title: "Choose files",
|
|
createdByAgentId: "agent-1",
|
|
payload: {
|
|
version: 1,
|
|
prompt: "Which files should be included?",
|
|
options: [
|
|
{ id: "file-a", label: "File A" },
|
|
{ id: "file-b", label: "File B", description: "Secondary draft" },
|
|
],
|
|
defaultSelectedOptionIds: ["file-a"],
|
|
minSelected: 1,
|
|
maxSelected: 2,
|
|
},
|
|
});
|
|
});
|
|
});
|