Devin Foley
54ab0d24cd
## Thinking Path > - Paperclip is a control plane for AI-agent companies, so issue detail pages are a primary surface for understanding agent work and human feedback. > - The relevant subsystem here is the issue comments/chat experience across the React issue detail page and the server comment pagination API. > - Long issue threads were only surfacing the newest page of comments at first render, which hid earlier human and agent messages behind extra pagination. > - The first UI fix exposed that the descending cursor path on the server could also fail for older-page fetches, leaving the chat tab stuck on an infinite "Loading earlier comments..." state. > - This needed to be addressed in both layers so the chat tab can surface earlier conversation history without manual recovery and without server errors. > - This pull request auto-loads earlier comment pages in the issue detail chat view and fixes the descending cursor predicate used by issue comment pagination. > - The benefit is that long-running issues like `PAPA-103` now show the missing conversation history near the top of the chat surface instead of hiding it or failing to load it. ## What Changed - Auto-load earlier issue comment pages in the issue detail chat tab until the thread reaches a 150-comment cap or there are no older comments left. - Add UI-side guard logic and regression coverage for optimistic issue comment pagination so the autoload behavior stops cleanly. - Replace the raw SQL descending cursor predicate in `issueService.listComments` with typed Drizzle comparisons for the `(createdAt, id)` anchor tuple. - Add a server regression test that paginates earlier comments in descending order from an anchor comment. - Smoke-test the exact previously failing seeded `PAPA-103` cursor path on the isolated dev instance used for review. ## Verification - `pnpm --filter @paperclipai/server exec vitest run src/__tests__/issues-service.test.ts` - `pnpm --filter @paperclipai/server typecheck` - Manual smoke against seeded `PAPA-103` data on the isolated dev server: - `GET /api/issues/PAPA-103/comments?order=desc&limit=50` returns `200` - `GET /api/issues/PAPA-103/comments?after=765d3609-edc6-4d11-a8fe-d466affbe85d&order=desc&limit=50` now returns `200` with 50 comments instead of `500` ## Risks - Moderate UI/perf risk on very large threads because the chat tab now prefetches multiple earlier pages on mount; the cap is intentionally limited to 150 comments to bound that work. - Low API risk because the server fix only changes the cursor predicate construction for anchor-based comment pagination, but any mistake there would affect older-comment paging order. > I checked `ROADMAP.md` before opening this PR and this bug fix does not duplicate planned core work. ## Model Used - OpenAI Codex coding agent in the Paperclip local adapter environment. The exact backend model ID and context window were not exposed in-session. Tool-assisted workflow included shell execution, git/GitHub CLI, local test execution, and targeted code edits. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [ ] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge
817 lines
24 KiB
TypeScript
817 lines
24 KiB
TypeScript
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import type { Issue } from "@paperclipai/shared";
|
|
import {
|
|
applyLocalQueuedIssueCommentState,
|
|
applyOptimisticIssueFieldUpdate,
|
|
applyOptimisticIssueFieldUpdateToCollection,
|
|
applyOptimisticIssueCommentUpdate,
|
|
createOptimisticIssueComment,
|
|
flattenIssueCommentPages,
|
|
getNextIssueCommentPageParam,
|
|
isQueuedIssueComment,
|
|
matchesIssueRef,
|
|
mergeIssueComments,
|
|
removeIssueCommentFromPages,
|
|
shouldAutoloadOlderIssueComments,
|
|
takeOptimisticIssueComment,
|
|
upsertIssueComment,
|
|
upsertIssueCommentInPages,
|
|
} from "./optimistic-issue-comments";
|
|
|
|
describe("optimistic issue comments", () => {
|
|
afterEach(() => {
|
|
vi.unstubAllGlobals();
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
it("creates a pending optimistic comment for the current user", () => {
|
|
const comment = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Working on it",
|
|
authorUserId: "board-1",
|
|
});
|
|
|
|
expect(comment.id).toMatch(/^optimistic-/);
|
|
expect(comment.clientId).toBe(comment.id);
|
|
expect(comment.clientStatus).toBe("pending");
|
|
expect(comment.authorUserId).toBe("board-1");
|
|
expect(comment.authorAgentId).toBeNull();
|
|
});
|
|
|
|
it("falls back when crypto.randomUUID is unavailable", () => {
|
|
vi.stubGlobal("crypto", {});
|
|
const nowSpy = vi.spyOn(Date, "now").mockReturnValue(1_746_000_000_000);
|
|
const mathSpy = vi.spyOn(Math, "random").mockReturnValue(0.123456789);
|
|
|
|
const comment = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Working on it",
|
|
authorUserId: "board-1",
|
|
});
|
|
|
|
expect(comment.id).toBe("optimistic-1746000000000-4fzzzxjy");
|
|
expect(comment.clientId).toBe(comment.id);
|
|
|
|
nowSpy.mockRestore();
|
|
mathSpy.mockRestore();
|
|
});
|
|
|
|
it("supports queued optimistic comments for active-run follow-ups", () => {
|
|
const comment = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Queue this",
|
|
authorUserId: "board-1",
|
|
clientStatus: "queued",
|
|
queueTargetRunId: "run-1",
|
|
});
|
|
|
|
expect(comment.clientStatus).toBe("queued");
|
|
expect(comment.queueTargetRunId).toBe("run-1");
|
|
});
|
|
|
|
it("merges optimistic comments into the server thread in chronological order", () => {
|
|
const merged = mergeIssueComments(
|
|
[
|
|
{
|
|
id: "comment-2",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Second",
|
|
createdAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
},
|
|
],
|
|
[
|
|
{
|
|
id: "optimistic-1",
|
|
clientId: "optimistic-1",
|
|
clientStatus: "pending",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "First",
|
|
createdAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
},
|
|
],
|
|
);
|
|
|
|
expect(merged.map((comment) => comment.id)).toEqual(["optimistic-1", "comment-2"]);
|
|
});
|
|
|
|
it("can take one optimistic queued comment back out of the queue", () => {
|
|
const first = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "First",
|
|
authorUserId: "board-1",
|
|
clientStatus: "queued",
|
|
queueTargetRunId: "run-1",
|
|
});
|
|
const second = createOptimisticIssueComment({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
body: "Second",
|
|
authorUserId: "board-1",
|
|
clientStatus: "queued",
|
|
queueTargetRunId: "run-1",
|
|
});
|
|
|
|
const result = takeOptimisticIssueComment([first, second], first.clientId);
|
|
|
|
expect(result.comment?.body).toBe("First");
|
|
expect(result.comments.map((comment) => comment.clientId)).toEqual([second.clientId]);
|
|
});
|
|
|
|
it("upserts confirmed comments without creating duplicates", () => {
|
|
const next = upsertIssueComment(
|
|
[
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Original",
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
],
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Updated",
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:05.000Z"),
|
|
},
|
|
);
|
|
|
|
expect(next).toHaveLength(1);
|
|
expect(next[0]?.body).toBe("Updated");
|
|
});
|
|
|
|
it("flattens paged comments into one chronological thread", () => {
|
|
const flattened = flattenIssueCommentPages([
|
|
[
|
|
{
|
|
id: "comment-3",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Newest",
|
|
createdAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
},
|
|
],
|
|
[
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Oldest",
|
|
createdAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
},
|
|
{
|
|
id: "comment-2",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Middle",
|
|
createdAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
},
|
|
],
|
|
]);
|
|
|
|
expect(flattened.map((comment) => comment.id)).toEqual(["comment-1", "comment-2", "comment-3"]);
|
|
});
|
|
|
|
it("returns no next page param when the last page is missing", () => {
|
|
expect(getNextIssueCommentPageParam(undefined, 50)).toBeUndefined();
|
|
});
|
|
|
|
it("returns the oldest id when the last page is full", () => {
|
|
expect(
|
|
getNextIssueCommentPageParam(
|
|
[
|
|
{
|
|
id: "comment-2",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Second",
|
|
createdAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
},
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "First",
|
|
createdAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
},
|
|
],
|
|
2,
|
|
),
|
|
).toBe("comment-1");
|
|
});
|
|
|
|
it("autoloads older chat comments while the initial thread is still under the threshold", () => {
|
|
expect(
|
|
shouldAutoloadOlderIssueComments({
|
|
activeDetailTab: "chat",
|
|
hasOlderComments: true,
|
|
loadedCommentCount: 50,
|
|
initialPageLoading: false,
|
|
olderPageLoading: false,
|
|
autoLoadLimit: 150,
|
|
}),
|
|
).toBe(true);
|
|
});
|
|
|
|
it("does not autoload older comments outside the chat tab", () => {
|
|
expect(
|
|
shouldAutoloadOlderIssueComments({
|
|
activeDetailTab: "activity",
|
|
hasOlderComments: true,
|
|
loadedCommentCount: 50,
|
|
initialPageLoading: false,
|
|
olderPageLoading: false,
|
|
autoLoadLimit: 150,
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("stops autoloading once the initial comment window reaches the cap", () => {
|
|
expect(
|
|
shouldAutoloadOlderIssueComments({
|
|
activeDetailTab: "chat",
|
|
hasOlderComments: true,
|
|
loadedCommentCount: 150,
|
|
initialPageLoading: false,
|
|
olderPageLoading: false,
|
|
autoLoadLimit: 150,
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("upserts paged comments without dropping older pages", () => {
|
|
const nextPages = upsertIssueCommentInPages(
|
|
[
|
|
[
|
|
{
|
|
id: "comment-3",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Newest",
|
|
createdAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
},
|
|
],
|
|
[
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Oldest",
|
|
createdAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
},
|
|
],
|
|
],
|
|
{
|
|
id: "comment-4",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Brand new",
|
|
createdAt: new Date("2026-03-28T14:00:04.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:04.000Z"),
|
|
},
|
|
);
|
|
|
|
expect(nextPages[0]?.map((comment) => comment.id)).toEqual(["comment-4", "comment-3"]);
|
|
expect(nextPages[1]?.map((comment) => comment.id)).toEqual(["comment-1"]);
|
|
});
|
|
|
|
it("removes a confirmed queued comment from paged caches", () => {
|
|
const nextPages = removeIssueCommentFromPages(
|
|
[
|
|
[
|
|
{
|
|
id: "comment-3",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Newest",
|
|
createdAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:03.000Z"),
|
|
},
|
|
],
|
|
[
|
|
{
|
|
id: "comment-2",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Middle",
|
|
createdAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:02.000Z"),
|
|
},
|
|
{
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Oldest",
|
|
createdAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:01.000Z"),
|
|
},
|
|
],
|
|
],
|
|
"comment-2",
|
|
);
|
|
|
|
expect(nextPages).toHaveLength(2);
|
|
expect(nextPages[0]?.map((comment) => comment.id)).toEqual(["comment-3"]);
|
|
expect(nextPages[1]?.map((comment) => comment.id)).toEqual(["comment-1"]);
|
|
});
|
|
|
|
it("applies optimistic reopen and reassignment updates to the issue cache", () => {
|
|
const next = applyOptimisticIssueCommentUpdate(
|
|
{
|
|
id: "issue-1",
|
|
companyId: "company-1",
|
|
projectId: null,
|
|
projectWorkspaceId: null,
|
|
goalId: null,
|
|
parentId: null,
|
|
title: "Fix comment flow",
|
|
description: null,
|
|
status: "done",
|
|
priority: "medium",
|
|
assigneeAgentId: "agent-1",
|
|
assigneeUserId: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: "board-1",
|
|
issueNumber: 1,
|
|
identifier: "PAP-1",
|
|
originKind: "manual",
|
|
originId: null,
|
|
originRunId: null,
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
{
|
|
reopen: true,
|
|
reassignment: {
|
|
assigneeAgentId: null,
|
|
assigneeUserId: "board-2",
|
|
},
|
|
},
|
|
);
|
|
|
|
expect(next?.status).toBe("todo");
|
|
expect(next?.assigneeAgentId).toBeNull();
|
|
expect(next?.assigneeUserId).toBe("board-2");
|
|
});
|
|
|
|
it("applies optimistic field updates for issue property edits", () => {
|
|
const next = applyOptimisticIssueFieldUpdate(
|
|
{
|
|
id: "issue-1",
|
|
companyId: "company-1",
|
|
projectId: "project-1",
|
|
projectWorkspaceId: "workspace-1",
|
|
goalId: null,
|
|
parentId: null,
|
|
ancestors: [
|
|
{
|
|
id: "issue-9",
|
|
identifier: "PAP-9",
|
|
title: "Old parent",
|
|
description: null,
|
|
status: "todo",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
projectId: null,
|
|
goalId: null,
|
|
project: null,
|
|
goal: null,
|
|
},
|
|
],
|
|
title: "Fix property pane",
|
|
description: null,
|
|
status: "todo",
|
|
priority: "medium",
|
|
assigneeAgentId: "agent-1",
|
|
assigneeUserId: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: "board-1",
|
|
issueNumber: 1,
|
|
identifier: "PAP-1",
|
|
originKind: "manual",
|
|
originId: null,
|
|
originRunId: null,
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: "exec-1",
|
|
executionWorkspacePreference: "shared_workspace",
|
|
executionWorkspaceSettings: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
labelIds: ["label-1", "label-2"],
|
|
labels: [
|
|
{
|
|
id: "label-1",
|
|
companyId: "company-1",
|
|
name: "One",
|
|
color: "#111111",
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
{
|
|
id: "label-2",
|
|
companyId: "company-1",
|
|
name: "Two",
|
|
color: "#222222",
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
],
|
|
blockedBy: [
|
|
{
|
|
id: "issue-2",
|
|
identifier: "PAP-2",
|
|
title: "First blocker",
|
|
status: "todo",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
},
|
|
{
|
|
id: "issue-3",
|
|
identifier: "PAP-3",
|
|
title: "Second blocker",
|
|
status: "todo",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
},
|
|
],
|
|
blocks: [],
|
|
project: {
|
|
id: "project-1",
|
|
companyId: "company-1",
|
|
urlKey: "project-one",
|
|
goalId: null,
|
|
goalIds: [],
|
|
goals: [],
|
|
name: "Project one",
|
|
description: null,
|
|
status: "in_progress",
|
|
leadAgentId: null,
|
|
targetDate: null,
|
|
color: null,
|
|
env: null,
|
|
pauseReason: null,
|
|
pausedAt: null,
|
|
executionWorkspacePolicy: null,
|
|
codebase: {
|
|
workspaceId: null,
|
|
repoUrl: null,
|
|
repoRef: null,
|
|
defaultRef: null,
|
|
repoName: null,
|
|
localFolder: null,
|
|
managedFolder: "/tmp/paperclip",
|
|
effectiveLocalFolder: "/tmp/paperclip",
|
|
origin: "local_folder",
|
|
},
|
|
workspaces: [],
|
|
primaryWorkspace: null,
|
|
archivedAt: null,
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
currentExecutionWorkspace: {
|
|
id: "exec-1",
|
|
companyId: "company-1",
|
|
projectId: "project-1",
|
|
projectWorkspaceId: null,
|
|
sourceIssueId: "issue-1",
|
|
mode: "shared_workspace",
|
|
strategyType: "project_primary",
|
|
branchName: null,
|
|
status: "active",
|
|
name: "Execution workspace",
|
|
cwd: "/tmp/paperclip",
|
|
repoUrl: null,
|
|
baseRef: null,
|
|
providerType: "local_fs",
|
|
providerRef: null,
|
|
derivedFromExecutionWorkspaceId: null,
|
|
lastUsedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
cleanupEligibleAt: null,
|
|
cleanupReason: null,
|
|
config: null,
|
|
metadata: null,
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
openedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
closedAt: null,
|
|
},
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
{
|
|
status: "in_review",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: "board-2",
|
|
labelIds: ["label-2"],
|
|
blockedByIssueIds: ["issue-3"],
|
|
parentId: "issue-4",
|
|
projectId: "project-2",
|
|
executionWorkspaceId: "exec-2",
|
|
},
|
|
);
|
|
|
|
expect(next?.status).toBe("in_review");
|
|
expect(next?.assigneeAgentId).toBeNull();
|
|
expect(next?.assigneeUserId).toBe("board-2");
|
|
expect(next?.labelIds).toEqual(["label-2"]);
|
|
expect(next?.labels?.map((label) => label.id)).toEqual(["label-2"]);
|
|
expect(next?.blockedBy?.map((relation) => relation.id)).toEqual(["issue-3"]);
|
|
expect(next?.parentId).toBe("issue-4");
|
|
expect(next?.ancestors).toBeUndefined();
|
|
expect(next?.projectId).toBe("project-2");
|
|
expect(next?.project).toBeNull();
|
|
expect(next?.executionWorkspaceId).toBe("exec-2");
|
|
expect(next?.currentExecutionWorkspace).toBeNull();
|
|
});
|
|
|
|
it("matches issues by either uuid or identifier reference", () => {
|
|
expect(matchesIssueRef({ id: "issue-1", identifier: "PAP-1" } as const, ["issue-1"])).toBe(true);
|
|
expect(matchesIssueRef({ id: "issue-1", identifier: "PAP-1" } as const, ["PAP-1"])).toBe(true);
|
|
expect(matchesIssueRef({ id: "issue-1", identifier: "PAP-1" } as const, ["issue-2", "PAP-2"])).toBe(false);
|
|
});
|
|
|
|
it("applies optimistic field updates across cached issue collections", () => {
|
|
const issues: Issue[] = [
|
|
{
|
|
id: "issue-1",
|
|
companyId: "company-1",
|
|
projectId: null,
|
|
projectWorkspaceId: null,
|
|
goalId: null,
|
|
parentId: null,
|
|
title: "Fix property pane",
|
|
description: null,
|
|
status: "todo",
|
|
priority: "medium",
|
|
assigneeAgentId: "agent-1",
|
|
assigneeUserId: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: "board-1",
|
|
issueNumber: 1,
|
|
identifier: "PAP-1",
|
|
originKind: "manual",
|
|
originId: null,
|
|
originRunId: null,
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
labelIds: [],
|
|
labels: [],
|
|
blockedBy: [],
|
|
blocks: [],
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
{
|
|
id: "issue-2",
|
|
companyId: "company-1",
|
|
projectId: null,
|
|
projectWorkspaceId: null,
|
|
goalId: null,
|
|
parentId: null,
|
|
title: "Leave me alone",
|
|
description: null,
|
|
status: "todo",
|
|
priority: "medium",
|
|
assigneeAgentId: "agent-2",
|
|
assigneeUserId: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: "board-1",
|
|
issueNumber: 2,
|
|
identifier: "PAP-2",
|
|
originKind: "manual",
|
|
originId: null,
|
|
originRunId: null,
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
labelIds: [],
|
|
labels: [],
|
|
blockedBy: [],
|
|
blocks: [],
|
|
createdAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-28T14:00:00.000Z"),
|
|
},
|
|
];
|
|
|
|
const next = applyOptimisticIssueFieldUpdateToCollection(issues, ["PAP-1"], { assigneeAgentId: "agent-9" });
|
|
|
|
expect(next?.[0]?.assigneeAgentId).toBe("agent-9");
|
|
expect(next?.[1]?.assigneeAgentId).toBe("agent-2");
|
|
});
|
|
|
|
it("treats comments without a run id as queued when they arrive during an active run", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
runId: null,
|
|
}),
|
|
).toBe(true);
|
|
});
|
|
|
|
it("does not mark comments with an associated run as queued", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
runId: "run-1",
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("does not mark interrupt comments as queued", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
interruptedRunId: "run-1",
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("does not mark comments from the active run agent as queued", () => {
|
|
expect(
|
|
isQueuedIssueComment({
|
|
comment: {
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
authorAgentId: "agent-1",
|
|
},
|
|
activeRunStartedAt: new Date("2026-03-28T16:20:00.000Z"),
|
|
activeRunAgentId: "agent-1",
|
|
runId: null,
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("keeps a confirmed queued comment queued while the target run is still live", () => {
|
|
const comment = {
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Follow up after the active run",
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
updatedAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
};
|
|
|
|
const result = applyLocalQueuedIssueCommentState(comment, {
|
|
queuedTargetRunId: "run-1",
|
|
targetRunIsLive: true,
|
|
runningRunId: "run-1",
|
|
});
|
|
|
|
expect(result).toMatchObject({
|
|
id: "comment-1",
|
|
clientStatus: "queued",
|
|
queueState: "queued",
|
|
queueTargetRunId: "run-1",
|
|
});
|
|
});
|
|
|
|
it("does not keep local queued state after the target run is no longer live", () => {
|
|
const comment = {
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Follow up after the active run",
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
updatedAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
};
|
|
|
|
const result = applyLocalQueuedIssueCommentState(comment, {
|
|
queuedTargetRunId: "run-1",
|
|
targetRunIsLive: false,
|
|
runningRunId: null,
|
|
});
|
|
|
|
expect(result).toBe(comment);
|
|
});
|
|
|
|
it("does not keep local queued state when a different run is live", () => {
|
|
const comment = {
|
|
id: "comment-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
authorAgentId: null,
|
|
authorUserId: "board-1",
|
|
body: "Follow up after the active run",
|
|
createdAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
updatedAt: new Date("2026-03-28T16:20:05.000Z"),
|
|
};
|
|
|
|
const result = applyLocalQueuedIssueCommentState(comment, {
|
|
queuedTargetRunId: "run-1",
|
|
targetRunIsLive: true,
|
|
runningRunId: "run-2",
|
|
});
|
|
|
|
expect(result).toBe(comment);
|
|
});
|
|
});
|