d734bd43d1
## Thinking Path > - Paperclip is the control plane for autonomous AI companies, so agent work needs visible ownership, recovery, and operator controls. > - This local branch had accumulated several related control-plane reliability and operator-experience fixes across recovery actions, watchdog folding, model-profile defaults, mentions, markdown editing, plugin launchers, and small UI polish. > - The branch needed to be converted into a PR against the current `origin/master` without losing dirty work or including lockfile/workflow churn. > - The safest standalone shape is a single rollup PR because the recovery/server/UI files overlap heavily across the local commits and splitting would create avoidable conflicts. > - This pull request replays the local branch onto latest `origin/master`, preserves the uncommitted work as logical commits, and adds a Zod 4 validator compatibility fix found during verification. > - The benefit is that the May 17 local branch can be reviewed and merged as one coherent, conflict-free branch under the 100-file Greptile limit. ## What Changed - Rebased the local May 17 branch work onto current `origin/master` in a dedicated worktree. - Preserved and committed previously dirty changes for recovery retry handling, plugin/sidebar launcher polish, and `.herenow` ignores. - Added recovery-action behavior for returning source issues to `todo` when retrying source-scoped recovery. - Included the existing local recovery/liveness/watchdog fold, Codex cheap-profile, markdown/mention, duplicate-agent, and UI polish commits from the branch. - Normalized shared validator `z.record(...)` schemas to explicit string-key records for Zod 4 compatibility. - Confirmed the PR has no `pnpm-lock.yaml` or `.github/workflows/*` changes and stays below the 100-file Greptile limit. ## Verification - `pnpm install --frozen-lockfile --ignore-scripts` - `npm run install` in `node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3` to build the local native sqlite3 binding after installing with scripts disabled - `pnpm exec vitest run packages/shared/src/validators/issue.test.ts packages/shared/src/project-mentions.test.ts packages/adapter-utils/src/server-utils.test.ts server/src/__tests__/heartbeat-model-profile.test.ts server/src/__tests__/issue-recovery-actions.test.ts server/src/__tests__/issue-agent-mutation-ownership-routes.test.ts server/src/__tests__/heartbeat-active-run-output-watchdog.test.ts server/src/__tests__/plugin-local-folders.test.ts ui/src/components/IssueRecoveryActionCard.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/SidebarAccountMenu.test.tsx ui/src/components/IssueProperties.test.tsx ui/src/components/MarkdownEditor.test.tsx ui/src/components/MarkdownBody.test.tsx ui/src/lib/duplicate-agent-payload.test.ts ui/src/pages/Routines.test.tsx` - First pass: 13 files passed with 201 passing tests; 3 server files failed before sqlite3 native binding was built. - After rebuilding sqlite3: `server/src/__tests__/heartbeat-model-profile.test.ts`, `server/src/__tests__/issue-recovery-actions.test.ts`, and `server/src/__tests__/heartbeat-active-run-output-watchdog.test.ts` passed/loaded; embedded Postgres tests were skipped by the local host guard. - `pnpm --filter @paperclipai/shared typecheck` - `pnpm --filter @paperclipai/adapter-utils typecheck` - `pnpm --filter @paperclipai/server typecheck` - `pnpm --filter @paperclipai/ui typecheck` ## Risks - Medium risk: this is a broad rollup PR across recovery semantics, server tests, shared validators, and UI surfaces. - Some embedded Postgres tests skipped locally due the host guard, so CI should provide the stronger database-backed signal. - UI changes were covered by component tests, but no browser screenshot was captured in this PR creation pass. - This branch may overlap with existing recovery/liveness PR work; merge this PR independently or restack/close overlapping branches rather than merging duplicate implementations together. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent, tool-enabled local repository and GitHub workflow, medium reasoning effort. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
148 lines
3.9 KiB
TypeScript
148 lines
3.9 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import {
|
|
listAdapterModelProfiles,
|
|
type AdapterModelProfileDefinition,
|
|
} from "../adapters/index.js";
|
|
import {
|
|
mergeModelProfileAdapterConfig,
|
|
normalizeModelProfileWakeContext,
|
|
resolveModelProfileApplication,
|
|
} from "../services/heartbeat.ts";
|
|
|
|
const cheapProfile: AdapterModelProfileDefinition = {
|
|
key: "cheap",
|
|
label: "Cheap",
|
|
adapterConfig: {
|
|
model: "adapter-cheap",
|
|
modelReasoningEffort: "low",
|
|
},
|
|
source: "adapter_default",
|
|
};
|
|
|
|
describe("heartbeat model profile application", () => {
|
|
it("uses the Codex local adapter cheap default when the agent has no runtime override", async () => {
|
|
const modelProfile = resolveModelProfileApplication({
|
|
adapterModelProfiles: await listAdapterModelProfiles("codex_local"),
|
|
agentRuntimeConfig: {},
|
|
issueModelProfile: "cheap",
|
|
contextSnapshot: {},
|
|
});
|
|
|
|
expect(modelProfile).toMatchObject({
|
|
requested: "cheap",
|
|
requestedBy: "issue_override",
|
|
applied: "cheap",
|
|
configSource: "adapter_default",
|
|
fallbackReason: null,
|
|
adapterConfig: {
|
|
model: "gpt-5.3-codex-spark",
|
|
modelReasoningEffort: "high",
|
|
},
|
|
});
|
|
});
|
|
|
|
it("applies cheap profile patches before explicit issue adapter config overrides", () => {
|
|
const modelProfile = resolveModelProfileApplication({
|
|
adapterModelProfiles: [cheapProfile],
|
|
agentRuntimeConfig: {},
|
|
issueModelProfile: "cheap",
|
|
contextSnapshot: {},
|
|
});
|
|
|
|
const merged = mergeModelProfileAdapterConfig({
|
|
baseConfig: {
|
|
model: "primary",
|
|
modelReasoningEffort: "high",
|
|
approvalPolicy: "strict",
|
|
},
|
|
modelProfile,
|
|
issueAdapterConfig: {
|
|
model: "issue-explicit",
|
|
},
|
|
});
|
|
|
|
expect(modelProfile).toMatchObject({
|
|
requested: "cheap",
|
|
requestedBy: "issue_override",
|
|
applied: "cheap",
|
|
configSource: "adapter_default",
|
|
fallbackReason: null,
|
|
});
|
|
expect(merged).toEqual({
|
|
model: "issue-explicit",
|
|
modelReasoningEffort: "low",
|
|
approvalPolicy: "strict",
|
|
});
|
|
});
|
|
|
|
it("lets agent runtime profile config customize adapter defaults", () => {
|
|
const modelProfile = resolveModelProfileApplication({
|
|
adapterModelProfiles: [cheapProfile],
|
|
agentRuntimeConfig: {
|
|
modelProfiles: {
|
|
cheap: {
|
|
adapterConfig: {
|
|
model: "agent-cheap",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
issueModelProfile: null,
|
|
contextSnapshot: { modelProfile: "cheap" },
|
|
});
|
|
|
|
expect(modelProfile).toMatchObject({
|
|
requested: "cheap",
|
|
requestedBy: "wake_context",
|
|
applied: "cheap",
|
|
configSource: "agent_runtime",
|
|
adapterConfig: {
|
|
model: "agent-cheap",
|
|
modelReasoningEffort: "low",
|
|
},
|
|
});
|
|
});
|
|
|
|
it("falls back to the primary config when the adapter does not support the requested profile", () => {
|
|
const modelProfile = resolveModelProfileApplication({
|
|
adapterModelProfiles: [],
|
|
agentRuntimeConfig: {
|
|
modelProfiles: {
|
|
cheap: {
|
|
adapterConfig: {
|
|
model: "agent-cheap",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
issueModelProfile: null,
|
|
contextSnapshot: { modelProfile: "cheap" },
|
|
});
|
|
|
|
const merged = mergeModelProfileAdapterConfig({
|
|
baseConfig: {
|
|
model: "primary",
|
|
},
|
|
modelProfile,
|
|
issueAdapterConfig: null,
|
|
});
|
|
|
|
expect(modelProfile).toMatchObject({
|
|
requested: "cheap",
|
|
applied: null,
|
|
fallbackReason: "adapter_profile_not_supported",
|
|
adapterConfig: null,
|
|
});
|
|
expect(merged).toEqual({ model: "primary" });
|
|
});
|
|
|
|
it("normalizes a wake payload model profile into run context", () => {
|
|
const contextSnapshot = normalizeModelProfileWakeContext({
|
|
contextSnapshot: {},
|
|
payload: { modelProfile: "cheap" },
|
|
});
|
|
|
|
expect(contextSnapshot).toMatchObject({ modelProfile: "cheap" });
|
|
});
|
|
});
|