70b1a9109d
## Thinking Path > - Paperclip is a control plane for AI-agent companies, with the CLI acting as a scriptable operator and agent interface to that control plane. > - The REST API surface has grown across companies, agents, issues, routines, plugins, auth, workspaces, secrets, and operational inspection commands. > - The CLI had drifted from that API surface: some commands were missing, some command shapes differed from docs/reference material, and several edge cases only failed during end-to-end local-source testing. > - The local development runbook requires these tests to be disposable and isolated from a real `~/.paperclip`, `~/.codex`, or `~/.claude` installation. > - This pull request adds broad CLI/API parity coverage, fixes the actionable bugs found during that pass, and records the reproducible test log under `doc/logs`. > - The benefit is a more complete, scriptable CLI surface with regression coverage for the command families exercised by the parity run. ## What Changed - Added or expanded CLI command coverage for access/auth, companies, agents, projects, goals, issues and subresources, routines, plugins, workspaces, activity/run/cost/dashboard inspection, assets, skills, secrets, tokens, prompt/wake flows, and local setup helpers. - Fixed CLI/API parity bugs found during the run, including context profile patching, issue interaction optional payloads, malformed tree-hold errors, environment duplicate handling, configure invalid-section exit codes, worktree pnpm invocation, token agent ID resolution, plugin tool worker lookup, and routine webhook secret cleanup. - Added missing CLI wrappers and route coverage for health/access, invite resolution URL forwarding, join status normalization, secret lifecycle commands, LLM docs routes, available-skill isolation, positive board-claim coverage, and interactive `connect` prompt-flow tests. - Added a schema-backed `/api/openapi.json` route sufficient for CLI parity and `paperclipai openapi --json` smoke coverage. - Added `doc/logs/2026-05-24-cli-api-parity-e2e-log.md` with the detailed living test/bug log and renamed the log directory from `doc/bugs` to `doc/logs`. - Added `doc/plans/2026-05-23-cli-api-parity.md` and the OpenAPI parity reference used during the pass. OpenAPI note: this PR intentionally does not try to subsume `feature/openapi-spec`. The OpenAPI implementation here is schema-backed and better than the earlier route-inventory stub, but `feature/openapi-spec` is the fuller/better OpenAPI branch because it includes exact mounted-route coverage tests and additional current route coverage. That branch should stay as its own PR and can supersede this OpenAPI route implementation. ## Verification Targeted automated checks run: - `pnpm exec vitest run server/src/__tests__/openapi-routes.test.ts` - `pnpm exec vitest run server/src/__tests__/board-claim.test.ts` - `pnpm exec vitest run cli/src/__tests__/connect.test.ts` - `pnpm exec vitest run cli/src/__tests__/agent-lifecycle.test.ts` - `pnpm exec vitest run server/src/__tests__/plugin-database.test.ts` - `pnpm exec vitest run server/src/__tests__/routines-service.test.ts` - `pnpm --dir cli typecheck` - `pnpm --dir server typecheck` Manual/local E2E verification: - Ran the full disposable local-source CLI/API parity pass with isolated `PAPERCLIP_HOME`, `PAPERCLIP_CONFIG`, `PAPERCLIP_CONTEXT`, `PAPERCLIP_AUTH_STORE`, `CODEX_HOME`, and `CLAUDE_HOME` under `tmp/cli-api-parity`. - Verified `DATABASE_URL` and `DATABASE_MIGRATION_URL` stayed unset for the scratch server. - Verified live health and schema-backed OpenAPI responses on non-default port `3197`. - Revoked created board/agent tokens and cleaned up temporary plugins, secrets, non-default environments, and project workspaces. - See `doc/logs/2026-05-24-cli-api-parity-e2e-log.md` for the full command-by-command reproduction log. Not run: - Full `pnpm test`, `pnpm test:run`, or `pnpm build` were not run after the entire branch because the branch is broad and the parity pass used focused test/typecheck verification plus live isolated CLI reruns. ## Risks - This is a broad PR and touches many CLI command modules, so review surface is high. The changes are grouped around one theme, but a split may be easier if maintainers prefer narrower PRs. - The OpenAPI route in this PR is not the final/best OpenAPI implementation. `feature/openapi-spec` has stronger exact-route coverage and should remain the source for the dedicated OpenAPI PR. - The living log is intentionally detailed and large. It is useful for reproducibility but adds documentation weight. - No UI changes are intended; screenshots are not applicable. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent in Codex desktop. Exact served model/context-window identifier was not exposed in the local app. Work used shell/Git/GitHub CLI tooling, local source inspection, targeted test execution, and live isolated Paperclip CLI/API smoke testing. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Devin Foley <devin@devinfoley.com>
178 lines
9.6 KiB
TypeScript
178 lines
9.6 KiB
TypeScript
import { mkdtemp, rm, writeFile } from "node:fs/promises";
|
|
import path from "node:path";
|
|
import { tmpdir } from "node:os";
|
|
import { Command } from "commander";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { registerAdapterCommands } from "../commands/client/adapter.js";
|
|
import { registerAssetCommands } from "../commands/client/asset.js";
|
|
import { registerCompanyCommands, resolveExportOutputPath } from "../commands/client/company.js";
|
|
import { registerSkillCommands } from "../commands/client/skill.js";
|
|
|
|
const COMPANY_ID = "22222222-2222-4222-8222-222222222222";
|
|
const SKILL_ID = "33333333-3333-4333-8333-333333333333";
|
|
const ASSET_ID = "44444444-4444-4444-8444-444444444444";
|
|
|
|
function createProgram(): Command {
|
|
const program = new Command();
|
|
program.exitOverride();
|
|
program.configureOutput({ writeOut: () => {}, writeErr: () => {} });
|
|
registerCompanyCommands(program);
|
|
registerAdapterCommands(program);
|
|
registerAssetCommands(program);
|
|
registerSkillCommands(program);
|
|
return program;
|
|
}
|
|
|
|
async function run(args: string[]): Promise<void> {
|
|
await createProgram().parseAsync([
|
|
...args,
|
|
"--api-base", "http://localhost:3100",
|
|
"--api-key", "board-token",
|
|
], { from: "user" });
|
|
}
|
|
|
|
describe("admin, asset, and skill parity commands", () => {
|
|
let tempDir: string;
|
|
|
|
beforeEach(async () => {
|
|
vi.restoreAllMocks();
|
|
delete process.env.PAPERCLIP_API_KEY;
|
|
delete process.env.PAPERCLIP_API_URL;
|
|
vi.spyOn(console, "log").mockImplementation(() => {});
|
|
vi.spyOn(process.stdout, "write").mockImplementation(() => true);
|
|
tempDir = await mkdtemp(path.join(tmpdir(), "paperclip-cli-parity-"));
|
|
});
|
|
|
|
afterEach(async () => {
|
|
vi.restoreAllMocks();
|
|
await rm(tempDir, { recursive: true, force: true });
|
|
});
|
|
|
|
it("wraps company management and raw portability endpoints", async () => {
|
|
const fetchMock = vi.fn().mockImplementation(() => Promise.resolve(jsonResponse()));
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
|
|
await run(["company", "stats"]);
|
|
await run(["company", "create", "--payload-json", "{}"]);
|
|
await run(["company", "update", COMPANY_ID, "--payload-json", "{}"]);
|
|
await run(["company", "branding:update", COMPANY_ID, "--payload-json", "{}"]);
|
|
await run(["company", "archive", COMPANY_ID]);
|
|
await run(["company", "export:preview", COMPANY_ID, "--payload-json", "{}"]);
|
|
await run(["company", "export:api", COMPANY_ID, "--payload-json", "{}"]);
|
|
await run(["company", "import:preview", COMPANY_ID, "--payload-json", "{}"]);
|
|
await run(["company", "import:apply", COMPANY_ID, "--payload-json", "{}"]);
|
|
|
|
expect(fetchMock.mock.calls.map((call) => [call[1]?.method ?? "GET", call[0]])).toEqual([
|
|
["GET", "http://localhost:3100/api/companies/stats"],
|
|
["POST", "http://localhost:3100/api/companies"],
|
|
["PATCH", `http://localhost:3100/api/companies/${COMPANY_ID}`],
|
|
["PATCH", `http://localhost:3100/api/companies/${COMPANY_ID}/branding`],
|
|
["POST", `http://localhost:3100/api/companies/${COMPANY_ID}/archive`],
|
|
["POST", `http://localhost:3100/api/companies/${COMPANY_ID}/exports/preview`],
|
|
["POST", `http://localhost:3100/api/companies/${COMPANY_ID}/exports`],
|
|
["POST", `http://localhost:3100/api/companies/${COMPANY_ID}/imports/preview`],
|
|
["POST", `http://localhost:3100/api/companies/${COMPANY_ID}/imports/apply`],
|
|
]);
|
|
});
|
|
|
|
it("wraps adapter management and company adapter endpoints", async () => {
|
|
const fetchMock = vi.fn().mockImplementation(() => Promise.resolve(jsonResponse()));
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
|
|
await run(["adapter", "list"]);
|
|
await run(["adapter", "install", "--payload-json", "{\"packageName\":\"adapter\"}"]);
|
|
await run(["adapter", "get", "codex_local"]);
|
|
await run(["adapter", "get", "codex/local"]);
|
|
await run(["adapter", "update", "codex_local", "--payload-json", "{\"disabled\":true}"]);
|
|
await run(["adapter", "override", "codex_local", "--payload-json", "{\"paused\":true}"]);
|
|
await run(["adapter", "reload", "codex_local"]);
|
|
await run(["adapter", "reinstall", "codex_local"]);
|
|
await run(["adapter", "config-schema", "codex_local"]);
|
|
await run(["adapter", "ui-parser", "codex_local"]);
|
|
await run(["adapter", "models", "codex_local", "--company-id", COMPANY_ID, "--refresh", "--environment-id", "env-1"]);
|
|
await run(["adapter", "model-profiles", "codex_local", "--company-id", COMPANY_ID]);
|
|
await run(["adapter", "detect-model", "codex_local", "--company-id", COMPANY_ID]);
|
|
await run(["adapter", "test-environment", "codex_local", "--company-id", COMPANY_ID, "--payload-json", "{}"]);
|
|
await run(["adapter", "delete", "codex_local"]);
|
|
|
|
expect(fetchMock.mock.calls.map((call) => [call[1]?.method ?? "GET", call[0]])).toEqual([
|
|
["GET", "http://localhost:3100/api/adapters"],
|
|
["POST", "http://localhost:3100/api/adapters/install"],
|
|
["GET", "http://localhost:3100/api/adapters/codex_local"],
|
|
["GET", "http://localhost:3100/api/adapters/codex%2Flocal"],
|
|
["PATCH", "http://localhost:3100/api/adapters/codex_local"],
|
|
["PATCH", "http://localhost:3100/api/adapters/codex_local/override"],
|
|
["POST", "http://localhost:3100/api/adapters/codex_local/reload"],
|
|
["POST", "http://localhost:3100/api/adapters/codex_local/reinstall"],
|
|
["GET", "http://localhost:3100/api/adapters/codex_local/config-schema"],
|
|
["GET", "http://localhost:3100/api/adapters/codex_local/ui-parser.js"],
|
|
["GET", `http://localhost:3100/api/companies/${COMPANY_ID}/adapters/codex_local/models?refresh=true&environmentId=env-1`],
|
|
["GET", `http://localhost:3100/api/companies/${COMPANY_ID}/adapters/codex_local/model-profiles`],
|
|
["GET", `http://localhost:3100/api/companies/${COMPANY_ID}/adapters/codex_local/detect-model`],
|
|
["POST", `http://localhost:3100/api/companies/${COMPANY_ID}/adapters/codex_local/test-environment`],
|
|
["DELETE", "http://localhost:3100/api/adapters/codex_local"],
|
|
]);
|
|
});
|
|
|
|
it("wraps asset upload/download endpoints", async () => {
|
|
const imagePath = path.join(tempDir, "logo.png");
|
|
const outputPath = path.join(tempDir, "asset.bin");
|
|
await writeFile(imagePath, Buffer.from("png"));
|
|
const fetchMock = vi
|
|
.fn()
|
|
.mockImplementationOnce(() => Promise.resolve(jsonResponse({ assetId: ASSET_ID }, { status: 201 })))
|
|
.mockImplementationOnce(() => Promise.resolve(jsonResponse({ assetId: ASSET_ID }, { status: 201 })))
|
|
.mockImplementationOnce(() => Promise.resolve(new Response("asset-bytes")));
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
|
|
await run(["asset", "image:upload", "--company-id", COMPANY_ID, "--file", imagePath, "--namespace", "docs", "--alt", "Logo"]);
|
|
await run(["asset", "logo:upload", "--company-id", COMPANY_ID, "--file", imagePath]);
|
|
await run(["asset", "content", ASSET_ID, "--out", outputPath]);
|
|
|
|
expect(fetchMock.mock.calls.map((call) => [call[1]?.method ?? "GET", call[0]])).toEqual([
|
|
["POST", `http://localhost:3100/api/companies/${COMPANY_ID}/assets/images`],
|
|
["POST", `http://localhost:3100/api/companies/${COMPANY_ID}/logo`],
|
|
["GET", `http://localhost:3100/api/assets/${ASSET_ID}/content`],
|
|
]);
|
|
const firstUpload = fetchMock.mock.calls[0]?.[1]?.body as FormData;
|
|
expect((firstUpload.get("file") as File).type).toBe("image/png");
|
|
});
|
|
|
|
it("rejects portable export paths outside the output directory", async () => {
|
|
expect(() => resolveExportOutputPath(tempDir, "../outside.md")).toThrow("outside output directory");
|
|
});
|
|
|
|
it("wraps company skill endpoints", async () => {
|
|
const fetchMock = vi.fn().mockImplementation(() => Promise.resolve(jsonResponse()));
|
|
vi.stubGlobal("fetch", fetchMock);
|
|
|
|
await run(["skill", "list", "--company-id", COMPANY_ID]);
|
|
await run(["skill", "get", SKILL_ID, "--company-id", COMPANY_ID]);
|
|
await run(["skill", "file", SKILL_ID, "--company-id", COMPANY_ID, "--path", "SKILL.md"]);
|
|
await run(["skill", "create", "--company-id", COMPANY_ID, "--payload-json", "{}"]);
|
|
await run(["skill", "file:update", SKILL_ID, "--company-id", COMPANY_ID, "--payload-json", "{}"]);
|
|
await run(["skill", "import", "--company-id", COMPANY_ID, "--payload-json", "{}"]);
|
|
await run(["skill", "scan-projects", "--company-id", COMPANY_ID, "--payload-json", "{}"]);
|
|
await run(["skill", "update-status", SKILL_ID, "--company-id", COMPANY_ID]);
|
|
await run(["skill", "install-update", SKILL_ID, "--company-id", COMPANY_ID]);
|
|
await run(["skill", "delete", SKILL_ID, "--company-id", COMPANY_ID]);
|
|
|
|
expect(fetchMock.mock.calls.map((call) => [call[1]?.method ?? "GET", call[0]])).toEqual([
|
|
["GET", `http://localhost:3100/api/companies/${COMPANY_ID}/skills`],
|
|
["GET", `http://localhost:3100/api/companies/${COMPANY_ID}/skills/${SKILL_ID}`],
|
|
["GET", `http://localhost:3100/api/companies/${COMPANY_ID}/skills/${SKILL_ID}/files?path=SKILL.md`],
|
|
["POST", `http://localhost:3100/api/companies/${COMPANY_ID}/skills`],
|
|
["PATCH", `http://localhost:3100/api/companies/${COMPANY_ID}/skills/${SKILL_ID}/files`],
|
|
["POST", `http://localhost:3100/api/companies/${COMPANY_ID}/skills/import`],
|
|
["POST", `http://localhost:3100/api/companies/${COMPANY_ID}/skills/scan-projects`],
|
|
["GET", `http://localhost:3100/api/companies/${COMPANY_ID}/skills/${SKILL_ID}/update-status`],
|
|
["POST", `http://localhost:3100/api/companies/${COMPANY_ID}/skills/${SKILL_ID}/install-update`],
|
|
["DELETE", `http://localhost:3100/api/companies/${COMPANY_ID}/skills/${SKILL_ID}`],
|
|
]);
|
|
});
|
|
});
|
|
|
|
function jsonResponse(body: unknown = { ok: true }, init: ResponseInit = { status: 200 }): Response {
|
|
return new Response(JSON.stringify(body), init);
|
|
}
|