e400315cbf
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - The issue graph and liveness recovery system decide whether assigned work is executable or parked > - Assigned issues created without an explicit status could silently land in backlog, making parents look blocked with no productive wake path > - The server, shared validators, recovery analysis, and UI all need to agree on that execution semantic > - This pull request makes assigned issue creation default to `todo`, flags assigned backlog blockers, and surfaces the state in the board > - The benefit is that parked assigned work becomes intentional and visible instead of creating silent liveness stalls ## What Changed - Adds contract tests for assigned issue creation defaults. - Defaults assigned issue creation to `todo` when status is omitted while preserving explicit `backlog` parking. - Exposes `resolveCreateIssueStatusDefault` through shared validators. - Teaches liveness/blocker attention paths to distinguish assigned backlog blockers. - Adds UI notices, row/header badges, and issue detail safeguards for assigned backlog blockers. - Adds Storybook fixtures and execution-semantics documentation for the assigned-backlog behavior. ## Verification - `pnpm run preflight:workspace-links && pnpm exec vitest run packages/shared/src/validators/issue.test.ts server/src/__tests__/issue-assigned-backlog-contract-routes.test.ts server/src/__tests__/issue-blocker-attention.test.ts server/src/__tests__/issue-liveness.test.ts server/src/__tests__/heartbeat-issue-liveness-escalation.test.ts ui/src/components/IssueAssignedBacklogNotice.test.tsx ui/src/components/IssueRow.test.tsx` — 50 passed, 23 skipped. - Skipped tests were embedded Postgres suites on this host with the repo skip message: `Postgres init script exited with code null. Please check the logs for extra info. The data directory might already exist.` - Pairwise merge check against the issue-controls PR branch completed without conflicts via `git merge --no-commit --no-ff` in a temporary worktree. - Screenshots for assigned-backlog UI states: [light](docs/pr-screenshots/pr-5428/assigned-backlog-light.png), [dark](docs/pr-screenshots/pr-5428/assigned-backlog-dark.png). - Follow-up checks: `pnpm --filter /ui typecheck`; `pnpm --filter /mcp-server build`; `pnpm --filter /mcp-server test`; `pnpm exec vitest run packages/shared/src/validators/issue.test.ts`; focused UI component tests. - Remote PR checks on head `6300b3c`: policy, verify, serialized server shards 1/4-4/4, Canary Dry Run, e2e, Greptile Review, and Snyk all passed. ## Risks - Medium: changes status defaulting for assigned issue creation when the caller omits status. Explicit `backlog` remains supported, and server/shared tests cover both paths. - Medium: liveness classification changes can affect blocker attention labels; focused service and UI tests cover the new assigned-backlog state. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex coding agent, GPT-5 model family (`gpt-5`), tool-enabled Paperclip heartbeat environment. Context window and internal reasoning mode are not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
116 lines
3.2 KiB
TypeScript
116 lines
3.2 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { act } from "react";
|
|
import { createRoot } from "react-dom/client";
|
|
import { describe, expect, it, vi, beforeEach, afterEach } from "vitest";
|
|
import type { Agent } from "@paperclipai/shared";
|
|
import { IssueAssignedBacklogNotice } from "./IssueAssignedBacklogNotice";
|
|
|
|
(globalThis as unknown as { IS_REACT_ACT_ENVIRONMENT: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
const baseAgent = {
|
|
id: "agent-1",
|
|
companyId: "co-1",
|
|
name: "ClaudeCoder",
|
|
role: "engineer",
|
|
status: "active",
|
|
} as unknown as Agent;
|
|
|
|
let container: HTMLDivElement;
|
|
let root: ReturnType<typeof createRoot>;
|
|
|
|
beforeEach(() => {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
root = createRoot(container);
|
|
});
|
|
|
|
afterEach(() => {
|
|
act(() => {
|
|
root.unmount();
|
|
});
|
|
container.remove();
|
|
});
|
|
|
|
describe("IssueAssignedBacklogNotice", () => {
|
|
it("renders nothing when status is not backlog", () => {
|
|
act(() => {
|
|
root.render(
|
|
<IssueAssignedBacklogNotice
|
|
issueStatus="todo"
|
|
assigneeAgent={baseAgent}
|
|
assigneeUserId={null}
|
|
/>,
|
|
);
|
|
});
|
|
expect(container.querySelector('[data-testid="issue-assigned-backlog-notice"]')).toBeNull();
|
|
});
|
|
|
|
it("renders nothing when there is no assignee", () => {
|
|
act(() => {
|
|
root.render(
|
|
<IssueAssignedBacklogNotice
|
|
issueStatus="backlog"
|
|
assigneeAgent={null}
|
|
assigneeUserId={null}
|
|
/>,
|
|
);
|
|
});
|
|
expect(container.querySelector('[data-testid="issue-assigned-backlog-notice"]')).toBeNull();
|
|
});
|
|
|
|
it("warns when an agent is assigned and the issue is parked in backlog", () => {
|
|
act(() => {
|
|
root.render(
|
|
<IssueAssignedBacklogNotice
|
|
issueStatus="backlog"
|
|
assigneeAgent={baseAgent}
|
|
assigneeUserId={null}
|
|
/>,
|
|
);
|
|
});
|
|
const notice = container.querySelector('[data-testid="issue-assigned-backlog-notice"]');
|
|
expect(notice).not.toBeNull();
|
|
expect(notice?.textContent).toContain("Parked");
|
|
expect(notice?.textContent).toContain("ClaudeCoder");
|
|
});
|
|
|
|
it("calls onResume when the resume button is clicked", () => {
|
|
const onResume = vi.fn();
|
|
act(() => {
|
|
root.render(
|
|
<IssueAssignedBacklogNotice
|
|
issueStatus="backlog"
|
|
assigneeAgent={baseAgent}
|
|
assigneeUserId={null}
|
|
onResume={onResume}
|
|
/>,
|
|
);
|
|
});
|
|
const button = container.querySelector('[data-testid="issue-assigned-backlog-resume"]') as HTMLButtonElement | null;
|
|
expect(button).not.toBeNull();
|
|
act(() => {
|
|
button?.click();
|
|
});
|
|
expect(onResume).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("disables the resume button while resuming", () => {
|
|
act(() => {
|
|
root.render(
|
|
<IssueAssignedBacklogNotice
|
|
issueStatus="backlog"
|
|
assigneeAgent={baseAgent}
|
|
assigneeUserId={null}
|
|
onResume={() => undefined}
|
|
resuming
|
|
/>,
|
|
);
|
|
});
|
|
const button = container.querySelector('[data-testid="issue-assigned-backlog-resume"]') as HTMLButtonElement | null;
|
|
expect(button).not.toBeNull();
|
|
expect(button?.disabled).toBe(true);
|
|
expect(button?.textContent).toContain("Resuming");
|
|
});
|
|
});
|