Files
paperclip/packages/mcp-server/src/tools.test.ts
T
Dotta 4d5322c821 [codex] Add checkbox confirmation issue interactions (#7649)
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - Agent work is coordinated through issues, comments, interactions,
and approval-style handoffs.
> - Existing issue-thread interactions could ask questions, suggest
tasks, and request confirmation, but they did not support a structured
checkbox confirmation payload for choosing one or more options.
> - That gap made board/user confirmations harder to validate
consistently across API callers, plugin helpers, CLI tooling, and the
UI.
> - This pull request adds the shared checkbox confirmation contract,
server handling, client helpers, and issue-thread UI needed to render
and submit structured selections.
> - The benefit is that agents can request bounded multi-select
confirmations in the same audited issue-thread flow as other Paperclip
interactions.

## Linked Issues or Issue Description

- No public GitHub issue found for this exact branch. Internal Paperclip
issue: PAP-10415 / PAP-10441 requested creating this PR for the checkbox
confirmation issue-thread UI component work.
- GitHub duplicate search performed for checkbox confirmation /
issue-thread interaction PRs; no matching open PR was found.
- Related issue search result `#7497` was unrelated company file cleanup
work, so it is not linked as a related issue.

## What Changed

- Added shared types, validators, constants, and tests for
`request_checkbox_confirmation` interactions.
- Extended server issue-thread interaction service and routes for
checkbox confirmation creation, validation, expiration, and response
handling.
- Added CLI, MCP, and plugin SDK helper coverage so external callers can
create the new interaction shape consistently.
- Updated the issue-thread interaction UI to render checkbox
confirmations with min/max bounds, selection summaries, stale-target
states, and accept/decline flows.
- Documented the checkbox confirmation interaction contract in the
Paperclip skill/API reference.

## Verification

- Rebased cleanly on `paperclipai/paperclip` `master` fetched into
`public-gh/master` at `a4fa0eaf5`.
- Confirmed the PR diff does not include `pnpm-lock.yaml` or
`.github/workflows` changes.
- Ran focused tests with `NODE_ENV=test`:

```sh
NODE_ENV=test pnpm run preflight:workspace-links
NODE_ENV=test pnpm exec vitest run packages/shared/src/issue-thread-interactions.test.ts server/src/__tests__/issue-thread-interaction-routes.test.ts server/src/__tests__/issue-thread-interactions-service.test.ts ui/src/components/IssueThreadInteractionCard.test.tsx ui/src/lib/issue-thread-interactions.test.ts cli/src/__tests__/issue-subresources.test.ts cli/src/__tests__/project-goal.test.ts packages/mcp-server/src/tools.test.ts packages/plugins/sdk/tests/testing-actions.test.ts
```

Result: 8 test files passed, 78 tests passed.
- CI on latest head `63b9e55` is green.
- Greptile Review passed on latest head; GraphQL review-thread check
shows all Greptile threads resolved.

## Risks

- Medium surface area because the interaction contract touches shared
validators, server routes/services, UI rendering, CLI, MCP, plugin SDK
helpers, and docs.
- No database migrations are included.
- `pnpm-lock.yaml` is intentionally excluded per repository lockfile
policy.
- UI screenshots are not attached because the task explicitly requested
not to add design screenshots or images unless they were part of the
work; component tests cover the new rendering and interaction states.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.

## Model Used

- OpenAI Codex coding agent based on GPT-5, with repository file access,
shell command execution, git/GitHub CLI tooling, and Paperclip
control-plane API access. Exact hosted model ID/context-window metadata
is not exposed inside this runtime.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-06-06 08:48:43 -05:00

401 lines
13 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from "vitest";
import { PaperclipApiClient } from "./client.js";
import { createToolDefinitions } from "./tools.js";
function makeClient() {
return new PaperclipApiClient({
apiUrl: "http://localhost:3100/api",
apiKey: "token-123",
companyId: "11111111-1111-1111-1111-111111111111",
agentId: "22222222-2222-2222-2222-222222222222",
runId: "33333333-3333-3333-3333-333333333333",
});
}
function getTool(name: string) {
const tool = createToolDefinitions(makeClient()).find((candidate) => candidate.name === name);
if (!tool) throw new Error(`Missing tool ${name}`);
return tool;
}
function mockJsonResponse(body: unknown, status = 200) {
return new Response(JSON.stringify(body), {
status,
headers: { "Content-Type": "application/json" },
});
}
describe("paperclip MCP tools", () => {
beforeEach(() => {
vi.restoreAllMocks();
});
it("adds auth headers and run id to mutating requests", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse({ ok: true }),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipUpdateIssue");
await tool.execute({
issueId: "PAP-1135",
status: "done",
});
expect(fetchMock).toHaveBeenCalledTimes(1);
const [url, init] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(String(url)).toBe("http://localhost:3100/api/issues/PAP-1135");
expect(init.method).toBe("PATCH");
expect((init.headers as Record<string, string>)["Authorization"]).toBe("Bearer token-123");
expect((init.headers as Record<string, string>)["X-Paperclip-Run-Id"]).toBe(
"33333333-3333-3333-3333-333333333333",
);
});
it("uses default company id for company-scoped list tools", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse([{ id: "issue-1" }]),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipListIssues");
const response = await tool.execute({});
expect(fetchMock).toHaveBeenCalledTimes(1);
const [url] = fetchMock.mock.calls[0] as [string];
expect(String(url)).toBe(
"http://localhost:3100/api/companies/11111111-1111-1111-1111-111111111111/issues",
);
expect(response.content[0]?.text).toContain("issue-1");
});
it("uses default agent id for checkout requests", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse({ id: "PAP-1135", status: "in_progress" }),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipCheckoutIssue");
await tool.execute({
issueId: "PAP-1135",
});
const [, init] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(JSON.parse(String(init.body))).toEqual({
agentId: "22222222-2222-2222-2222-222222222222",
expectedStatuses: ["todo", "backlog", "blocked"],
});
});
it("allows create issue requests to omit status so the API applies assignee defaults", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse({ id: "issue-1", status: "todo" }),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipCreateIssue");
await tool.execute({
title: "Assigned follow-up",
assigneeAgentId: "22222222-2222-2222-2222-222222222222",
});
const [url, init] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(String(url)).toBe(
"http://localhost:3100/api/companies/11111111-1111-1111-1111-111111111111/issues",
);
expect(init.method).toBe("POST");
expect(JSON.parse(String(init.body))).toEqual({
title: "Assigned follow-up",
workMode: "standard",
priority: "medium",
assigneeAgentId: "22222222-2222-2222-2222-222222222222",
requestDepth: 0,
});
});
it("defaults issue document format to markdown", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse({ key: "plan", latestRevisionNumber: 2 }),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipUpsertIssueDocument");
await tool.execute({
issueId: "PAP-1135",
key: "plan",
body: "# Updated",
});
const [, init] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(JSON.parse(String(init.body))).toEqual({
format: "markdown",
body: "# Updated",
});
});
it("controls issue workspace services through the current execution workspace", async () => {
const fetchMock = vi.fn()
.mockResolvedValueOnce(mockJsonResponse({
currentExecutionWorkspace: {
id: "44444444-4444-4444-8444-444444444444",
runtimeServices: [],
},
}))
.mockResolvedValueOnce(mockJsonResponse({
operation: { id: "operation-1" },
workspace: {
id: "44444444-4444-4444-8444-444444444444",
runtimeServices: [
{
id: "55555555-5555-4555-8555-555555555555",
serviceName: "web",
status: "running",
url: "http://127.0.0.1:5173",
},
],
},
}));
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipControlIssueWorkspaceServices");
await tool.execute({
issueId: "PAP-1135",
action: "restart",
workspaceCommandId: "web",
});
expect(fetchMock).toHaveBeenCalledTimes(2);
const [lookupUrl, lookupInit] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(String(lookupUrl)).toBe("http://localhost:3100/api/issues/PAP-1135/heartbeat-context");
expect(lookupInit.method).toBe("GET");
const [controlUrl, controlInit] = fetchMock.mock.calls[1] as [string, RequestInit];
expect(String(controlUrl)).toBe(
"http://localhost:3100/api/execution-workspaces/44444444-4444-4444-8444-444444444444/runtime-services/restart",
);
expect(controlInit.method).toBe("POST");
expect(JSON.parse(String(controlInit.body))).toEqual({
workspaceCommandId: "web",
});
});
it("waits for an issue workspace runtime service URL", async () => {
const fetchMock = vi.fn()
.mockResolvedValueOnce(mockJsonResponse({
currentExecutionWorkspace: {
id: "44444444-4444-4444-8444-444444444444",
runtimeServices: [
{
id: "55555555-5555-4555-8555-555555555555",
serviceName: "web",
status: "running",
healthStatus: "healthy",
url: "http://127.0.0.1:5173",
},
],
},
}));
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipWaitForIssueWorkspaceService");
const response = await tool.execute({
issueId: "PAP-1135",
serviceName: "web",
timeoutSeconds: 1,
});
expect(fetchMock).toHaveBeenCalledTimes(1);
expect(response.content[0]?.text).toContain("http://127.0.0.1:5173");
});
it("creates suggest_tasks interactions with the expected issue-scoped payload", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse({ id: "interaction-1", kind: "suggest_tasks" }),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipSuggestTasks");
await tool.execute({
issueId: "PAP-1135",
idempotencyKey: "run-1:suggest",
payload: {
version: 1,
tasks: [{ clientKey: "task-1", title: "One" }],
},
});
const [url, init] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(String(url)).toBe("http://localhost:3100/api/issues/PAP-1135/interactions");
expect(init.method).toBe("POST");
expect(JSON.parse(String(init.body))).toEqual({
kind: "suggest_tasks",
continuationPolicy: "wake_assignee",
idempotencyKey: "run-1:suggest",
payload: {
version: 1,
tasks: [{ clientKey: "task-1", title: "One" }],
},
});
});
it("creates request_confirmation interactions with plan target payloads", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse({ id: "interaction-1", kind: "request_confirmation" }),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipRequestConfirmation");
await tool.execute({
issueId: "PAP-1135",
idempotencyKey: "confirmation:PAP-1135:plan:33333333-3333-4333-8333-333333333333",
title: "Plan approval",
payload: {
version: 1,
prompt: "Accept this plan?",
acceptLabel: "Accept plan",
allowDeclineReason: true,
rejectLabel: "Request changes",
rejectRequiresReason: true,
supersedeOnUserComment: true,
target: {
type: "issue_document",
key: "plan",
revisionId: "33333333-3333-4333-8333-333333333333",
revisionNumber: 3,
},
},
});
const [url, init] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(String(url)).toBe("http://localhost:3100/api/issues/PAP-1135/interactions");
expect(init.method).toBe("POST");
expect(JSON.parse(String(init.body))).toEqual({
kind: "request_confirmation",
continuationPolicy: "none",
idempotencyKey: "confirmation:PAP-1135:plan:33333333-3333-4333-8333-333333333333",
title: "Plan approval",
payload: {
version: 1,
prompt: "Accept this plan?",
acceptLabel: "Accept plan",
allowDeclineReason: true,
rejectLabel: "Request changes",
rejectRequiresReason: true,
supersedeOnUserComment: true,
target: {
type: "issue_document",
key: "plan",
revisionId: "33333333-3333-4333-8333-333333333333",
revisionNumber: 3,
},
},
});
});
it("creates request_checkbox_confirmation interactions with checkbox payloads", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse({ id: "interaction-1", kind: "request_checkbox_confirmation" }),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipRequestCheckboxConfirmation");
await tool.execute({
issueId: "PAP-1135",
idempotencyKey: "confirmation:PAP-1135:files",
title: "Choose files",
payload: {
version: 1,
prompt: "Which files should be included?",
detailsMarkdown: "Pick the files to attach.",
options: [
{ id: "file-a", label: "File A", description: "Primary draft" },
{ id: "file-b", label: "File B" },
],
defaultSelectedOptionIds: ["file-a"],
minSelected: 1,
maxSelected: 2,
acceptLabel: "Use selected files",
rejectLabel: "Do not attach files",
rejectRequiresReason: true,
allowDeclineReason: false,
},
});
const [url, init] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(String(url)).toBe("http://localhost:3100/api/issues/PAP-1135/interactions");
expect(init.method).toBe("POST");
expect(JSON.parse(String(init.body))).toEqual({
kind: "request_checkbox_confirmation",
continuationPolicy: "wake_assignee",
idempotencyKey: "confirmation:PAP-1135:files",
title: "Choose files",
payload: {
version: 1,
prompt: "Which files should be included?",
detailsMarkdown: "Pick the files to attach.",
options: [
{ id: "file-a", label: "File A", description: "Primary draft" },
{ id: "file-b", label: "File B" },
],
defaultSelectedOptionIds: ["file-a"],
minSelected: 1,
maxSelected: 2,
acceptLabel: "Use selected files",
rejectLabel: "Do not attach files",
rejectRequiresReason: true,
allowDeclineReason: false,
},
});
});
it("creates approvals with the expected company-scoped payload", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse({ id: "approval-1" }),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipCreateApproval");
await tool.execute({
type: "hire_agent",
payload: { branch: "pap-1167" },
issueIds: ["44444444-4444-4444-4444-444444444444"],
});
expect(fetchMock).toHaveBeenCalledTimes(1);
const [url, init] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(String(url)).toBe(
"http://localhost:3100/api/companies/11111111-1111-1111-1111-111111111111/approvals",
);
expect(init.method).toBe("POST");
expect(JSON.parse(String(init.body))).toEqual({
type: "hire_agent",
payload: { branch: "pap-1167" },
issueIds: ["44444444-4444-4444-4444-444444444444"],
});
});
it("rejects invalid generic request paths", async () => {
vi.stubGlobal("fetch", vi.fn());
const tool = getTool("paperclipApiRequest");
const response = await tool.execute({
method: "GET",
path: "issues",
});
expect(response.content[0]?.text).toContain("path must start with /");
});
it("rejects generic request paths that escape /api", async () => {
vi.stubGlobal("fetch", vi.fn());
const tool = getTool("paperclipApiRequest");
const response = await tool.execute({
method: "GET",
path: "/../../secret",
});
expect(response.content[0]?.text).toContain("must not contain '..'");
});
});