fae7e920a9
## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Routines are the recurring-work surface that lets a company keep operating without a human manually kicking off every task > - The base routine detail Variation C shell already landed in #7848, but the follow-up branch still had polish work for scheduling, section ergonomics, and the list layout > - Operators need routine edit screens to explain trigger behavior clearly, keep long detail pages usable on mobile/touch devices, and make grouped routine lists easier to scan > - This pull request rebases the remaining branch work onto current `master`, drops the duplicate commits already merged through #7848, and keeps only the new routine UI follow-ups > - The benefit is a cleaner routines workflow without reopening the already-merged shell work or carrying unrelated lockfile, workflow, or screenshot changes ## Linked Issues or Issue Description Refs #7848 Feature follow-up: polish the routines UI after the Variation C routine-detail shell landed. Problem / motivation: - Routine trigger configuration needs clearer previews for manual, schedule, API, and webhook execution modes. - Routine detail sections need better responsive spacing and touch ergonomics. - The routines list grouping should scan like grouped records instead of a table with heavy row dividers. - The routine tests need a React 19-compatible render helper so the focused routine suite can run in this workspace. Proposed solution: - Add cron-fire preview helpers and routine-run display helpers with focused tests. - Expand the routine editable and operate sections with richer trigger, variable, run, activity, and history presentation. - Adjust the routine detail shell and sub-sidebar spacing for mobile/touch layout. - Update grouped routine list presentation to use bordered group headers with borderless rows. - Switch affected routine tests to the repo's `flushSync` render-helper pattern. Alternatives considered: - Leaving the duplicate pre-#7848 commits in the branch would recreate conflicts and make the PR review much larger than the remaining change. - Keeping grouped routine rows inside one bordered table was simpler, but made the grouping hierarchy less legible. Roadmap alignment: - ROADMAP.md lists Scheduled Routines as a core shipped capability and Output/Enforced Outcomes as ongoing priorities. This is polish on that existing routines capability, not a new roadmap-level feature. ## What Changed - Added routine scheduling preview helpers and tests for cron/manual/API/webhook fire-policy display. - Added routine run display helpers and tests for deduped trigger labels and run-row subtitles. - Polished routine detail sections, including trigger summaries, operate views, and env/variable editing ergonomics. - Adjusted routine detail page and sub-sidebar spacing so the title/header area is less pinned and touch layouts center better. - Reworked the routines list grouped layout so group headers are bordered cards and routine rows are borderless inside each group. - Added Storybook coverage for the routines list grouped layout and updated the existing routine detail story. - Repaired routine tests to use `flushSync` helpers compatible with the installed React 19 runtime. ## Verification - `pnpm exec vitest run ui/src/lib/cron-fires.test.ts ui/src/lib/routine-run-display.test.ts ui/src/pages/Routines.test.tsx ui/src/components/RoutineSubSidebar.test.tsx ui/src/components/RoutineSaveBar.test.tsx` - Result: 5 test files passed, 37 tests passed. - Confirmed the rebased PR diff does not include `pnpm-lock.yaml`, `.github/workflows/*`, or committed screenshots. - Confirmed `origin/master` is an ancestor of the pushed branch head after rebase. ## Risks - Medium UI risk: this touches the routine detail and routine list surfaces, so visual regressions are possible in edge cases not covered by the focused tests. - Low data risk: no schema, migration, server API, or lockfile changes are included. - Review note: the branch intentionally force-pushed after rebasing because the original first three commits were already merged through #7848. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used OpenAI Codex, GPT-5-based coding agent runtime, with repository shell/tool access. Exact hosted runtime model identifier and context-window size were not exposed in the execution environment. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
99 lines
3.7 KiB
TypeScript
99 lines
3.7 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { nextCronFires, parseCronExpression, previewFirePolicies } from "./cron-fires";
|
|
|
|
describe("parseCronExpression", () => {
|
|
it("parses a standard 5-field expression", () => {
|
|
const parsed = parseCronExpression("0 14 * * 1-5");
|
|
expect(parsed).not.toBeNull();
|
|
expect(parsed?.minutes).toEqual([0]);
|
|
expect(parsed?.hours).toEqual([14]);
|
|
expect(parsed?.daysOfWeek).toEqual([1, 2, 3, 4, 5]);
|
|
});
|
|
|
|
it("returns null for malformed expressions", () => {
|
|
expect(parseCronExpression("not a cron")).toBeNull();
|
|
expect(parseCronExpression("0 14 * *")).toBeNull();
|
|
expect(parseCronExpression("")).toBeNull();
|
|
expect(parseCronExpression(null)).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("nextCronFires", () => {
|
|
it("computes the next N daily fires in UTC", () => {
|
|
const after = new Date("2026-06-09T10:00:00Z");
|
|
const fires = nextCronFires("0 14 * * *", 3, { after, timeZone: "UTC" });
|
|
expect(fires.map((d) => d.toISOString())).toEqual([
|
|
"2026-06-09T14:00:00.000Z",
|
|
"2026-06-10T14:00:00.000Z",
|
|
"2026-06-11T14:00:00.000Z",
|
|
]);
|
|
});
|
|
|
|
it("skips weekends for a weekday schedule", () => {
|
|
// 2026-06-12 is a Friday; the next weekday fire after Fri is Mon 2026-06-15.
|
|
const after = new Date("2026-06-12T15:00:00Z");
|
|
const fires = nextCronFires("0 14 * * 1-5", 2, { after, timeZone: "UTC" });
|
|
expect(fires.map((d) => d.toISOString())).toEqual([
|
|
"2026-06-15T14:00:00.000Z",
|
|
"2026-06-16T14:00:00.000Z",
|
|
]);
|
|
});
|
|
|
|
it("uses OR semantics when day-of-month and day-of-week are both restricted", () => {
|
|
const after = new Date("2026-06-09T10:00:00Z");
|
|
const fires = nextCronFires("0 9 15 * 5", 3, { after, timeZone: "UTC" });
|
|
expect(fires.map((d) => d.toISOString())).toEqual([
|
|
"2026-06-12T09:00:00.000Z",
|
|
"2026-06-15T09:00:00.000Z",
|
|
"2026-06-19T09:00:00.000Z",
|
|
]);
|
|
});
|
|
|
|
it("interprets cron fields in the trigger timezone", () => {
|
|
// 14:00 in New York (EDT, UTC-4 in June) is 18:00 UTC.
|
|
const after = new Date("2026-06-09T10:00:00Z");
|
|
const fires = nextCronFires("0 14 * * *", 1, { after, timeZone: "America/New_York" });
|
|
expect(fires[0]?.toISOString()).toBe("2026-06-09T18:00:00.000Z");
|
|
});
|
|
|
|
it("returns an empty list for an unparseable expression", () => {
|
|
expect(nextCronFires("garbage", 5)).toEqual([]);
|
|
expect(nextCronFires("0 14 * * *", 0)).toEqual([]);
|
|
});
|
|
});
|
|
|
|
describe("previewFirePolicies", () => {
|
|
const fires = [
|
|
new Date("2026-06-09T14:00:00Z"),
|
|
new Date("2026-06-10T14:00:00Z"),
|
|
new Date("2026-06-11T14:00:00Z"),
|
|
];
|
|
|
|
it("always queues the first fire regardless of policy", () => {
|
|
for (const policy of ["coalesce_if_active", "always_enqueue", "skip_if_active"]) {
|
|
expect(previewFirePolicies(fires, policy)[0]?.disposition).toBe("queued");
|
|
}
|
|
});
|
|
|
|
it("coalesces subsequent fires under coalesce_if_active", () => {
|
|
const preview = previewFirePolicies(fires, "coalesce_if_active");
|
|
expect(preview.map((e) => e.disposition)).toEqual(["queued", "coalesced", "coalesced"]);
|
|
expect(preview[1]?.label).toBe("would be coalesced");
|
|
});
|
|
|
|
it("skips subsequent fires under skip_if_active", () => {
|
|
const preview = previewFirePolicies(fires, "skip_if_active");
|
|
expect(preview.map((e) => e.disposition)).toEqual(["queued", "skipped", "skipped"]);
|
|
});
|
|
|
|
it("queues every fire under always_enqueue", () => {
|
|
const preview = previewFirePolicies(fires, "always_enqueue");
|
|
expect(preview.every((e) => e.disposition === "queued")).toBe(true);
|
|
});
|
|
|
|
it("defaults unknown policies to coalesce", () => {
|
|
const preview = previewFirePolicies(fires, "mystery");
|
|
expect(preview[1]?.disposition).toBe("coalesced");
|
|
});
|
|
});
|